| Message ID | 20240423182428.704159-1-prabhakar.mahadev-lad.rj@bp.renesas.com |
|---|---|
| Headers | show |
| Series | Update compat strings for SD/MMC nodes on RZ/{G2L (family), G3S, V2M} SoCs | expand |
On 23/04/2024 20:24, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Group single const value items into an enum list. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > v1->v2 > - Updated commit message > - Grouped single const value items into an enum list. > --- > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++----------- > 1 file changed, 7 insertions(+), 11 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > index 29f2400247eb..2bf90095742b 100644 > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > @@ -13,15 +13,13 @@ properties: > compatible: > oneOf: > - items: > - - const: renesas,sdhi-sh73a0 # R-Mobile APE6 > - - items: > - - const: renesas,sdhi-r7s72100 # RZ/A1H > - - items: > - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5 > - - items: > - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6 > - - items: > - - const: renesas,sdhi-r8a7740 # R-Mobile A1 > + - enum: You wanted to drop the items, but I still see it here. > + - renesas,sdhi-sh73a0 # R-Mobile APE6 > + - renesas,sdhi-r7s72100 # RZ/A1H > + - renesas,sdhi-r7s9210 # SH-Mobile AG5 > + - renesas,sdhi-r8a73a4 # R-Mobile APE6 > + - renesas,sdhi-r8a7740 # R-Mobile A1 > + - renesas,sdhi-mmc-r8a77470 # RZ/G1C Keep list alphabetically ordered. Best regards, Krzysztof
On Tue, Apr 23, 2024 at 8:24 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > - RZ/G2UL and RZ/Five ("r9a07g043") > - RZ/G2L(C) ("r9a07g044") > - RZ/V2L ("r9a07g054") > - RZ/G3S ("r9a08g045") > - RZ/V2M ("r9a09g011") > > The above SoCs have HS400 disabled and use fixed address mode. Add a > generic compatible 'renesas,rzg2l-sdhi' fallback string for these SoCs, > where fixed_addr_mode and hs400_disabled quirks are applied. > > For backward compatibility, compatible string 'renesas,sdhi-r9a09g011' for > RZ/V2M is retained. > > Also rename sdhi_quirks_r9a09g011->sdhi_quirks_rzg2l and > of_r9a09g011_compatible->of_rzg2l_compatible to make it generic. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > v1->v2 > - Updated commit message > - For backward compatibility retained RZ/V2M compat string Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hi Krzysztof, Thank you for the review. On Wed, Apr 24, 2024 at 6:42 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 23/04/2024 20:24, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Group single const value items into an enum list. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > v1->v2 > > - Updated commit message > > - Grouped single const value items into an enum list. > > --- > > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++----------- > > 1 file changed, 7 insertions(+), 11 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > index 29f2400247eb..2bf90095742b 100644 > > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > @@ -13,15 +13,13 @@ properties: > > compatible: > > oneOf: > > - items: > > - - const: renesas,sdhi-sh73a0 # R-Mobile APE6 > > - - items: > > - - const: renesas,sdhi-r7s72100 # RZ/A1H > > - - items: > > - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5 > > - - items: > > - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6 > > - - items: > > - - const: renesas,sdhi-r8a7740 # R-Mobile A1 > > + - enum: > > You wanted to drop the items, but I still see it here. > Ah, I missed that. > > + - renesas,sdhi-sh73a0 # R-Mobile APE6 > > + - renesas,sdhi-r7s72100 # RZ/A1H > > + - renesas,sdhi-r7s9210 # SH-Mobile AG5 > > + - renesas,sdhi-r8a73a4 # R-Mobile APE6 > > + - renesas,sdhi-r8a7740 # R-Mobile A1 > > + - renesas,sdhi-mmc-r8a77470 # RZ/G1C > > Keep list alphabetically ordered. > This list is sorted based on SoC, I will sort it alphabetically. Geert is that OK with you? Cheers, Prabhakar
Hi Prabhakar, On Thu, Apr 25, 2024 at 5:44 PM Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > On Wed, Apr 24, 2024 at 6:42 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 23/04/2024 20:24, Prabhakar wrote: > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > Group single const value items into an enum list. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > --- > > > v1->v2 > > > - Updated commit message > > > - Grouped single const value items into an enum list. > > > --- > > > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++----------- > > > 1 file changed, 7 insertions(+), 11 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > > index 29f2400247eb..2bf90095742b 100644 > > > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > > @@ -13,15 +13,13 @@ properties: > > > compatible: > > > oneOf: > > > - items: > > > - - const: renesas,sdhi-sh73a0 # R-Mobile APE6 > > > - - items: > > > - - const: renesas,sdhi-r7s72100 # RZ/A1H > > > - - items: > > > - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5 > > > - - items: > > > - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6 > > > - - items: > > > - - const: renesas,sdhi-r8a7740 # R-Mobile A1 > > > + - enum: > > > > You wanted to drop the items, but I still see it here. > > > Ah, I missed that. > > > > + - renesas,sdhi-sh73a0 # R-Mobile APE6 > > > + - renesas,sdhi-r7s72100 # RZ/A1H > > > + - renesas,sdhi-r7s9210 # SH-Mobile AG5 > > > + - renesas,sdhi-r8a73a4 # R-Mobile APE6 > > > + - renesas,sdhi-r8a7740 # R-Mobile A1 > > > + - renesas,sdhi-mmc-r8a77470 # RZ/G1C > > > > Keep list alphabetically ordered. > > > This list is sorted based on SoC, I will sort it alphabetically. > > Geert is that OK with you? Usually we sort alphabetically by compatible value. (FTR, sh73a0 is sometimes called r8a73a0). Gr{oetje,eeting}s, Geert
On 25/04/2024 19:11, Geert Uytterhoeven wrote: >> >>>> + - renesas,sdhi-sh73a0 # R-Mobile APE6 >>>> + - renesas,sdhi-r7s72100 # RZ/A1H >>>> + - renesas,sdhi-r7s9210 # SH-Mobile AG5 >>>> + - renesas,sdhi-r8a73a4 # R-Mobile APE6 >>>> + - renesas,sdhi-r8a7740 # R-Mobile A1 >>>> + - renesas,sdhi-mmc-r8a77470 # RZ/G1C >>> >>> Keep list alphabetically ordered. >>> >> This list is sorted based on SoC, I will sort it alphabetically. >> >> Geert is that OK with you? > > Usually we sort alphabetically by compatible value. BTW, it is also fine if you keep some other sorting rule there, which is in general known to interested parties. Although I would argue that most people adding new entries are not aware of such rules, thus they add things to the end increasing the chances for conflicts. Best regards, Krzysztof
Hi Geert, On Thu, Apr 25, 2024 at 6:11 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Thu, Apr 25, 2024 at 5:44 PM Lad, Prabhakar > <prabhakar.csengg@gmail.com> wrote: > > On Wed, Apr 24, 2024 at 6:42 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > On 23/04/2024 20:24, Prabhakar wrote: > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > > > Group single const value items into an enum list. > > > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > --- > > > > v1->v2 > > > > - Updated commit message > > > > - Grouped single const value items into an enum list. > > > > --- > > > > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++----------- > > > > 1 file changed, 7 insertions(+), 11 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > > > index 29f2400247eb..2bf90095742b 100644 > > > > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > > > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > > > @@ -13,15 +13,13 @@ properties: > > > > compatible: > > > > oneOf: > > > > - items: > > > > - - const: renesas,sdhi-sh73a0 # R-Mobile APE6 > > > > - - items: > > > > - - const: renesas,sdhi-r7s72100 # RZ/A1H > > > > - - items: > > > > - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5 > > > > - - items: > > > > - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6 > > > > - - items: > > > > - - const: renesas,sdhi-r8a7740 # R-Mobile A1 > > > > + - enum: > > > > > > You wanted to drop the items, but I still see it here. > > > > > Ah, I missed that. > > > > > > + - renesas,sdhi-sh73a0 # R-Mobile APE6 > > > > + - renesas,sdhi-r7s72100 # RZ/A1H > > > > + - renesas,sdhi-r7s9210 # SH-Mobile AG5 > > > > + - renesas,sdhi-r8a73a4 # R-Mobile APE6 > > > > + - renesas,sdhi-r8a7740 # R-Mobile A1 > > > > + - renesas,sdhi-mmc-r8a77470 # RZ/G1C > > > > > > Keep list alphabetically ordered. > > > > > This list is sorted based on SoC, I will sort it alphabetically. > > > > Geert is that OK with you? > > Usually we sort alphabetically by compatible value. > Thank you for the confirmation. > (FTR, sh73a0 is sometimes called r8a73a0). > Got that. Cheers, Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Hi All, - RZ/G2UL and RZ/Five ("r9a07g043") - RZ/G2L(C) ("r9a07g044") - RZ/V2L ("r9a07g054") - RZ/G3S ("r9a08g045") - RZ/V2M ("r9a09g011") The SD/MMC Interface in the above listed SoCs is not identical to that of R-Car Gen3. These SoCs have HS400 disabled and use fixed address mode. Therefore, we need to apply fixed_addr_mode and hs400_disabled quirks. 'renesas,rzg2l-sdhi' is introduced as a generic compatible string for the above SoCs where fixed_addr_mode and hs400_disabled quirks will be applied. v1->v2 - Updated commit messages for patch #1 and #2 - Dropped SoC DTSI changes as its a hard dependency - Grouped single const value items into an enum list. - For backward compatibility retained RZ/V2M compat string v1: https://patchwork.kernel.org/project/linux-renesas-soc/cover/20240422213006.505576-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ Cheers, Prabhakar Lad Prabhakar (3): dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list dt-bindings: mmc: renesas,sdhi: Document RZ/G2L family compatibility mmc: renesas_sdhi: Add compatible string for RZ/G2L family, RZ/G3S, and RZ/V2M SoCs .../devicetree/bindings/mmc/renesas,sdhi.yaml | 38 ++++++++----------- drivers/mmc/host/renesas_sdhi_internal_dmac.c | 9 +++-- 2 files changed, 21 insertions(+), 26 deletions(-)