From patchwork Mon Feb 10 22:33:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 864747 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D59BC2512ED for ; Mon, 10 Feb 2025 22:37:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227054; cv=none; b=QoKJuKlst2Sxt1ql2P0O3JTK7M+9q0t5P9BUEHyQ513XUlyWrBz9vPJITrorYYjQrU69XODx75skOSJTtUlJ5kELwrT84Gd9OXO4/tDFGbuVi41a8+SnBKVTfTBTHxnQadmq5nHmdTeMNqmMvXmWIJkIyJAN721ifH9GuUvhhRQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227054; c=relaxed/simple; bh=afEXr0Ym345b+01JWvSTXXjtaEwJ8nYEblSojlE39NE=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=NuwbIprreCI4qR9fHLSC+OVrm1vU7kZEi3LHry7fPfRCAu0UL7+ZgJ35MWsvzC+4sQBxwXsAt4T4LSQ2GggOYLJoFqDfTzwO8b+wCHQCgWZJhuD/fnCAZlvCgUP8dja1yPts237IyAQ7nJcGYcxe+PU1Qf1Knj0h1Tf4s+E42Hw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=dNxvM1PT; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="dNxvM1PT" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3f3bac262f9so586776b6e.1 for ; Mon, 10 Feb 2025 14:37:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227050; x=1739831850; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=Ab4LJ9OfN5R35QeUwpcAeHgQPVCquBOJeARRwrwUU60=; b=dNxvM1PTOikhj0bgd5gWpulEoUseM6YcLRSKCSZEzbP2S5Y+OWKJYP5ZZPl44zLIvX aUe910QjwwjJgQv5A4TouSJ8bzjuEn+b1mdVk6VJKO0QlqL8b5pzqv6fVowCEa1KtQTt z4k8TtljAtU7Pg6PmrQAjmrPMGUcx478O/sXboCOOZI3s9zHbWkIz8oMPvvd0u06JDFS Zb4AcpG2f3hKWhfFJZDOGdkzsbLOGq8eXVbPAX7++k49MRIStGtCfRvZj92Tx8BA4qeI FtZatXQVjv6SMloLyLMKsUDzSYv+jr/a+am0PPirSbGBPuEmJof3Pon3ZIEis+em24fL CORQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227050; x=1739831850; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ab4LJ9OfN5R35QeUwpcAeHgQPVCquBOJeARRwrwUU60=; b=DSZPIwKE5y2tBMI4f49NKumnWCrB2zHjRgpJpVcWbdLKXtjKuEfVD9KISZWGostxMl qBrhHVRYo8g03S4n7z8jGTBVgOSWhVrtDzfgdpk6WtSjhPubfMfmYskvtmPR25tt7iFq XxS7hzsqY6eckX8lgU2k/a6CigTP5ERAVQkYopVJpWAA3WIQv5YTYUF6ESex35gBtHGu KUBY5C0JbmIYEM18KmlrpE99kAJjuOtqwofGZ6fZKqc4X0Q40n36dhqhkP/X1L4TdsP+ sgrTCxmsXctSoCuMbuEjOf5yvHhksBOgEtVQFhqUdzqMuBk2SROgEnJEA8/5Jj4P8FAY qFFQ== X-Forwarded-Encrypted: i=1; AJvYcCXhNOw5BNwJoXgvYM5cta+Pl2ul7WMwHG3wCklGHsZWaVxdNEVK7+N4EYbYwvva1y9hs4GB2anYqfg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/hnI8Xvl3FXYHBQxx0zvyxtcsYnedH+RcZn2/qfmOx7WE5Oiy jqLC/q4J+AhkkPv8lIs2lDcR+4pYo6uOaT4qaBCSgjxSV2z/6TWhgE2Qz4UZnQs= X-Gm-Gg: ASbGncszAgpU0d15Nvc6X9Z/JqoIoL6OIB0cYve9aXji8GGvTsSVfnAZZgKQ7vEI2Mn IsP3fwO9jMx5d0EKvx0o7qgnJu1PU/rMBSGHoOU1P4hJR2t0lYgdByWsWRQz5WL7dTFCmSi957S xGihjwga/Th29M4TQJqdKMJZs3rngM+BbWJUJgh6DAk/WSPPQWcZ3qVehmRijb+dgovlD/F7MFB OomFKU9RsqHxiBZaKPdVhWhDVswEM/3wv30FMPqKSdvpxszsCNnNX3WVEYUo8bqUHQea5QzJOkT zIJ9dCUd6PVI8Dxrq6tjge3D6LgL3ulkURiaraVIo5vvTBI= X-Google-Smtp-Source: AGHT+IFEgA0pJb7eJnXxFcDkmebwOZge9kDnXmYCEiBKRqgUBP3v1eLeI1sEGHGrzyQ56T+MANckEg== X-Received: by 2002:a05:6808:18a3:b0:3f3:bf98:c4b1 with SMTP id 5614622812f47-3f3bf98c976mr1193202b6e.33.1739227049851; Mon, 10 Feb 2025 14:37:29 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:28 -0800 (PST) From: David Lechner Subject: [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep Date: Mon, 10 Feb 2025 16:33:26 -0600 Message-Id: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIALZ+qmcC/4XNywrCMBCF4VeRrB3JpVdXvoe4SNJpG6hNmZRgK X13024EQVz+B+ablQUkh4FdTysjjC44P6ZQ5xOzvR47BNekZpLLnAsloJuch4AzaCK9QI/DhAS mybSSlSp5o1i6nQhb9zrc+yN178LsaTneRLGv/8QogENdC1tZa7KmwJvRy+AM4cX6J9vRKD+Q5 MUvSCZI2LzlWdWWtVVf0LZtb7b5zjgGAQAA X-Change-ID: 20250131-gpio-set-array-helper-bd4a328370d3 To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner , Andy Shevchenko , Jonathan Cameron X-Mailer: b4 0.14.2 This series was inspired by some minor annoyance I have experienced a few times in recent reviews. Calling gpiod_set_array_value_cansleep() can be quite verbose due to having so many parameters. In most cases, we already have a struct gpio_descs that contains the first 3 parameters so we end up with 3 (or often even 6) pointer indirections at each call site. Also, people have a tendency to want to hard-code the first argument instead of using struct gpio_descs.ndescs, often without checking that ndescs >= the hard-coded value. So I'm proposing that we add a gpiod_multi_set_value_cansleep() function that is a wrapper around gpiod_set_array_value_cansleep() that has struct gpio_descs as the first parameter to make it a bit easier to read the code and avoid the hard-coding temptation. I've just done gpiod_multi_set_value_cansleep() for now since there were over 10 callers of this one. There aren't as many callers of the get and atomic variants, but we can add those too if this seems like a useful thing to do. Maintainers, if you prefer to have this go through the gpio tree, please give your Acked-by:. Several maintainers have also requested an immutable branch, so I expect that will be made available. And if there is anything leftover after the next kernel release, I will resend it. --- Changes in v3: - Added IS_ERR_OR_NULL() check to gpiod_multi_set_value_cansleep() - Added new patches to clean up accessing bitmap directly (ts-nbus, ad2s1210). - Added function prefix for max3191x. - Removed unnecessary braces in ad7606 patch. - Picked up additional trailers. - Link to v2: https://lore.kernel.org/r/20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com Changes in v2: - Renamed new function from gpiods_multi_set_value_cansleep() to gpiod_multi_set_value_cansleep() - Fixed typo in name of replaced function in all commit messages. - Picked up trailers. - Link to v1: https://lore.kernel.org/r/20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com --- David Lechner (15): gpiolib: add gpiod_multi_set_value_cansleep() auxdisplay: seg-led-gpio: use gpiod_multi_set_value_cansleep bus: ts-nbus: validate ts,data-gpios array size bus: ts-nbus: use gpiod_multi_set_value_cansleep bus: ts-nbus: use bitmap_get_value8() gpio: max3191x: use gpiod_multi_set_value_cansleep iio: adc: ad7606: use gpiod_multi_set_value_cansleep iio: amplifiers: hmc425a: use gpiod_multi_set_value_cansleep iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep iio: resolver: ad2s1210: use bitmap_write mmc: pwrseq_simple: use gpiod_multi_set_value_cansleep mux: gpio: use gpiod_multi_set_value_cansleep net: mdio: mux-gpio: use gpiod_multi_set_value_cansleep phy: mapphone-mdm6600: use gpiod_multi_set_value_cansleep ASoC: adau1701: use gpiod_multi_set_value_cansleep drivers/auxdisplay/seg-led-gpio.c | 3 +-- drivers/bus/ts-nbus.c | 15 +++++++++------ drivers/gpio/gpio-max3191x.c | 18 +++++++----------- drivers/iio/adc/ad7606.c | 3 +-- drivers/iio/adc/ad7606_spi.c | 7 +++---- drivers/iio/amplifiers/hmc425a.c | 3 +-- drivers/iio/resolver/ad2s1210.c | 13 +++++-------- drivers/mmc/core/pwrseq_simple.c | 3 +-- drivers/mux/gpio.c | 4 +--- drivers/net/mdio/mdio-mux-gpio.c | 3 +-- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +--- include/linux/gpio/consumer.h | 11 +++++++++++ sound/soc/codecs/adau1701.c | 4 +--- 13 files changed, 43 insertions(+), 48 deletions(-) --- base-commit: df4b2bbff898227db0c14264ac7edd634e79f755 change-id: 20250131-gpio-set-array-helper-bd4a328370d3 Best regards,