[v3,12/13] mmc: meson-gx: change default tx phase

Message ID	20170828142915.27020-13-jbrunet@baylibre.com
State	New
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; From: Jerome Brunet <jbrunet@baylibre.com> To: Ulf Hansson <ulf.hansson@linaro.org>, Kevin Hilman <khilman@baylibre.com>, Carlo Caione <carlo@caione.org> Cc: Jerome Brunet <jbrunet@baylibre.com>, linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 12/13] mmc: meson-gx: change default tx phase Date: Mon, 28 Aug 2017 16:29:14 +0200 Message-Id: <20170828142915.27020-13-jbrunet@baylibre.com> In-Reply-To: <20170828142915.27020-1-jbrunet@baylibre.com> References: <20170828142915.27020-1-jbrunet@baylibre.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk
Series	mmc: meson-gx: driver fixups and upgrades \| expand [v3,00/13] mmc: meson-gx: driver fixups and upgrades [v3,01/13] mmc: meson-gx: initialize sane clk default before clock register [v3,04/13] mmc: meson-gx: rework clk_set function [v3,08/13] mmc: meson-gx: simplify interrupt handler [v3,11/13] mmc: meson-gx: implement voltage switch callback [v3,12/13] mmc: meson-gx: change default tx phase

Message ID

20170828142915.27020-13-jbrunet@baylibre.com

State

New

Headers

Received-SPF: pass (google.com: best guess record for domain of
	linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as
	permitted sender) client-ip=209.132.180.67; 
From: Jerome Brunet <jbrunet@baylibre.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>, Carlo Caione <carlo@caione.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>, linux-mmc@vger.kernel.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 12/13] mmc: meson-gx: change default tx phase
Date: Mon, 28 Aug 2017 16:29:14 +0200
Message-Id: <20170828142915.27020-13-jbrunet@baylibre.com>
In-Reply-To: <20170828142915.27020-1-jbrunet@baylibre.com>
References: <20170828142915.27020-1-jbrunet@baylibre.com>
Sender: linux-mmc-owner@vger.kernel.org
Precedence: bulk

Series

mmc: meson-gx: driver fixups and upgrades | expand

Commit Message

Jerome Brunet Aug. 28, 2017, 2:29 p.m. UTC

Initial default tx phase was set to 0 while the datasheet recommends 270.
Some cards fails to initialize with this setting and eMMC mode DDR52 does
not work.

Changing this setting to 270 fixes these issues, without any regression
so far

Reviewed-by: Kevin Hilman <khilman@baylibre.com>

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

---
 drivers/mmc/host/meson-gx-mmc.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

-- 
2.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 0cffc705bfe3..efffd36c8d77 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1156,8 +1156,14 @@  static int meson_mmc_probe(struct platform_device *pdev)
 	if (ret)
 		goto free_host;
 
+	/*
+	 * Set phases : These values are mostly the datasheet recommended ones
+	 * except for the Tx phase. Datasheet recommends 180 but some cards
+	 * fail at initialisation with it. 270 works just fine, it fixes these
+	 * initialisation issues and enable eMMC DDR52 mode.
+	 */
 	host->tp.core_phase = 180;
-	host->tp.tx_phase = 0;
+	host->tp.tx_phase = 270;
 	host->tp.rx_phase = 0;
 
 	ret = meson_mmc_clk_init(host);

[v3,12/13] mmc: meson-gx: change default tx phase

Commit Message

Patch