diff mbox series

[2/6,v2] mmc: mxs-mmc: Drop unused includes

Message ID 20190211082604.11013-2-linus.walleij@linaro.org
State New
Headers show
Series [1/6,v2] mmc: mxcmmc: Drop unused includes | expand

Commit Message

Linus Walleij Feb. 11, 2019, 8:26 a.m. UTC 
The MXS-MMC driver uses slot GPIO helpers and does not make
any use of <linux/gpio.h> or <linux/of_gpio.h> so drop these
surplus includes.

Cc: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 drivers/mmc/host/mxs-mmc.c | 2 --
 1 file changed, 2 deletions(-)

-- 
2.20.1

Comments

Stefan Wahren Feb. 11, 2019, 9:01 a.m. UTC | #1 
Hi,

Am 11.02.19 um 09:26 schrieb Linus Walleij:
> The MXS-MMC driver uses slot GPIO helpers and does not make

> any use of <linux/gpio.h> or <linux/of_gpio.h> so drop these

> surplus includes.

>

> Cc: Marek Vasut <marex@denx.de>

> Cc: Fabio Estevam <fabio.estevam@nxp.com>

> Cc: Stefan Wahren <stefan.wahren@i2se.com>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>


i only want to mention that Fabio already gave his Reviewed-by for this
patch.

Thanks
Linus Walleij Feb. 11, 2019, 1:28 p.m. UTC | #2 
On Mon, Feb 11, 2019 at 10:01 AM Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Am 11.02.19 um 09:26 schrieb Linus Walleij:

> > The MXS-MMC driver uses slot GPIO helpers and does not make

> > any use of <linux/gpio.h> or <linux/of_gpio.h> so drop these

> > surplus includes.

> >

> > Cc: Marek Vasut <marex@denx.de>

> > Cc: Fabio Estevam <fabio.estevam@nxp.com>

> > Cc: Stefan Wahren <stefan.wahren@i2se.com>

> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

>

> i only want to mention that Fabio already gave his Reviewed-by for this

> patch.


Ooops sorry I missed that :(
Ulf can you add Fabio's Reviewed-by when applying?

Yours,
Linus Walleij
Ulf Hansson Feb. 11, 2019, 2:08 p.m. UTC | #3 
On Mon, 11 Feb 2019 at 14:28, Linus Walleij <linus.walleij@linaro.org> wrote:
>

> On Mon, Feb 11, 2019 at 10:01 AM Stefan Wahren <stefan.wahren@i2se.com> wrote:

> > Am 11.02.19 um 09:26 schrieb Linus Walleij:

> > > The MXS-MMC driver uses slot GPIO helpers and does not make

> > > any use of <linux/gpio.h> or <linux/of_gpio.h> so drop these

> > > surplus includes.

> > >

> > > Cc: Marek Vasut <marex@denx.de>

> > > Cc: Fabio Estevam <fabio.estevam@nxp.com>

> > > Cc: Stefan Wahren <stefan.wahren@i2se.com>

> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> >

> > i only want to mention that Fabio already gave his Reviewed-by for this

> > patch.

>

> Ooops sorry I missed that :(

> Ulf can you add Fabio's Reviewed-by when applying?


Yep, no problem!

Kind regards
Uffe
diff mbox series

Patch

diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
index add1e70195ea..4f06fb03c0a2 100644
--- a/drivers/mmc/host/mxs-mmc.c
+++ b/drivers/mmc/host/mxs-mmc.c
@@ -25,7 +25,6 @@ 
 #include <linux/ioport.h>
 #include <linux/of.h>
 #include <linux/of_device.h>
-#include <linux/of_gpio.h>
 #include <linux/platform_device.h>
 #include <linux/delay.h>
 #include <linux/interrupt.h>
@@ -39,7 +38,6 @@ 
 #include <linux/mmc/mmc.h>
 #include <linux/mmc/sdio.h>
 #include <linux/mmc/slot-gpio.h>
-#include <linux/gpio.h>
 #include <linux/regulator/consumer.h>
 #include <linux/module.h>
 #include <linux/stmp_device.h>