From patchwork Mon Dec 22 14:41:30 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 42523 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f199.google.com (mail-lb0-f199.google.com [209.85.217.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C956925BA1 for ; Mon, 22 Dec 2014 14:41:37 +0000 (UTC) Received: by mail-lb0-f199.google.com with SMTP id u10sf2975989lbd.2 for ; Mon, 22 Dec 2014 06:41:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:content-type:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe; bh=lluIcZ+/S3YvO91tyyVFFmklTKPaRdB0FqoxukoPE20=; b=SkL+t6I7OrOArdygHnPVDzll8pev4+XU4tP+JjpVbg3IionBDnEN/LUia251cZ7arM xWujtDvnV53EEQpEmC9J4DWOnEKWLQSScYbQYMfcuaFVPx94nCwupvVgVhdb8gPfmfuw xhmGGEhGlSC+J3RMeTYYeYCBNp/fiZagZlZiIrTrVSu5VuVUYR/Aphh/KBemrQG/n+Ch ++eIlOWxN0c+1IAQ0hR+RvF+KWcNQBUxUWE/vSQzt11hLJzRU2D4EO3bsxIWVE1gY8iR dEL6LYWUsuF+y2U79euT+r0J47sJDf6Wl7WoaKTnoYBw2D6pQv7n0QbJ0czlIZTTcxml C6+g== X-Gm-Message-State: ALoCoQlXsvOuIpMwYV1y0YQM1Yt10rJg5perJ2jpduZUsmC5m857V3knB6ng/gaQNu4ypXkO+QAB X-Received: by 10.180.99.227 with SMTP id et3mr2164061wib.3.1419259296694; Mon, 22 Dec 2014 06:41:36 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.87.50 with SMTP id u18ls1540428laz.96.gmail; Mon, 22 Dec 2014 06:41:36 -0800 (PST) X-Received: by 10.152.8.82 with SMTP id p18mr22476291laa.25.1419259296392; Mon, 22 Dec 2014 06:41:36 -0800 (PST) Received: from mail-la0-f45.google.com (mail-la0-f45.google.com. [209.85.215.45]) by mx.google.com with ESMTPS id d2si18705773laf.39.2014.12.22.06.41.36 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 22 Dec 2014 06:41:36 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) client-ip=209.85.215.45; Received: by mail-la0-f45.google.com with SMTP id gq15so4058452lab.4 for ; Mon, 22 Dec 2014 06:41:36 -0800 (PST) X-Received: by 10.152.26.201 with SMTP id n9mr22608199lag.50.1419259296230; Mon, 22 Dec 2014 06:41:36 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.142.69 with SMTP id ru5csp1046372lbb; Mon, 22 Dec 2014 06:41:35 -0800 (PST) X-Received: by 10.70.109.174 with SMTP id ht14mr36026125pdb.74.1419259294069; Mon, 22 Dec 2014 06:41:34 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gu10si25388821pbc.92.2014.12.22.06.41.33; Mon, 22 Dec 2014 06:41:34 -0800 (PST) Received-SPF: none (google.com: linux-mmc-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755023AbaLVOlc (ORCPT + 3 others); Mon, 22 Dec 2014 09:41:32 -0500 Received: from mail-qg0-f53.google.com ([209.85.192.53]:33169 "EHLO mail-qg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754763AbaLVOlb (ORCPT ); Mon, 22 Dec 2014 09:41:31 -0500 Received: by mail-qg0-f53.google.com with SMTP id l89so3326615qgf.26 for ; Mon, 22 Dec 2014 06:41:30 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.229.212.67 with SMTP id gr3mr4052068qcb.6.1419259290462; Mon, 22 Dec 2014 06:41:30 -0800 (PST) Received: by 10.96.3.73 with HTTP; Mon, 22 Dec 2014 06:41:30 -0800 (PST) In-Reply-To: References: <1417780783-12939-1-git-send-email-ulf.hansson@linaro.org> <1417780783-12939-4-git-send-email-ulf.hansson@linaro.org> Date: Mon, 22 Dec 2014 15:41:30 +0100 Message-ID: Subject: Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning() From: Ulf Hansson To: Alim Akhtar Cc: "linux-mmc@vger.kernel.org" , Chris Ball , Seungwon Jeon , Jaehoon Chung , Shawn Guo , Sascha Hauer , Aisheng Dong , Stephen Boyd , Minda Chen , Barry Song Sender: linux-mmc-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ulf.hansson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 20 December 2014 at 14:18, Alim Akhtar wrote: > Hi Ulf, > > On Mon, Dec 8, 2014 at 3:40 PM, Ulf Hansson wrote: >> On 6 December 2014 at 13:43, Alim Akhtar wrote: >>> Hi Ulf, >>> >>> On Fri, Dec 5, 2014 at 5:29 PM, Ulf Hansson wrote: >>>> Instead of having a local hack taking care of sending the tuning >>>> command and as well to verify the response pattern, let's convert to >>>> the common mmc_send_tuning() API. >>>> >>>> This change affects the Exynos variant, since it's the only one which >>>> support the dw_mmc's ->execute_tuning() callback. >>>> >>>> Signed-off-by: Ulf Hansson >>>> --- >>>> >> >> Alim, thanks for helping out testing! >> >>> With this change HS200 mode does not work on exynos5800 peach-pi board. >>> I got below error while testing this series: >>> >>> mmc0: tuning execution failed >>> mmc0: error -5 whilst initialising MMC card >>> >>> Though, your's next branch with commit _a1d06b4_ works fine in HS200 mode. >> >> I was looking into the details of what change my patchset introduces >> for dw_mmc-exynos. Apparently, dw_mmc-exynos was using the >> MMC_STOP_TRANSMISSION to end the tuning reqeust (CMD21/19). The new >> mmc_send_tuning() API doesn't, which also conforms to what the eMMC/SD >> specifications states. >> >> Do you have any idea of why dw_mmc-exynos was using >> MMC_STOP_TRANSMISSION for CMD19/21? >> >> To see if my theory is correct, could you try out the following patch >> on top of $subject patch? >> BTW, I have queued patch 1 and 2, from this patchset available on my >> next branch. >> >> >> From e1ac35bb0e90254275ec7088f41e6e2d59e48367 Mon Sep 17 00:00:00 2001 >> From: Ulf Hansson >> Date: Mon, 8 Dec 2014 10:58:48 +0100 >> Subject: [PATCH] mmc: core: End tuning request with stop command >> >> Not to be merged! >> >> This patch adds the MMC_STOP_TRANSMISSION command to end a tuning >> request. For some reason dw_mmc seems to need this to complete the >> tuning request without errors. >> >> Signed-off-by: Ulf Hansson >> --- >> drivers/mmc/core/mmc_ops.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c >> index 3b044c5..aa79e0c 100644 >> --- a/drivers/mmc/core/mmc_ops.c >> +++ b/drivers/mmc/core/mmc_ops.c >> @@ -551,6 +551,7 @@ int mmc_send_tuning(struct mmc_host *host) >> { >> struct mmc_request mrq = {NULL}; >> struct mmc_command cmd = {0}; >> + struct mmc_command stop = {0}; >> struct mmc_data data = {0}; >> struct scatterlist sg; >> struct mmc_ios *ios = &host->ios; >> @@ -576,10 +577,14 @@ int mmc_send_tuning(struct mmc_host *host) >> >> mrq.cmd = &cmd; >> mrq.data = &data; >> + mrq.stop = &stop; >> >> cmd.opcode = opcode; >> cmd.flags = MMC_RSP_R1 | MMC_CMD_ADTC; >> >> + stop.opcode = MMC_STOP_TRANSMISSION; >> + stop.flags = MMC_RSP_R1B | MMC_CMD_AC; >> + >> data.blksz = size; >> data.blocks = 1; >> data.flags = MMC_DATA_READ; >> -- >> 1.9.1 >> > Sorry for delay in testing this suggested patch, I would say this > certainly helps, but still I need to change sample phase to make it > work with generic tuning function. > So with your's adding STOP_TRANSMISSION command and below change, > HS200 works well on exynos5800 > > diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts > b/arch/arm/boot/dts/exynos5800-peach-pi.dts > index e8fdda8..e0f0337 100644 > --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > @@ -555,7 +555,7 @@ > card-detect-delay = <200>; > clock-frequency = <400000000>; > samsung,dw-mshc-ciu-div = <3>; > - samsung,dw-mshc-sdr-timing = <0 4>; > + samsung,dw-mshc-sdr-timing = <2 4>; > > This basically change the clock-sample phase with which the tuning > process starts. > > I didn't find anything is exynos documentations which suggest > STOP_TRANSMISSION is needed, may be Seungwon might be know as he wrote > this. > > Are you ok to add STOP_TRANSMISSION in generic tuning code (probably > with a quirk, so that other hosts are still happy)? No, I don't want that. If special treatment are needed for dw_mmc to handle a tuning request, dw_mmc should be able to take care by itself. How about below patch, do you think that could work? >From c2e5783beaa322178f2336b4bff4bdf13da76f56 Mon Sep 17 00:00:00 2001 From: Ulf Hansson Date: Mon, 22 Dec 2014 15:24:14 +0100 Subject: [PATCH] mmc: dw_mmc: Generate stop commands for failed tuning requests It's seems like dw_mmc internal logic expects failed data transfers to be ended using a stop command. Let the tuning requests also fall into this category, since there are data transfer involved. Signed-off-by: Ulf Hansson --- drivers/mmc/host/dw_mmc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) stop->flags = MMC_RSP_R1B | MMC_CMD_AC; diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index a1b80e5..976382db 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -314,7 +314,9 @@ static u32 dw_mci_prep_stop_abort(struct dw_mci *host, struct mmc_command *cmd) if (cmdr == MMC_READ_SINGLE_BLOCK || cmdr == MMC_READ_MULTIPLE_BLOCK || cmdr == MMC_WRITE_BLOCK || - cmdr == MMC_WRITE_MULTIPLE_BLOCK) { + cmdr == MMC_WRITE_MULTIPLE_BLOCK || + cmdr == MMC_SEND_TUNING_BLOCK || + cmdr == MMC_SEND_TUNING_BLOCK_HS200) { stop->opcode = MMC_STOP_TRANSMISSION; stop->arg = 0;