| Message ID | b79920fa8bff8f7cf2f407863846446344d2eab7.1748515612.git.zhoubinbin@loongson.cn |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: Cleanup sdhci_pltfm_free()/sdhci_free_host() usage | expand |
Hi Binbin,
kernel test robot noticed the following build warnings:
[auto build test WARNING on d2c6acff6386f43ed307822454b970c831c48f1b]
url: https://github.com/intel-lab-lkp/linux/commits/Binbin-Zhou/mmc-sdhci-Use-devm_mmc_alloc_host-helper/20250529-212928
base: d2c6acff6386f43ed307822454b970c831c48f1b
patch link: https://lore.kernel.org/r/b79920fa8bff8f7cf2f407863846446344d2eab7.1748515612.git.zhoubinbin%40loongson.cn
patch subject: [PATCH v2 32/35] mmc: sdhci-xenon: Drop the use of sdhci_pltfm_free()
config: arm-randconfig-004-20250530 (https://download.01.org/0day-ci/archive/20250530/202505300815.tjQRQD6z-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250530/202505300815.tjQRQD6z-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505300815.tjQRQD6z-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/mmc/host/sdhci-xenon.c:536:59: warning: variable 'err' is uninitialized when used here [-Wuninitialized]
536 | dev_err(&pdev->dev, "Failed to setup input clk: %d\n", err);
| ^~~
include/linux/dev_printk.h:154:65: note: expanded from macro 'dev_err'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/mmc/host/sdhci-xenon.c:515:9: note: initialize the variable 'err' to silence this warning
515 | int err;
| ^
| = 0
1 warning generated.
vim +/err +536 drivers/mmc/host/sdhci-xenon.c
3a3748dba881ed Hu Ziji 2017-03-30 508
3a3748dba881ed Hu Ziji 2017-03-30 509 static int xenon_probe(struct platform_device *pdev)
3a3748dba881ed Hu Ziji 2017-03-30 510 {
3a3748dba881ed Hu Ziji 2017-03-30 511 struct sdhci_pltfm_host *pltfm_host;
1542488031deed Marcin Wojtas 2020-12-04 512 struct device *dev = &pdev->dev;
3a3748dba881ed Hu Ziji 2017-03-30 513 struct sdhci_host *host;
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 514 struct xenon_priv *priv;
3a3748dba881ed Hu Ziji 2017-03-30 515 int err;
3a3748dba881ed Hu Ziji 2017-03-30 516
3a3748dba881ed Hu Ziji 2017-03-30 517 host = sdhci_pltfm_init(pdev, &sdhci_xenon_pdata,
3a3748dba881ed Hu Ziji 2017-03-30 518 sizeof(struct xenon_priv));
3a3748dba881ed Hu Ziji 2017-03-30 519 if (IS_ERR(host))
3a3748dba881ed Hu Ziji 2017-03-30 520 return PTR_ERR(host);
3a3748dba881ed Hu Ziji 2017-03-30 521
3a3748dba881ed Hu Ziji 2017-03-30 522 pltfm_host = sdhci_priv(host);
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 523 priv = sdhci_pltfm_priv(pltfm_host);
3a3748dba881ed Hu Ziji 2017-03-30 524
f75fda3730728e Marcin Wojtas 2020-12-04 525 priv->hw_version = (unsigned long)device_get_match_data(&pdev->dev);
f75fda3730728e Marcin Wojtas 2020-12-04 526
3a3748dba881ed Hu Ziji 2017-03-30 527 /*
3a3748dba881ed Hu Ziji 2017-03-30 528 * Link Xenon specific mmc_host_ops function,
3a3748dba881ed Hu Ziji 2017-03-30 529 * to replace standard ones in sdhci_ops.
3a3748dba881ed Hu Ziji 2017-03-30 530 */
3a3748dba881ed Hu Ziji 2017-03-30 531 xenon_replace_mmc_host_ops(host);
3a3748dba881ed Hu Ziji 2017-03-30 532
1542488031deed Marcin Wojtas 2020-12-04 533 if (dev->of_node) {
3a3748dba881ed Hu Ziji 2017-03-30 534 pltfm_host->clk = devm_clk_get(&pdev->dev, "core");
3a3748dba881ed Hu Ziji 2017-03-30 535 if (IS_ERR(pltfm_host->clk)) {
3a3748dba881ed Hu Ziji 2017-03-30 @536 dev_err(&pdev->dev, "Failed to setup input clk: %d\n", err);
6773eb1cf68bcb Binbin Zhou 2025-05-29 537 return PTR_ERR(pltfm_host->clk);
3a3748dba881ed Hu Ziji 2017-03-30 538 }
3a3748dba881ed Hu Ziji 2017-03-30 539 err = clk_prepare_enable(pltfm_host->clk);
3a3748dba881ed Hu Ziji 2017-03-30 540 if (err)
6773eb1cf68bcb Binbin Zhou 2025-05-29 541 return err;
3a3748dba881ed Hu Ziji 2017-03-30 542
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 543 priv->axi_clk = devm_clk_get(&pdev->dev, "axi");
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 544 if (IS_ERR(priv->axi_clk)) {
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 545 err = PTR_ERR(priv->axi_clk);
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 546 if (err == -EPROBE_DEFER)
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 547 goto err_clk;
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 548 } else {
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 549 err = clk_prepare_enable(priv->axi_clk);
3a3748dba881ed Hu Ziji 2017-03-30 550 if (err)
3a3748dba881ed Hu Ziji 2017-03-30 551 goto err_clk;
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 552 }
1542488031deed Marcin Wojtas 2020-12-04 553 }
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 554
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 555 err = mmc_of_parse(host->mmc);
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 556 if (err)
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 557 goto err_clk_axi;
3a3748dba881ed Hu Ziji 2017-03-30 558
f29bf660bf4137 Marcin Wojtas 2020-12-04 559 sdhci_get_property(pdev);
3a3748dba881ed Hu Ziji 2017-03-30 560
3a3748dba881ed Hu Ziji 2017-03-30 561 xenon_set_acg(host, false);
3a3748dba881ed Hu Ziji 2017-03-30 562
f29bf660bf4137 Marcin Wojtas 2020-12-04 563 /* Xenon specific parameters parse */
f29bf660bf4137 Marcin Wojtas 2020-12-04 564 err = xenon_probe_params(pdev);
3a3748dba881ed Hu Ziji 2017-03-30 565 if (err)
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 566 goto err_clk_axi;
3a3748dba881ed Hu Ziji 2017-03-30 567
3a3748dba881ed Hu Ziji 2017-03-30 568 err = xenon_sdhc_prepare(host);
3a3748dba881ed Hu Ziji 2017-03-30 569 if (err)
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 570 goto err_clk_axi;
3a3748dba881ed Hu Ziji 2017-03-30 571
a027b2c5fed788 Zhoujie Wu 2017-08-29 572 pm_runtime_get_noresume(&pdev->dev);
a027b2c5fed788 Zhoujie Wu 2017-08-29 573 pm_runtime_set_active(&pdev->dev);
a027b2c5fed788 Zhoujie Wu 2017-08-29 574 pm_runtime_set_autosuspend_delay(&pdev->dev, 50);
a027b2c5fed788 Zhoujie Wu 2017-08-29 575 pm_runtime_use_autosuspend(&pdev->dev);
a027b2c5fed788 Zhoujie Wu 2017-08-29 576 pm_runtime_enable(&pdev->dev);
a027b2c5fed788 Zhoujie Wu 2017-08-29 577 pm_suspend_ignore_children(&pdev->dev, 1);
a027b2c5fed788 Zhoujie Wu 2017-08-29 578
3a3748dba881ed Hu Ziji 2017-03-30 579 err = sdhci_add_host(host);
3a3748dba881ed Hu Ziji 2017-03-30 580 if (err)
3a3748dba881ed Hu Ziji 2017-03-30 581 goto remove_sdhc;
3a3748dba881ed Hu Ziji 2017-03-30 582
a027b2c5fed788 Zhoujie Wu 2017-08-29 583 pm_runtime_put_autosuspend(&pdev->dev);
5d40213347480e Elad Nachman 2024-01-04 584 /*
5d40213347480e Elad Nachman 2024-01-04 585 * If we previously detected AC5 with over 2GB of memory,
5d40213347480e Elad Nachman 2024-01-04 586 * then we disable ADMA and 64-bit DMA.
5d40213347480e Elad Nachman 2024-01-04 587 * This means generic SDHCI driver has set the DMA mask to
5d40213347480e Elad Nachman 2024-01-04 588 * 32-bit. Since DDR starts at 0x2_0000_0000, we must use
5d40213347480e Elad Nachman 2024-01-04 589 * 34-bit DMA mask to access this DDR memory:
5d40213347480e Elad Nachman 2024-01-04 590 */
5d40213347480e Elad Nachman 2024-01-04 591 if (priv->hw_version == XENON_AC5 &&
5d40213347480e Elad Nachman 2024-01-04 592 host->quirks2 & SDHCI_QUIRK2_BROKEN_64_BIT_DMA)
5d40213347480e Elad Nachman 2024-01-04 593 dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34));
a027b2c5fed788 Zhoujie Wu 2017-08-29 594
3a3748dba881ed Hu Ziji 2017-03-30 595 return 0;
3a3748dba881ed Hu Ziji 2017-03-30 596
3a3748dba881ed Hu Ziji 2017-03-30 597 remove_sdhc:
a027b2c5fed788 Zhoujie Wu 2017-08-29 598 pm_runtime_disable(&pdev->dev);
a027b2c5fed788 Zhoujie Wu 2017-08-29 599 pm_runtime_put_noidle(&pdev->dev);
3a3748dba881ed Hu Ziji 2017-03-30 600 xenon_sdhc_unprepare(host);
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 601 err_clk_axi:
bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 602 clk_disable_unprepare(priv->axi_clk);
3a3748dba881ed Hu Ziji 2017-03-30 603 err_clk:
3a3748dba881ed Hu Ziji 2017-03-30 604 clk_disable_unprepare(pltfm_host->clk);
3a3748dba881ed Hu Ziji 2017-03-30 605 return err;
3a3748dba881ed Hu Ziji 2017-03-30 606 }
3a3748dba881ed Hu Ziji 2017-03-30 607
diff --git a/drivers/mmc/host/sdhci-xenon.c b/drivers/mmc/host/sdhci-xenon.c index 098f0ea45cbe..20efb0225d3a 100644 --- a/drivers/mmc/host/sdhci-xenon.c +++ b/drivers/mmc/host/sdhci-xenon.c @@ -533,13 +533,12 @@ static int xenon_probe(struct platform_device *pdev) if (dev->of_node) { pltfm_host->clk = devm_clk_get(&pdev->dev, "core"); if (IS_ERR(pltfm_host->clk)) { - err = PTR_ERR(pltfm_host->clk); dev_err(&pdev->dev, "Failed to setup input clk: %d\n", err); - goto free_pltfm; + return PTR_ERR(pltfm_host->clk); } err = clk_prepare_enable(pltfm_host->clk); if (err) - goto free_pltfm; + return err; priv->axi_clk = devm_clk_get(&pdev->dev, "axi"); if (IS_ERR(priv->axi_clk)) { @@ -603,8 +602,6 @@ static int xenon_probe(struct platform_device *pdev) clk_disable_unprepare(priv->axi_clk); err_clk: clk_disable_unprepare(pltfm_host->clk); -free_pltfm: - sdhci_pltfm_free(pdev); return err; } @@ -623,8 +620,6 @@ static void xenon_remove(struct platform_device *pdev) xenon_sdhc_unprepare(host); clk_disable_unprepare(priv->axi_clk); clk_disable_unprepare(pltfm_host->clk); - - sdhci_pltfm_free(pdev); } #ifdef CONFIG_PM_SLEEP
Since the devm_mmc_alloc_host() helper is already in use, sdhci_pltfm_free() is no longer needed. Cc: Hu Ziji <huziji@marvell.com> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> --- drivers/mmc/host/sdhci-xenon.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)