From patchwork Thu Jan 24 04:19:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 156447 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp1498732jaa; Wed, 23 Jan 2019 20:20:28 -0800 (PST) X-Google-Smtp-Source: ALg8bN4SEQ0A/a/Xf05s91lKrEjx3sNuYsUT4Fwmf5dn8GN4DRXRi3FVJMlM/xqTAEgLKJhkEekK X-Received: by 2002:a62:8949:: with SMTP id v70mr4790317pfd.85.1548303628522; Wed, 23 Jan 2019 20:20:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548303628; cv=none; d=google.com; s=arc-20160816; b=RMYK2Q/0Nm28M8Vs943nRyie2LFkzOXNPIDQcPuBZlKLwG86tC0jp0MtbxF/ukH1mm ZHxfjYRlx40oWaPh6cHztNqJrL+Sr4/2HDSqOsSs+LRyvSpqQW3XwZhT4tEw9baZkEnc tr56Xb54Eh2pOoO91oQ9w55WgRmeOyOOAaSD6vyP588q5A7zd2YeHJFxPzEuiyhwGpZe o4uBPtIjiJyYkYwOWXfIDj4M5zTORrUYUB7uvyeAGdVc0gikEa13PH4X0oTR7KikGQeL 095ZAYUJ7jTKT+r2BCilXlee2Dy97DyU2WUtQ5L2zLPz/uut7ZOuSqkXFGjj3UPG8R08 QxTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:dkim-filter:dkim-signature; bh=92Gj8Gvhq010pNlQbRih/cpqji5N+2ABlhAtJN4bj4g=; b=YehJTI8/fBv2ySGn+rugzZk84COzNAj9GG/qpprbzvDpHg3GLO3qYQwpC74dEDW49O 5f7JCRjnsLswMBvbOKjhA0Bfa9lbK2VGbaRe+YbMBG5mQO4HdOgz11n5zfnmvgESIkRS K6DFR8EF3Fj0PsDNyXw8pg4Vj/I2/Ci6d2o/QX+2ehFjVWTz/DaVeltvhSqjIGhrzoUb bEIgP2PAjYdXKGw0gvjYr93EnkzyZXyb1anS4cVyLqHNDpvm3foOUXcLXIEbBcDUF4k+ TNXO6E8aSpcx7FqKneGJFofxoeMh+xeYX/uphPeBg5QJjIQeMIr5PKuGjpPPdiyMmUsq zeEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=ieMm0maF; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=IOu+DuXZ; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id j28si3800713pgm.160.2019.01.23.20.20.28 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Jan 2019 20:20:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=ieMm0maF; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=IOu+DuXZ; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=92Gj8Gvhq010pNlQbRih/cpqji5N+2ABlhAtJN4bj4g=; b=ieMm0maFRnoGNibWhQaKCjt0PT sIh8XIfBYsvD7vltMpozLV2PtFy+eirZulNqXldKcT/9xFizUsin6GI83kAcD/6I2xMjDXqs8EOmh 6+ThwNWjpDB0xkUOyHw7prsuEkphFReGUaq5NPRQBS/NSJU9K6/K7+yttbI9IEukyvknH3hxTkCv4 cllMllvw6DbshRnIQ/fXCxBCJ938MnLJx48RFXcueaucuwIs0U9fpg3qbeuzZFHqm7hlT2SOjLR0K 03xqdnYleYQDuK/tIl5vNY0tc7WabI9aBQK8s2WQFddBm8YsOWRtTHo50dWKW7skbwsy+dZg4wR44 RVrAJQEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gmWV0-0001iM-FA; Thu, 24 Jan 2019 04:20:18 +0000 Received: from conuserg-12.nifty.com ([210.131.2.79]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gmWUj-0000Ji-6d for linux-mtd@lists.infradead.org; Thu, 24 Jan 2019 04:20:03 +0000 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id x0O4JI05030691; Thu, 24 Jan 2019 13:19:19 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com x0O4JI05030691 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1548303560; bh=w3624K2641LQxTT4qz9JU+SrCJSBx2DTYxNESgK5qvo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IOu+DuXZ2M2YrlQcxPyvRQYhAn8T4J4dWoP0+4yAu8y8ttp2KoUKXj5lfJp74IWFW 3yEcP8YQKDdpDyznxIITlXi3uZiHzt/Icz5Iet5AkvXCByywdh1ycKPUFL2P+rKbMV UfJy8vPon/fKFKJKMHmHFvuWHV9JrmZISzkFEEXIVjP9gTl8bicPNDtSCkJzVPcJH3 MZbbgkVGqr/emiRZqxM2YhkZLCtvBtWWRjG/ITRFKJmmZ4t4c23mMVZ6HeydSTjUYW /f+NQHW/2IyoPsZquqHrLVjCbhx0F+tMg6CWf5Svga1be/S6Vqw65fC7jqherSa8RE cnAOFjvcfUyWQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Boris Brezillon , Miquel Raynal Subject: [PATCH 1/2] mtd: rawnand: denali: remove unneeded denali_reset_irq() call Date: Thu, 24 Jan 2019 13:19:06 +0900 Message-Id: <1548303547-21156-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1548303547-21156-1-git-send-email-yamada.masahiro@socionext.com> References: <1548303547-21156-1-git-send-email-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190123_202001_708037_FB1782F4 X-CRM114-Status: UNSURE ( 9.32 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 1.0 (+) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [210.131.2.79 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Richard Weinberger , Boris Brezillon , linux-kernel@vger.kernel.org, Masahiro Yamada , Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org This code was added by commit 26d266e10e5e ("mtd: nand: denali: fix raw and oob accessors for syndrome page layout"), but I do not see sensible reason. The IRQ flags are correctly reset by denali_cmd_ctrl(), so this code is unneeded. Signed-off-by: Masahiro Yamada --- drivers/mtd/nand/raw/denali.c | 3 --- 1 file changed, 3 deletions(-) -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c index 21320b1..6775644 100644 --- a/drivers/mtd/nand/raw/denali.c +++ b/drivers/mtd/nand/raw/denali.c @@ -751,9 +751,6 @@ static int denali_read_oob(struct nand_chip *chip, int page) static int denali_write_oob(struct nand_chip *chip, int page) { struct mtd_info *mtd = nand_to_mtd(chip); - struct denali_nand_info *denali = mtd_to_denali(mtd); - - denali_reset_irq(denali); denali_oob_xfer(mtd, chip, page, 1);