From patchwork Mon Jun 3 16:50:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 165677 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp4714942ili; Mon, 3 Jun 2019 09:51:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqwuM1O48uQP3l8j64Gbm9xMC21YdxcJOlCscNm2hpp1QXdmFs69n62DXHjfaAh8bFWAJW0E X-Received: by 2002:a17:90a:a608:: with SMTP id c8mr30171353pjq.37.1559580669664; Mon, 03 Jun 2019 09:51:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559580669; cv=none; d=google.com; s=arc-20160816; b=OitfJ3Zp7GEejKpj6JJUzOBgoF53iDS44bn/6XAdu4rkXHwpft15hrRI1TBeEn1Xf1 94jt2nK5KfDF1A/ygOwAZuFMcO9uWi9ElVV4v0VSB+8f1R1vEq97atcR4cLOYW/6MyYS /zTjiWrDNxCvYcXhMEQIzEew00V3VCg+5Ae5RbwOOEh1Z8njl/bZzD94x/aVJ3MFq1r/ 0RUwZ5kW/gyG700pcSLL1GuxNBrsuG5MfKN7bN5DZvLkQlL3q5VrMsXhiy9vVFKkV68/ MJvgv4FNqbE0ZnID6pyoUEMmr3CEajzaxAsFy9c5iL+0P1SvY7LWsdp/SxFFDIEnq5vT wvUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:message-id:date:subject:to:from:dkim-signature :dkim-filter:dkim-signature; bh=ZwFVY8HdYmyPLZuKukk2dQ0h0bllractlCgHtSkKt+8=; b=Y1k67QaLxVvdgMeydQzeCWBnACjTxr4qVMl/RIwDfGSg4/OumNcPCyURCsEI4GBE6Q upRDO+nX0ouacjd5Aa/0ptqLq7yrewoRTrlE19J+BA4w1FzgegV6f6qRZ7E9fVvqL/EY i3RcrjUASky3gXxEvVl1qmG3DCg7irMlI/fIb10DYIQvRDf+OeIVkx3ElMCzkcmsyXf8 2JlCSIbLPxGv4/288g/bQlbJEVSxUgRC6dAMJiuvsisSle30NW6trMrkR1SXZXXZQRmZ U6R4nFdwc/ThNvw/lv+VRxKyY/2V5E0od09uAU6ct2h/vUCANqbyeMb+l5N9A1H+bsZo 3Upg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=TnfB4z18; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b="gQFdb6/V"; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id cg12si20989945plb.19.2019.06.03.09.51.09 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Jun 2019 09:51:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=TnfB4z18; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b="gQFdb6/V"; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=ZwFVY8HdYmyPLZuKukk2dQ0h0bllractlCgHtSkKt+8=; b=Tnf B4z181jW48QC2yc9fRzH0XIMkClRswtF+xo8DpIl5D5qEG981BrUztVMZGsvkhwBjBw/d9IrSkkIE 4SL2QMl8KOd+DzGHcfWBovzinTZpja6U4M3dNa7P9ooLlsURV4JW9wGZRFJZev7YCICVrfVHYZ1Gc PV93GexFYqXQOyqj6JUQ6ONbYjlHKgus2ISzPQB8hZJRIK2XZHJtHLQ6mDgUc8UP+rGm4TYOwY+/P Jb7Aq0EnH/2TynZ6icbSPjJrK8RxXvcfln6bW7Nha2muPRaEY3hbjA5tCGmyVl1arWrQlc9Euaj84 QRlEofZ8LejzXP2fa0w2yRhgboacFjw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXqAe-0005en-KR; Mon, 03 Jun 2019 16:50:52 +0000 Received: from conuserg-10.nifty.com ([210.131.2.77]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXqAb-0005eO-QD for linux-mtd@lists.infradead.org; Mon, 03 Jun 2019 16:50:51 +0000 Received: from grover.flets-west.jp (softbank126125154139.bbtec.net [126.125.154.139]) (authenticated) by conuserg-10.nifty.com with ESMTP id x53GoTBY008328; Tue, 4 Jun 2019 01:50:29 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com x53GoTBY008328 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1559580630; bh=Uf6Bqw9USDMuxj3PzqazDovjCc2/XohbsDH/Cgwz43Y=; h=From:To:Cc:Subject:Date:From; b=gQFdb6/Vt3HdMh6R5JJW4MWNJEjRvuP4wPeGxL1iEJMfhT0bHqVTadtRZgzNiVrwv rZIWW1rhoDVsNqdEqizQga9AgRGhc4o7HTDt2xEYydpm9F0gyBQThB97tHLZxOi2ul aPDY+l2djP0mhEeLmeuTvraYWEIOPP3Gh77WOsZkJ5UXGDn6YsJTDrvweaSlpDYDdI 3ciE+96nXaQ0OhLUJm3SEbLyZFsQ3xvSzXb9/36pxwWZEGiMSm1B65ReZLFy4cpQY9 ZXeUo+PbTBUtIyA6Kx5Frb+GQA5I4w05ToFYh+OuN1RvMg0TDIUirEKcBEN14lnVzR A2QSe/jaiimWg== X-Nifty-SrcIP: [126.125.154.139] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, David Woodhouse , Richard Weinberger Subject: [PATCH] jffs2: do not use C++ style comments in uapi header Date: Tue, 4 Jun 2019 01:50:27 +0900 Message-Id: <20190603165027.11831-1-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190603_095050_163790_4EAF7108 X-CRM114-Status: UNSURE ( 8.61 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 1.0 (+) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [210.131.2.77 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Marek Vasut , linux-kernel@vger.kernel.org, Masahiro Yamada , Miquel Raynal , Brian Norris MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org Linux kernel tolerates C++ style comments these days. Actually, the SPDX License Identifier for .c files uses C++ comment style. On the other hand, uapi headers are strict, where the C++ comment style is banned. Looks like these lines are temporarily commented out, so I did not use the block comment style. Having said that, they have been commented out since the pre-git era. (so, at least 14 years). 'Maybe later' may not happen. Alternative fix might be to delete these lines entirely. Signed-off-by: Masahiro Yamada --- include/uapi/linux/jffs2.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.17.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/include/uapi/linux/jffs2.h b/include/uapi/linux/jffs2.h index a18b719f49d4..5dee6d930d5b 100644 --- a/include/uapi/linux/jffs2.h +++ b/include/uapi/linux/jffs2.h @@ -77,10 +77,10 @@ #define JFFS2_ACL_VERSION 0x0001 -// Maybe later... -//#define JFFS2_NODETYPE_CHECKPOINT (JFFS2_FEATURE_RWCOMPAT_DELETE | JFFS2_NODE_ACCURATE | 3) -//#define JFFS2_NODETYPE_OPTIONS (JFFS2_FEATURE_RWCOMPAT_COPY | JFFS2_NODE_ACCURATE | 4) - +/* Maybe later... +#define JFFS2_NODETYPE_CHECKPOINT (JFFS2_FEATURE_RWCOMPAT_DELETE | JFFS2_NODE_ACCURATE | 3) +#define JFFS2_NODETYPE_OPTIONS (JFFS2_FEATURE_RWCOMPAT_COPY | JFFS2_NODE_ACCURATE | 4) +*/ #define JFFS2_INO_FLAG_PREREAD 1 /* Do read_inode() for this one at mount time, don't wait for it to