From patchwork Fri Nov 6 21:36:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320836 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1651676ilc; Fri, 6 Nov 2020 13:40:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJzuUYPnU5cUDj5m/d1jxSIxg3knK2UN9QQZq6gLoT2gCM8XWT0opvkaZG/5N7iez5WPBLSt X-Received: by 2002:adf:84a5:: with SMTP id 34mr4660162wrg.8.1604698824208; Fri, 06 Nov 2020 13:40:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604698824; cv=none; d=google.com; s=arc-20160816; b=Muv91b+vihwS0pRfbOQNT1Rk5KGGjcIzlOtIw8JrurP+O0P2nv3YM2mCsWJMXO2xwl AjlznzYjZrYLWXUmQruiHWBaPUVITVsoH884wUGUKAOphrFOcWchGAczCPIQBHVvMEcq cBM1tV+8MDZSbj6hW7KdzSYg7+y+F1G0iXRR3DjUzf2BsbZdOVJ5dj2wpZfbHKHM/9bz jBvLoU9CISSBVrHhZUQoGCZzU2mh/GV31P9yKyf73sVGO5dIJDc7gwHVLl19wNhgHtzz BoXgH9oEZmcfJ0F9kyqiMyWRByFucWMp2XuLGEDoLm/9mcfLrmvZICyxSg5N8Nj8ISVO 6OEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:dkim-signature; bh=/yoUgR3Mj1LU7MFNvezDlP9oaQHyS8yiRUPU5faGu54=; b=uTuK2dGkES3H4IkkmqQWiXlnPPJL08YYXhSvD4ePXPyAxw6CLgdi+NAlTso4knpEXA vigb6gjuy2NUFHrkXNPvqyao74ZuZgQfNWLwCHao755O4FBh7d+9B6rtzoYj0YoXJiOF UOVuF5T3zA4A8826l5PLzkRYYfUJkMdhbigSxRprRsHuDg1NZbb9WOBvzqtizWtfNmdo y3vg/3ycZ/JwkH1VhJwUYLdfYRf0HLHsTC6gVP+0ukLUVtGm+i2sofgaJ+Lk9dcxMuLM feC/o4tSlK9LYArb/hAbwNVi4wpXC+JMMOqFHDe3+zOdK/P9CP695gR1ZYFLVD+aDUYY maHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=IGY7IuJj; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=j4KGRdPE; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id n7si2262201wmf.110.2020.11.06.13.40.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:40:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=IGY7IuJj; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=j4KGRdPE; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/yoUgR3Mj1LU7MFNvezDlP9oaQHyS8yiRUPU5faGu54=; b=IGY7IuJjtNn49VB1w4w/l0cPk KOeyUhxSE2qLSV2KuH5vfSoXdLcnfOsmEE/MGIhN68uk0d/sytI9mdoT+QQSSoaDJ9nnQBFQ7z4W8 XohoQELY2fJSXGIQFIQWyc4wj0wDYWAUJ/f9pJ/VQkbSdCAOaGjk9aSasUmRxLznnltkJ8WqYwqY3 SOEhSJoja4Um6+sNfHNNbQM+SMHXCt0yFtFQ9B+djCwneBGa/2VBNsfwzNJECo4McjaKeg0aYFoDq 1ENPoi5ueFABQGccNdgLjYgBaSVQVdVx/U0YeFWJpPfhc1s67gOuFirwXc/K7NHbyM0jK00V5YulY CUaP8NAkw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb9SI-0003qo-Ju; Fri, 06 Nov 2020 21:39:34 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb9QB-0002gA-VQ for linux-mtd@lists.infradead.org; Fri, 06 Nov 2020 21:37:28 +0000 Received: by mail-wm1-x343.google.com with SMTP id w24so138678wmi.0 for ; Fri, 06 Nov 2020 13:37:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jc+oP6vugsB/NFox5ee2E+FED0ZhjBIzS6GFVD2ExkM=; b=j4KGRdPEohicZL6AoYC4Hdrh+N2e2xqMn+HVwrhX4+LirOMr4k8k4c3gBDb4TBe/Ej CCNbwys4IwnHNxIlOHzM44fECTrBZyrnvu6wGNldLEOX5C0IV51hvmGa3DZ64QTdSztT JMzNSCxsfs0jj9G5p/P9vly6Pl7fBkTElXddglJPv+rP98dwOOJ+IKCbT6CLyPFC5vEd +DidaTOsKuw1WVQmAHdmZUkK9FguedLqNF8z6FX/NFi4lSNfjfxlyuEJXGUWmR59gTh7 krSCjn5tLcgzi7iQT8YV/v3z5ktHaKNGMpbPN0tWJSjZZwC9CHdE650upzC28RW1L9jJ y1WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jc+oP6vugsB/NFox5ee2E+FED0ZhjBIzS6GFVD2ExkM=; b=J3iT2unL9GTXkdAH5qEhUxcQ+KTTVBjP4a/DbDwGRL+Fs6zx9CmqXtaE+iRf5KygCN vQTPkYX14m9ZodytpBFArfohDBTHmqhcwVkngL1i2/2GEMsvt+yzfNC7q17qJ3kYT92Z n2/for/1i/gd9He0pT4/LD5T10daCs7f72iNG60hx72Rk0GwwMusBCifjRQlK34W+ED2 iHK+ToLxV5CzV/9vzMzMq1tV0FqDJeiXQN2Wowhg+FjwZP9PsRmuCFtrd8er/n0oAkum MhQvYUqF2hsB46hjuWBS5mc1MiKv3OkAywEyfGaX2IuXkOCj0iePCiIyLNyW/X/Synvs P2fA== X-Gm-Message-State: AOAM5331wxad1l6ZSo98FFp6eC5UXP3TV5iau+DQbjg/gxPt/k9XURYG VG5zAJeC6IeM34sjWxoaPbkJ4CcxtLfvpyW7 X-Received: by 2002:a7b:cf31:: with SMTP id m17mr1571554wmg.62.1604698642984; Fri, 06 Nov 2020 13:37:22 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id d16sm3984942wrw.17.2020.11.06.13.37.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:37:22 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH v2 18/23] mtd: nand: raw: omap_elm: Finish half populated function header, demote empty ones Date: Fri, 6 Nov 2020 21:36:50 +0000 Message-Id: <20201106213655.1838861-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106213655.1838861-1-lee.jones@linaro.org> References: <20201106213655.1838861-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201106_163724_098838_80517995 X-CRM114-Status: GOOD ( 14.47 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Richard Weinberger , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Miquel Raynal Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/mtd/nand/raw/omap_elm.c:102: warning: Function parameter or member 'ecc_steps' not described in 'elm_config' drivers/mtd/nand/raw/omap_elm.c:102: warning: Function parameter or member 'ecc_step_size' not described in 'elm_config' drivers/mtd/nand/raw/omap_elm.c:102: warning: Function parameter or member 'ecc_syndrome_size' not described in 'elm_config' drivers/mtd/nand/raw/omap_elm.c:440: warning: Function parameter or member 'info' not described in 'elm_context_save' drivers/mtd/nand/raw/omap_elm.c:488: warning: Function parameter or member 'info' not described in 'elm_context_restore' Cc: Miquel Raynal Cc: Richard Weinberger Cc: Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org Signed-off-by: Lee Jones --- drivers/mtd/nand/raw/omap_elm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/raw/omap_elm.c b/drivers/mtd/nand/raw/omap_elm.c index 4b799521a427a..550695a4c1ab0 100644 --- a/drivers/mtd/nand/raw/omap_elm.c +++ b/drivers/mtd/nand/raw/omap_elm.c @@ -96,6 +96,9 @@ static u32 elm_read_reg(struct elm_info *info, int offset) * elm_config - Configure ELM module * @dev: ELM device * @bch_type: Type of BCH ecc + * @ecc_steps: ECC steps to assign to config + * @ecc_step_size: ECC step size to assign to config + * @ecc_syndrome_size: ECC syndrome size to assign to config */ int elm_config(struct device *dev, enum bch_ecc bch_type, int ecc_steps, int ecc_step_size, int ecc_syndrome_size) @@ -432,7 +435,7 @@ static int elm_remove(struct platform_device *pdev) } #ifdef CONFIG_PM_SLEEP -/** +/* * elm_context_save * saves ELM configurations to preserve them across Hardware powered-down */ @@ -480,7 +483,7 @@ static int elm_context_save(struct elm_info *info) return 0; } -/** +/* * elm_context_restore * writes configurations saved duing power-down back into ELM registers */