From patchwork Tue Nov 16 20:07:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 518534 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DC19C433EF for ; Tue, 16 Nov 2021 20:07:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E762F6323A for ; Tue, 16 Nov 2021 20:07:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231980AbhKPUKs (ORCPT ); Tue, 16 Nov 2021 15:10:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240206AbhKPUKr (ORCPT ); Tue, 16 Nov 2021 15:10:47 -0500 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D20AEC061766 for ; Tue, 16 Nov 2021 12:07:49 -0800 (PST) Received: by mail-pf1-x435.google.com with SMTP id m14so409834pfc.9 for ; Tue, 16 Nov 2021 12:07:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+isCY2p3VuEyXYkV2zHDeC+Z7SP2kPvEwCoiEUnm39g=; b=cJceinMj+ViUo6DjqabNpdAFf3iDUkJ/OZblfKL4Uabe0slXXuwzUzwtSsjjW7J5e5 skz29SPBBdrgijtdiyQwR6emSkwvObtfojmmv4RbPd9zr1yWygGZ+5GXft+NMOjMWYrQ KvSjFD4Bqi6REN/q7g36zgyFxGh9nUyP2X0C4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+isCY2p3VuEyXYkV2zHDeC+Z7SP2kPvEwCoiEUnm39g=; b=ToR85ZYOMgPyNKMrHq0LcWD8TYVy/iDVeoZNdqrRrGwDXQtrMb/oQ4fTMqqhXrD2j2 k2YozC3Oqv3PHutPSfNGtMGV1ptB7gHMO8EtBeDfayWQscMcyX/Z0VX34zYudXibMc+d MecMwmTJmzv2P6PCC0Nei4oh/NC5cKPcbLWnQH7ObA7wXJB+ob4V6hguLriJyu2WMPAa qgnwwN0zuqP+NCLlDQOcn/aPzgBK6vYg6Sn/dhiTlBztjaRuAASWZSdJwREdPdNaZu6E neiIpqwA+Yi+NNlPpLkFEgM7LhPiowP4K7HaKqvn8+TQlxDaMiwrEjDlgGLFLgHlt7Oh PKtQ== X-Gm-Message-State: AOAM5336uGAuLAmUCo43X+chcPrspdYlA105gAlFYdwEZ+BYxpmYXRge MMaZLCD29imzvTpfXP7RXmpFDw== X-Google-Smtp-Source: ABdhPJxKJ3ReeW4EVB38Re++mXrjY6fl2lSzlXyJM76TT70kGEgGnT2OiMxrQ+EG0WJSv/WE4b8wKQ== X-Received: by 2002:a63:5d63:: with SMTP id o35mr1247291pgm.134.1637093269319; Tue, 16 Nov 2021 12:07:49 -0800 (PST) Received: from localhost ([2620:15c:202:201:54aa:73ab:b480:41e2]) by smtp.gmail.com with UTF8SMTPSA id b10sm20947738pfl.200.2021.11.16.12.07.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Nov 2021 12:07:48 -0800 (PST) From: Matthias Kaehlcke To: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Stephen Boyd , Peter Chen , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, Douglas Anderson , Roger Quadros , Michal Simek , Ravi Chandra Sadineni , Bastien Nocera , Matthias Kaehlcke , Al Viro , Alexandre Torgue , Andrew Lunn , Andrey Konovalov , Andrey Zhizhikin , Andy Gross , Arnd Bergmann , Aswath Govindraju , Biju Das , Bjorn Andersson , Catalin Marinas , Dmitry Osipenko , Enric Balletbo i Serra , Florian Fainelli , Geert Uytterhoeven , Gregory Clement , Grygorii Strashko , =?utf-8?q?Guido_G=C3=BCnther?= , Jagan Teki , Joel Stanley , Kishon Vijay Abraham I , Krzysztof Kozlowski , Li Jun , Linus Walleij , Lukas Bulwahn , Manivannan Sadhasivam , Marek Szyprowski , Mark Brown , Nishanth Menon , Olivier Moysan , Pawel Laszczak , Peter Chen , Robert Richter , Russell King , Sasha Levin , Sebastian Hesselbarth , Shawn Guo , Thierry Reding , Thomas Gleixner , Tony Lindgren , Viresh Kumar , Will Deacon , William Cohen , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH v17 0/7] usb: misc: Add onboard_usb_hub driver Date: Tue, 16 Nov 2021 12:07:32 -0800 Message-Id: <20211116200739.924401-1-mka@chromium.org> X-Mailer: git-send-email 2.34.0.rc1.387.gb447b232ab-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org This series adds: - the onboard_usb_hub_driver - glue in the generic HCD code to create and destroy the onboard_usb_hub platform devices if needed - device tree changes that add RTS5411 entries for the QCA SC7180 based boards trogdor and lazor - a couple of stubs for platform device functions to avoid unresolved symbols with certain kernel configs The main issue the driver addresses is that a USB hub needs to be powered before it can be discovered. For discrete onboard hubs (an example for such a hub is the Realtek RTS5411) this is often solved by supplying the hub with an 'always-on' regulator, which is kind of a hack. Some onboard hubs may require further initialization steps, like changing the state of a GPIO or enabling a clock, which requires even more hacks. This driver creates a platform device representing the hub which performs the necessary initialization. Currently it only supports switching on a single regulator, support for multiple regulators or other actions can be added as needed. Different initialization sequences can be supported based on the compatible string. Besides performing the initialization the driver can be configured to power the hub off during system suspend. This can help to extend battery life on battery powered devices which have no requirements to keep the hub powered during suspend. The driver can also be configured to leave the hub powered when a wakeup capable USB device is connected when suspending, and power it off otherwise. Changes in v17: - rebased on top of v5.16-rc1 - moved creation of onboard_hub platform devices from xhci_platform to the generic HCD code - addressed review comments for the onboard_hub driver - moved Kconfig/defconfig changes to the end of the series. The onboard_hub driver doesn't depend on XHCI_PLATFORM anymore, hence these changes aren't really required for the driver, but they still seem to be a worthwhile improvement Changes in v16: - added patch 'ARM: configs: Explicitly enable USB_XHCI_PLATFORM where needed' to keep arm32 defconfigs effectively unchanged Changes in v15: - adjusted dependencies of USB_DWC3_CORE to make sure it can only be enabled when at least one of USB_DWC3_HOST, USB_DWC3_GADGET or USB_DWC3_DUAL_ROLE is selectable Changes in v14: - rebased on top of v5.14-rc1 - dropped DT binding patch which landed in v5.13 Changes in v13: - added patch "usb: Specify dependency on USB_XHCI_PLATFORM with 'depends on'" to the series to avoid Kconfig conflicts - added patch "arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM" to the series to keep effective defconfig unchanged Changes in v12: - onboard_hub driver: use IS_ENABLED(CONFIG_USB_ONBOARD_HUB_MODULE) in onboard_hub.h to also check for the driver built as module - onboard_hub_driver: include onboard_hub.h again to make sure there are prototype declarations for the public functions Changes in v11: - support multiple onboard hubs connected to the same parent - don't include ‘onboard_hub.h’ from the onboard hub driver Changes in v10: - always use of_is_onboard_usb_hub() stub unless ONBOARD_USB_HUB=y/m - keep 'regulator-boot-on' property for pp3300_hub Changes in v9: - added dependency on ONBOARD_USB_HUB (or !!ONBOARD_USB_HUB) to USB_PLATFORM_XHCI Changes in v7: - updated DT binding - series rebased on qcom/arm64-for-5.13 Changes in v6: - updated summary Changes in v5: - cover letter added Matthias Kaehlcke (7): usb: misc: Add onboard_usb_hub driver of/platform: Add stubs for of_platform_device_create/destroy() usb: core: hcd: Create platform devices for onboard hubs in probe() arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub ARM: configs: Explicitly enable USB_XHCI_PLATFORM where needed arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' .../sysfs-bus-platform-onboard-usb-hub | 8 + MAINTAINERS | 7 + arch/arm/configs/exynos_defconfig | 1 + arch/arm/configs/keystone_defconfig | 1 + arch/arm/configs/multi_v7_defconfig | 1 + arch/arm/configs/mvebu_v7_defconfig | 1 + arch/arm/configs/omap2plus_defconfig | 1 + arch/arm/configs/pxa_defconfig | 1 + .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 19 +- .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 12 +- .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 19 +- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 19 +- arch/arm64/configs/defconfig | 1 + drivers/usb/cdns3/Kconfig | 2 +- drivers/usb/core/hcd.c | 6 + drivers/usb/dwc3/Kconfig | 5 +- drivers/usb/host/Kconfig | 4 +- drivers/usb/misc/Kconfig | 17 + drivers/usb/misc/Makefile | 1 + drivers/usb/misc/onboard_usb_hub.c | 491 ++++++++++++++++++ include/linux/of_platform.h | 22 +- include/linux/usb/hcd.h | 1 + include/linux/usb/onboard_hub.h | 18 + 23 files changed, 619 insertions(+), 39 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-hub create mode 100644 drivers/usb/misc/onboard_usb_hub.c create mode 100644 include/linux/usb/onboard_hub.h