mbox series

[0/5] ARM: dts: nanobone: Fix missing/incorrect features

Message ID 20221109160904.183147-1-mpfj@newflow.co.uk
Headers show
Series ARM: dts: nanobone: Fix missing/incorrect features | expand

Message

Mark Jackson Nov. 9, 2022, 4:08 p.m. UTC 
This patch series updates the NanoBone DTS file to address various missing or
incorrect features.

Mark Jackson (5):
  ARM: dts: nanobone: Fix GPIO settings for RTS/CTS pins on UART3 & 4
  ARM: dts: nanobone: Enable RS485 mode for UART3 & 4
  ARM: dts: nanobone: Enable I2C temperature sensor
  ARM: dts: nanobone: Fix GPIO settings for MMC pins
  ARM: dts: nanobone: Enable USB host

 arch/arm/boot/dts/am335x-nano.dts | 32 +++++++++++++++++++++++++------
 1 file changed, 26 insertions(+), 6 deletions(-)

Comments

Krzysztof Kozlowski Nov. 9, 2022, 4:23 p.m. UTC | #1 
On 09/11/2022 17:09, Mark Jackson wrote:
> The NanoBone platform supports a temperature sensor on the I2C bus.
> 
> Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
> ---
>  arch/arm/boot/dts/am335x-nano.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am335x-nano.dts b/arch/arm/boot/dts/am335x-nano.dts
> index cecc2afaeff4..2be831927af6 100644
> --- a/arch/arm/boot/dts/am335x-nano.dts
> +++ b/arch/arm/boot/dts/am335x-nano.dts
> @@ -212,6 +212,11 @@ &uart5 {
>  	status = "okay";
>  };
>  
> +temperature-sensor@48 {
> +	compatible = "lm75";
> +	reg = <0x48>;
> +};

This should not work - you put the node in some random place.

Best regards,
Krzysztof
Mark Jackson Nov. 9, 2022, 4:57 p.m. UTC | #2 
On Wed, 9 Nov 2022 at 16:22, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 09/11/2022 17:09, Mark Jackson wrote:
> > The NanoBone platform uses GPIO pins for RTS/CTS control.
> > The DTS still uses the hardware RTS/CTS pins so this needs fixing.
> >
> > Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
> > ---
> >  arch/arm/boot/dts/am335x-nano.dts | 8 ++++----
>
> You still use a bit odd subject prefixes. What did the log tell you for
> am335x files?

Aha, now I understand ... I need to change "nanobone" in the title to
"am335x-nano" to match our dts file, correct ?

Regards
Mark J.
Mark Jackson Nov. 9, 2022, 5:03 p.m. UTC | #3 
On Wed, 9 Nov 2022 at 16:58, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 09/11/2022 17:57, Mark Jackson wrote:
> > On Wed, 9 Nov 2022 at 16:22, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 09/11/2022 17:09, Mark Jackson wrote:
> >>> The NanoBone platform uses GPIO pins for RTS/CTS control.
> >>> The DTS still uses the hardware RTS/CTS pins so this needs fixing.
> >>>
> >>> Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
> >>> ---
> >>>  arch/arm/boot/dts/am335x-nano.dts | 8 ++++----
> >>
> >> You still use a bit odd subject prefixes. What did the log tell you for
> >> am335x files?
> >
> > Aha, now I understand ... I need to change "nanobone" in the title to
> > "am335x-nano" to match our dts file, correct ?
>
> Yes, I think this is the most popular subject prefix. It allows
> sub-architecture maintainers to understand what is it about.

Seems reasonable ... I was almost correct with my first attempt.
I'll send myself off for re-training ...

Cheers
Mark J.