mbox series

[v3,0/3] Add TI TPS65215 PMIC GPIO Support

Message ID 20250113225530.124213-1-s-ramamoorthy@ti.com
Headers show
Series Add TI TPS65215 PMIC GPIO Support | expand

Message

Shree Ramamoorthy Jan. 13, 2025, 10:55 p.m. UTC
TPS65215 is a Power Management Integrated Circuit (PMIC) that has
significant register map overlap with TPS65219. The series introduces
TPS65215 and restructures the existing driver to support multiple devices.

This follow-up series is dependent on:
Commit f84464ec8190 ("regulator: dt-bindings: Add TI TPS65215 PMIC bindings")
Commit 8206c20f4c82 ("mfd: tps65215: Add support for TI TPS65215 PMIC")
Commit 0e0b7f00c111 ("mfd: tps65215: Remove regmap_read check")

TPS65219 Cleanup Series:
GPIO: https://lore.kernel.org/all/20241217204755.1011731-1-s-ramamoorthy@ti.com/
MFD: https://lore.kernel.org/all/20241217204935.1012106-1-s-ramamoorthy@ti.com/
Reg: https://lore.kernel.org/all/20241217204526.1010989-1-s-ramamoorthy@ti.com/

- Both TPS65215 and TPS65219 have 3 Buck regulators.
- TPS65215 has 2 LDOs, whereas TPS65219 has 4 LDOs.
- TPS65215 and TPS65219's LDO1 are the same.
- TPS65215's LDO2 maps to TPS65219's LDO3.
- TPS65215 has 1 GPO, whereas TPS65219 has 2 GPOs.
- The remaining features are the same.

TPS65215 TRM: https://www.ti.com/lit/pdf/slvucw5/

AM62L + TPS65215 Test Logs:
https://gist.github.com/ramamoorthyhs/7560eca6110fafc77b51894fa2c0fd22

---
Change Log:
v2 -> v3:
- Correct gpio_chip.ngpio line to use .offset field
- Remove unnecessary newlines

v1 -> v2:
- have any PMIC lists be in alpha-numeric order: TPS65215, then TPS65219
- remove comma after terminator
- Add driver prefix to chip_data struct
---

Shree Ramamoorthy (3):
  gpio: tps65215: Add TPS65215 to platform_device_id table
  gpio: tps65215: Update GPIO0_IDX macro prefix
  gpio tps65215: Add support for varying gpio/offset values

 drivers/gpio/gpio-tps65219.c | 55 +++++++++++++++++++++++++++---------
 1 file changed, 41 insertions(+), 14 deletions(-)

Comments

Bartosz Golaszewski Feb. 7, 2025, 8:53 a.m. UTC | #1
On Mon, Jan 13, 2025 at 11:55 PM Shree Ramamoorthy <s-ramamoorthy@ti.com> wrote:
>
> TPS65215 is a Power Management Integrated Circuit (PMIC) that has
> significant register map overlap with TPS65219. The series introduces
> TPS65215 and restructures the existing driver to support multiple devices.
>
> This follow-up series is dependent on:
> Commit f84464ec8190 ("regulator: dt-bindings: Add TI TPS65215 PMIC bindings")
> Commit 8206c20f4c82 ("mfd: tps65215: Add support for TI TPS65215 PMIC")
> Commit 0e0b7f00c111 ("mfd: tps65215: Remove regmap_read check")
>

Did these go into v6.14?

Bart
Shree Ramamoorthy Feb. 7, 2025, 5:02 p.m. UTC | #2
Hi,

On 2/7/2025 2:53 AM, Bartosz Golaszewski wrote:
> On Mon, Jan 13, 2025 at 11:55 PM Shree Ramamoorthy <s-ramamoorthy@ti.com> wrote:
>> TPS65215 is a Power Management Integrated Circuit (PMIC) that has
>> significant register map overlap with TPS65219. The series introduces
>> TPS65215 and restructures the existing driver to support multiple devices.
>>
>> This follow-up series is dependent on:
>> Commit f84464ec8190 ("regulator: dt-bindings: Add TI TPS65215 PMIC bindings")
>> Commit 8206c20f4c82 ("mfd: tps65215: Add support for TI TPS65215 PMIC")
>> Commit 0e0b7f00c111 ("mfd: tps65215: Remove regmap_read check")
>>
> Did these go into v6.14?
>
> Bart

These didn't. I figured with the dependency feedback, it was easier to combine the series for TPS65215 and TPS65214 into 1 series.

I submitted the combined mfd + dt-binding series [0] first, and once that was ACK'd, I will follow up with the gpio series for both devices.
Let me know if there's a different approach you would recommend!

[0]: https://lore.kernel.org/all/20250206173725.386720-1-s-ramamoorthy@ti.com/
Shree Ramamoorthy Feb. 12, 2025, 9:12 p.m. UTC | #3
Hi,


On 2/7/25 2:53 AM, Bartosz Golaszewski wrote:
> On Mon, Jan 13, 2025 at 11:55 PM Shree Ramamoorthy <s-ramamoorthy@ti.com> wrote:
>> TPS65215 is a Power Management Integrated Circuit (PMIC) that has
>> significant register map overlap with TPS65219. The series introduces
>> TPS65215 and restructures the existing driver to support multiple devices.
>>
>> This follow-up series is dependent on:
>> Commit f84464ec8190 ("regulator: dt-bindings: Add TI TPS65215 PMIC bindings")
>> Commit 8206c20f4c82 ("mfd: tps65215: Add support for TI TPS65215 PMIC")
>> Commit 0e0b7f00c111 ("mfd: tps65215: Remove regmap_read check")
>>
> Did these go into v6.14?
>
> Bart

The dependencies listed in the cover letter were just applied by Lee Jones:
https://lore.kernel.org/all/173928615760.2233464.12306998726512431222.b4-ty@kernel.org/

The rest of this series still applies without a need for code modifications.
Bartosz Golaszewski Feb. 13, 2025, 8:11 a.m. UTC | #4
On Wed, Feb 12, 2025 at 10:12 PM Shree Ramamoorthy <s-ramamoorthy@ti.com> wrote:
>
> Hi,
>
>
> On 2/7/25 2:53 AM, Bartosz Golaszewski wrote:
> > On Mon, Jan 13, 2025 at 11:55 PM Shree Ramamoorthy <s-ramamoorthy@ti.com> wrote:
> >> TPS65215 is a Power Management Integrated Circuit (PMIC) that has
> >> significant register map overlap with TPS65219. The series introduces
> >> TPS65215 and restructures the existing driver to support multiple devices.
> >>
> >> This follow-up series is dependent on:
> >> Commit f84464ec8190 ("regulator: dt-bindings: Add TI TPS65215 PMIC bindings")
> >> Commit 8206c20f4c82 ("mfd: tps65215: Add support for TI TPS65215 PMIC")
> >> Commit 0e0b7f00c111 ("mfd: tps65215: Remove regmap_read check")
> >>
> > Did these go into v6.14?
> >
> > Bart
>
> The dependencies listed in the cover letter were just applied by Lee Jones:
> https://lore.kernel.org/all/173928615760.2233464.12306998726512431222.b4-ty@kernel.org/
>
> The rest of this series still applies without a need for code modifications.
>

I'm not sure I'm following: should this series wait until v6.15-rc1 is
tagged? Or did you ask Lee to create an immutable branch? Or doesn't
this series depend on the MFD changes at all after all?

Bart
Shree Ramamoorthy Feb. 18, 2025, 5:33 p.m. UTC | #5
Hi,


On 2/13/25 2:11 AM, Bartosz Golaszewski wrote:
> On Wed, Feb 12, 2025 at 10:12 PM Shree Ramamoorthy <s-ramamoorthy@ti.com> wrote:
>> Hi,
>>
>>
>> On 2/7/25 2:53 AM, Bartosz Golaszewski wrote:
>>> On Mon, Jan 13, 2025 at 11:55 PM Shree Ramamoorthy <s-ramamoorthy@ti.com> wrote:
>>>> TPS65215 is a Power Management Integrated Circuit (PMIC) that has
>>>> significant register map overlap with TPS65219. The series introduces
>>>> TPS65215 and restructures the existing driver to support multiple devices.
>>>>
>>>> This follow-up series is dependent on:
>>>> Commit f84464ec8190 ("regulator: dt-bindings: Add TI TPS65215 PMIC bindings")
>>>> Commit 8206c20f4c82 ("mfd: tps65215: Add support for TI TPS65215 PMIC")
>>>> Commit 0e0b7f00c111 ("mfd: tps65215: Remove regmap_read check")
>>>>
>>> Did these go into v6.14?
>>>
>>> Bart
>> The dependencies listed in the cover letter were just applied by Lee Jones:
>> https://lore.kernel.org/all/173928615760.2233464.12306998726512431222.b4-ty@kernel.org/
>>
>> The rest of this series still applies without a need for code modifications.
>>
> I'm not sure I'm following: should this series wait until v6.15-rc1 is
> tagged? Or did you ask Lee to create an immutable branch? Or doesn't
> this series depend on the MFD changes at all after all?
>
> Bart

Sorry about the confusion. Lee didn't create an immutable branch and the series does depend on the MFD changes,
so this GPIO series should wait till v6.15-rc1 is tagged. Thank you!