| Message ID | 20201028223009.369824-1-krzk@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [RESEND,01/42] mfd: arizona: use PLATFORM_DEVID_NONE | expand |
On 28/10/2020 23:29, Krzysztof Kozlowski wrote: > Use PLATFORM_DEVID_NONE define instead of "-1" value because: > - it brings some meaning, > - it might point attention why auto device ID was not used. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Hi Lee, I sent this patchset some time ago, then made a resend. I did not get any feedback from you so I just wonder - are you still considering this patchset and shall I resend? Best regards, Krzysztof > --- > drivers/mfd/arizona-core.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index 000cb82023e3..bf48372db605 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -1043,8 +1043,9 @@ int arizona_dev_init(struct arizona *arizona) > case CS47L24: > break; /* No LDO1 regulator */ > default: > - ret = mfd_add_devices(arizona->dev, -1, early_devs, > - ARRAY_SIZE(early_devs), NULL, 0, NULL); > + ret = mfd_add_devices(arizona->dev, PLATFORM_DEVID_NONE, > + early_devs, ARRAY_SIZE(early_devs), > + NULL, 0, NULL); > if (ret != 0) { > dev_err(dev, "Failed to add early children: %d\n", ret); > return ret; >
diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 000cb82023e3..bf48372db605 100644 --- a/drivers/mfd/arizona-core.c +++ b/drivers/mfd/arizona-core.c @@ -1043,8 +1043,9 @@ int arizona_dev_init(struct arizona *arizona) case CS47L24: break; /* No LDO1 regulator */ default: - ret = mfd_add_devices(arizona->dev, -1, early_devs, - ARRAY_SIZE(early_devs), NULL, 0, NULL); + ret = mfd_add_devices(arizona->dev, PLATFORM_DEVID_NONE, + early_devs, ARRAY_SIZE(early_devs), + NULL, 0, NULL); if (ret != 0) { dev_err(dev, "Failed to add early children: %d\n", ret); return ret;