| Message ID | 20250609-bbg-v2-4-5278026b7498@bootlin.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for BeagleBone Green Eco board | expand |
On Mon, Jun 09, 2025 at 05:43:54PM +0200, Kory Maincent wrote: > SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green > (BBG). It has minor differences from the BBG, such as a different PMIC, > a different Ethernet PHY, and a larger eMMC. > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > --- > > Changes in v2: > - Used generic pmic node name. > - Add regulator prefix to fixed regulator node name. > - Add the compatible to omap.yaml binding > --- > Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + > arch/arm/boot/dts/ti/omap/Makefile | 1 + > arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 170 +++++++++++++++++++++ > 3 files changed, 172 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml > index c43fa4f4af81..774c13157caa 100644 > --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml > +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml > @@ -145,6 +145,7 @@ properties: > - description: TI bone green variants based on TI AM335 > items: > - enum: > + - ti,am335x-bone-green-eco > - ti,am335x-bone-green-wireless > - const: ti,am335x-bone-green > - const: ti,am335x-bone Why is this hunk here?
Le Mon, 9 Jun 2025 18:04:01 +0100, Conor Dooley <conor@kernel.org> a écrit : > On Mon, Jun 09, 2025 at 05:43:54PM +0200, Kory Maincent wrote: > > SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green > > (BBG). It has minor differences from the BBG, such as a different PMIC, > > a different Ethernet PHY, and a larger eMMC. > > > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > > --- > > > > Changes in v2: > > - Used generic pmic node name. > > - Add regulator prefix to fixed regulator node name. > > - Add the compatible to omap.yaml binding > > --- > > Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + > > arch/arm/boot/dts/ti/omap/Makefile | 1 + > > arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 170 > > +++++++++++++++++++++ 3 files changed, 172 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml index > > c43fa4f4af81..774c13157caa 100644 --- > > a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++ > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -145,6 +145,7 @@ > > properties: > > - description: TI bone green variants based on TI AM335 > > items: > > - enum: > > + - ti,am335x-bone-green-eco > > - ti,am335x-bone-green-wireless > > - const: ti,am335x-bone-green > > - const: ti,am335x-bone > > Why is this hunk here? Do you mean that the binding change should be in another patch?
On Mon, Jun 09, 2025 at 10:45:02PM +0200, Kory Maincent wrote: > Le Mon, 9 Jun 2025 18:04:01 +0100, > Conor Dooley <conor@kernel.org> a écrit : > > > On Mon, Jun 09, 2025 at 05:43:54PM +0200, Kory Maincent wrote: > > > SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green > > > (BBG). It has minor differences from the BBG, such as a different PMIC, > > > a different Ethernet PHY, and a larger eMMC. > > > > > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > > > --- > > > > > > Changes in v2: > > > - Used generic pmic node name. > > > - Add regulator prefix to fixed regulator node name. > > > - Add the compatible to omap.yaml binding > > > --- > > > Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + > > > arch/arm/boot/dts/ti/omap/Makefile | 1 + > > > arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 170 > > > +++++++++++++++++++++ 3 files changed, 172 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml > > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml index > > > c43fa4f4af81..774c13157caa 100644 --- > > > a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++ > > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -145,6 +145,7 @@ > > > properties: > > > - description: TI bone green variants based on TI AM335 > > > items: > > > - enum: > > > + - ti,am335x-bone-green-eco > > > - ti,am335x-bone-green-wireless > > > - const: ti,am335x-bone-green > > > - const: ti,am335x-bone > > > > Why is this hunk here? > > Do you mean that the binding change should be in another patch? Yes, you have a binding change hidden away in a dts patch.
diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml index c43fa4f4af81..774c13157caa 100644 --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -145,6 +145,7 @@ properties: - description: TI bone green variants based on TI AM335 items: - enum: + - ti,am335x-bone-green-eco - ti,am335x-bone-green-wireless - const: ti,am335x-bone-green - const: ti,am335x-bone diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile index 95c68135dd0c..1aef60eef671 100644 --- a/arch/arm/boot/dts/ti/omap/Makefile +++ b/arch/arm/boot/dts/ti/omap/Makefile @@ -93,6 +93,7 @@ dtb-$(CONFIG_SOC_AM33XX) += \ am335x-boneblue.dtb \ am335x-bonegreen.dtb \ am335x-bonegreen-wireless.dtb \ + am335x-bonegreen-eco.dtb \ am335x-chiliboard.dtb \ am335x-cm-t335.dtb \ am335x-evm.dtb \ diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts new file mode 100644 index 000000000000..f2592a3ddbbb --- /dev/null +++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts @@ -0,0 +1,170 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (C) 2025 Bootlin + */ +/dts-v1/; + +#include "am33xx.dtsi" +#include "am335x-bone-common.dtsi" +#include "am335x-bonegreen-common.dtsi" +#include <dt-bindings/net/ti-dp83867.h> + +/ { + model = "TI AM335x BeagleBone Green Eco"; + compatible = "ti,am335x-bone-green-eco", "ti,am335x-bone-green", + "ti,am335x-bone", "ti,am33xx"; + + cpus { + cpu@0 { + cpu0-supply = <&buck1>; + }; + }; + + sys_5v: regulator-sys-5v { + compatible = "regulator-fixed"; + regulator-name = "sys_5v"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + }; + + v3v3: regulator-v3v3 { + compatible = "regulator-fixed"; + regulator-name = "v3v3"; + regulator-always-on; + }; +}; + +&usb0 { + interrupts-extended = <&intc 18>; + interrupt-names = "mc"; +}; + +&baseboard_eeprom { + vcc-supply = <&v3v3>; +}; + +&i2c0 { + /delete-node/ pmic@24; + + tps65214: pmic@30 { + compatible = "ti,tps65214"; + reg = <0x30>; + buck1-supply = <&sys_5v>; + buck2-supply = <&sys_5v>; + buck3-supply = <&sys_5v>; + ldo1-supply = <&sys_5v>; + ldo2-supply = <&sys_5v>; + + interrupt-parent = <&intc>; + interrupts = <7>; + pinctrl-0 = <&pmic_irq_pins_default>; + + regulators { + buck1: buck1 { + regulator-name = "vdd_mpu"; + regulator-min-microvolt = <925000>; + regulator-max-microvolt = <1351500>; + regulator-boot-on; + regulator-always-on; + }; + + buck2: buck2 { + regulator-name = "vdd_core"; + regulator-min-microvolt = <925000>; + regulator-max-microvolt = <1150000>; + regulator-boot-on; + regulator-always-on; + }; + + buck3: buck3 { + regulator-name = "vdds_ddr"; + regulator-min-microvolt = <1350000>; + regulator-max-microvolt = <1350000>; + regulator-always-on; + }; + + ldo1_reg: ldo1 { + regulator-name = "vdd_1v8_1"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo2_reg: ldo2 { + regulator-name = "vdd_1v8_2"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + }; + }; +}; + +&cpsw_port1 { + phy-mode = "rgmii-id"; + phy-handle = <&dp83867_0>; + ti,dual-emac-pvid = <1>; +}; + +&mac_sw { + pinctrl-0 = <&cpsw_b_default>; + pinctrl-1 = <&cpsw_b_sleep>; +}; + +&davinci_mdio_sw { + /delete-node/ ethernet-phy@0; + + dp83867_0: ethernet-phy@0 { + reg = <0>; + ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_50_NS>; + ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_50_NS>; + ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_8_B_NIB>; + ti,min-output-impedance; + ti,dp83867-rxctrl-strap-quirk; + }; +}; + +&am33xx_pinmux { + cpsw_b_default: cpsw-b-default-pins { + pinctrl-single,pins = < + AM33XX_PADCONF(AM335X_PIN_MII1_TX_EN, PIN_OUTPUT_PULLDOWN, MUX_MODE2) + AM33XX_PADCONF(AM335X_PIN_MII1_RX_DV, PIN_INPUT_PULLDOWN, MUX_MODE2) + AM33XX_PADCONF(AM335X_PIN_MII1_TX_CLK, PIN_OUTPUT_PULLDOWN, MUX_MODE2) + AM33XX_PADCONF(AM335X_PIN_MII1_RX_CLK, PIN_INPUT_PULLDOWN, MUX_MODE2) + AM33XX_PADCONF(AM335X_PIN_MII1_TXD0, PIN_OUTPUT_PULLDOWN, MUX_MODE2) + AM33XX_PADCONF(AM335X_PIN_MII1_TXD1, PIN_OUTPUT_PULLDOWN, MUX_MODE2) + AM33XX_PADCONF(AM335X_PIN_MII1_TXD2, PIN_OUTPUT_PULLDOWN, MUX_MODE2) + AM33XX_PADCONF(AM335X_PIN_MII1_TXD3, PIN_OUTPUT_PULLDOWN, MUX_MODE2) + AM33XX_PADCONF(AM335X_PIN_MII1_RXD0, PIN_INPUT_PULLDOWN, MUX_MODE2) + AM33XX_PADCONF(AM335X_PIN_MII1_RXD1, PIN_INPUT_PULLDOWN, MUX_MODE2) + AM33XX_PADCONF(AM335X_PIN_MII1_RXD2, PIN_INPUT_PULLDOWN, MUX_MODE2) + AM33XX_PADCONF(AM335X_PIN_MII1_RXD3, PIN_INPUT_PULLDOWN, MUX_MODE2) + >; + }; + + cpsw_b_sleep: cpsw-b-sleep-pins { + pinctrl-single,pins = < + AM33XX_PADCONF(AM335X_PIN_MII1_TX_EN, PIN_INPUT_PULLDOWN, MUX_MODE7) + AM33XX_PADCONF(AM335X_PIN_MII1_RX_DV, PIN_INPUT_PULLDOWN, MUX_MODE7) + AM33XX_PADCONF(AM335X_PIN_MII1_TX_CLK, PIN_INPUT_PULLDOWN, MUX_MODE7) + AM33XX_PADCONF(AM335X_PIN_MII1_RX_CLK, PIN_INPUT_PULLDOWN, MUX_MODE7) + AM33XX_PADCONF(AM335X_PIN_MII1_TXD0, PIN_INPUT_PULLDOWN, MUX_MODE7) + AM33XX_PADCONF(AM335X_PIN_MII1_TXD1, PIN_INPUT_PULLDOWN, MUX_MODE7) + AM33XX_PADCONF(AM335X_PIN_MII1_TXD2, PIN_INPUT_PULLDOWN, MUX_MODE7) + AM33XX_PADCONF(AM335X_PIN_MII1_TXD3, PIN_INPUT_PULLDOWN, MUX_MODE7) + AM33XX_PADCONF(AM335X_PIN_MII1_RXD0, PIN_INPUT_PULLDOWN, MUX_MODE7) + AM33XX_PADCONF(AM335X_PIN_MII1_RXD1, PIN_INPUT_PULLDOWN, MUX_MODE7) + AM33XX_PADCONF(AM335X_PIN_MII1_RXD2, PIN_INPUT_PULLDOWN, MUX_MODE7) + AM33XX_PADCONF(AM335X_PIN_MII1_RXD3, PIN_INPUT_PULLDOWN, MUX_MODE7) + >; + }; + + pmic_irq_pins_default: pmic-irq-default-pins { + pinctrl-single,pins = < + AM33XX_IOPAD(AM335X_PIN_NNMI, PIN_INPUT_PULLUP | MUX_MODE0) + >; + }; +};
SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green (BBG). It has minor differences from the BBG, such as a different PMIC, a different Ethernet PHY, and a larger eMMC. Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> --- Changes in v2: - Used generic pmic node name. - Add regulator prefix to fixed regulator node name. - Add the compatible to omap.yaml binding --- Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + arch/arm/boot/dts/ti/omap/Makefile | 1 + arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 170 +++++++++++++++++++++ 3 files changed, 172 insertions(+)