From patchwork Mon Jul 14 13:13:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sekhar Nori X-Patchwork-Id: 33585 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f71.google.com (mail-yh0-f71.google.com [209.85.213.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id BDB312061E for ; Mon, 14 Jul 2014 13:14:41 +0000 (UTC) Received: by mail-yh0-f71.google.com with SMTP id 29sf12446217yhl.6 for ; Mon, 14 Jul 2014 06:14:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type; bh=R5Q1mfEBbpfWK07Khdx5Lm2iWLRAUOofUM55HRMxMD4=; b=dZgdpAHW+bQqzaN+8FHuStzmqdHobYpXpHmvM03Eh3HxytlvSG9kjiaiwpnJ1La50P Cew4BaBUKMdH58H0bw5nNqxxnwGUjKtqKcp50eKk6eLHztSNWgYFLIIjD628uLHzentC JlzO2VtIVBa+151SsuYGueL50etqTW9QllDmttmqwCVG6eQ+RuD0hzlUz/J+ER76bayJ p8ZI7BdUA6OC364nn8Vglhj9Y0IPhD2T5iYbPgBqyEbXIce+uuD/OZumNS1G+mE1u7Fu LkIfzQVaEFG9Zp6tgV6Z0ePqHvScCpZ2Sb+XdnFtQ4+/IY27KyDTT+NJiLwDe/CpwWiQ pDiw== X-Gm-Message-State: ALoCoQlHO2hQ+71vZuNAIRE7QYzp4rAtlAPyMY2ytUvfkVK7HyJYVk42vffltykgsDOE97sjUQFy X-Received: by 10.58.19.227 with SMTP id i3mr7474463vee.2.1405343681498; Mon, 14 Jul 2014 06:14:41 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.94.13 with SMTP id f13ls500810qge.65.gmail; Mon, 14 Jul 2014 06:14:41 -0700 (PDT) X-Received: by 10.58.82.106 with SMTP id h10mr257075vey.60.1405343681287; Mon, 14 Jul 2014 06:14:41 -0700 (PDT) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id cb8si5340834vcb.36.2014.07.14.06.14.41 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 14 Jul 2014 06:14:41 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id hy10so3255752vcb.18 for ; Mon, 14 Jul 2014 06:14:41 -0700 (PDT) X-Received: by 10.220.251.134 with SMTP id ms6mr16424744vcb.10.1405343681210; Mon, 14 Jul 2014 06:14:41 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp134054vcb; Mon, 14 Jul 2014 06:14:40 -0700 (PDT) X-Received: by 10.68.190.98 with SMTP id gp2mr16615836pbc.88.1405343680198; Mon, 14 Jul 2014 06:14:40 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ch3si9113369pbb.235.2014.07.14.06.14.39; Mon, 14 Jul 2014 06:14:39 -0700 (PDT) Received-SPF: none (google.com: linux-omap-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755557AbaGNNOj (ORCPT + 6 others); Mon, 14 Jul 2014 09:14:39 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:56253 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755523AbaGNNOi (ORCPT ); Mon, 14 Jul 2014 09:14:38 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s6EDE9kV028589; Mon, 14 Jul 2014 08:14:09 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s6EDE8pk009574; Mon, 14 Jul 2014 08:14:09 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Mon, 14 Jul 2014 08:14:08 -0500 Received: from psplinux063.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s6EDE5uD013735; Mon, 14 Jul 2014 08:14:06 -0500 From: Sekhar Nori To: Tony Lindgren CC: Linux OMAP Mailing List , Nishanth Menon , Felipe Balbi , Santosh Shilimkar , Linux ARM Mailing List , Russell King , Sekhar Nori Subject: [PATCH v2] ARM: OMAP2+: l2c: squelch warning dump on power control setting Date: Mon, 14 Jul 2014 18:43:46 +0530 Message-ID: X-Mailer: git-send-email 1.7.10.1 MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: nsekhar@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On OMAP SOCs using PL310 controllers, power_ctrl register is not accessible from non-secure software even on PL310 versions which support it. The secure code takes care of setting it up correctly and power transitions are proven on these devices. For example, AM437x has L2C-310 version r3p3 and ROM code on that device does not support writing to L2C-310 power control register. The L2C driver, however, tries writing to this register for all revisions >= r3p0. This leads to a warning dump on boot which leads most users to believe that L2 cache is non-functional. Since the problem is understood, and cannot be addressed through software, replace the warning with a pr_info() while maintaining the WARN_ON() for other truly unexpected scenarios. Reported-by: Nishanth Menon Tested-by: Felipe Balbi Signed-off-by: Sekhar Nori Acked-by: Santosh Shilimkar --- Only description updated since v1 arch/arm/mach-omap2/omap4-common.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c index 326cd98..9139729 100644 --- a/arch/arm/mach-omap2/omap4-common.c +++ b/arch/arm/mach-omap2/omap4-common.c @@ -188,6 +188,10 @@ static void omap4_l2c310_write_sec(unsigned long val, unsigned reg) smc_op = OMAP4_MON_L2X0_PREFETCH_INDEX; break; + case L310_POWER_CTRL: + pr_info_once("OMAP L2C310: ROM does not support power control setting\n"); + return; + default: WARN_ONCE(1, "OMAP L2C310: ignoring write to reg 0x%x\n", reg); return;