| Message ID | 1485345342-3273-1-git-send-email-m.szyprowski@samsung.com |
|---|---|
| Headers | show |
| Series | Power domains support for Exynos5433 SoCs | expand |
On Wed, Jan 25, 2017 at 12:55:34PM +0100, Marek Szyprowski wrote: > Hello, > > This patchset is a final step to add support for all power domains > on Exynos5433 SoCs. This patchset contains patches for adding Exynos5433 > support to Exynos power domain driver and definitions of all power > domains found in Exynos5433 SoCs. > > Patches have been generated on top of linux-next from 25th January 2017. > > This is a part of a larger task, which goal is to add support for power > domains on Exynos5433 SoCs / TM2 boards. All patches needed to get it > working have been pushed to the following git repo: > https://git.linaro.org/people/marek.szyprowski/linux-srpol.git v4.10-next-tm2-pd > > To get everything working following patches/patchsets are needed on top > of the linux-next tree: By "get everything working" you also mean that there is a runtime dependency? In other words, can I apply DTS patches here? Best regards, Krzysztof > 1. "Add support for the S6E3HA2 panel on TM2 board" v8 patchset: > http://www.spinics.net/lists/devicetree/msg157859.html > 2. "drm/exynos/decon5433: configure sysreg in case of hardware trigger" v2: > https://patchwork.kernel.org/patch/9493177/ > 3. "Move pad retention control to Exynos pin controller driver" v3 patchset: > https://www.spinics.net/lists/arm-kernel/msg556074.html > 4. "Pad retentions support for Exynos5433" patchset > (posted a few minutes ago, no link yet available) > 5. "Exynos5433/TM2: add clocks configuration for display subsystem" patchset > (posted a few minutes ago, no link yet available) > 6. "clk: samsung: pll: Add enable/disable support for PLL35XX" patch > (posted a few minutes ago, no link yet available) > 7. "IOMMU probe deferral support" v7 patchset: > https://www.spinics.net/lists/arm-kernel/msg557110.html > 8. "Add runtime PM support for clocks (on Exynos SoC example)" v5 patchset > (posted a few minutes ago, no link yet available) > 9. "Power domains support for Exynos5433 SoCs" patchset > (this patchset) > > Best regards > Marek Szyprowski > Samsung R&D Institute Poland > > > Patch summary: > > Chanwoo Choi (1): > soc: samsung: pm_domains: Add new exynos5433 compatible > > Marek Szyprowski (7): > arm64: dts: exynos: Add GSCL power domain to Exynos 5433 SoC > arm64: dts: exynos: Add DISP power domain to Exynos 5433 SoC > arm64: dts: exynos: Add MSCL power domain to Exynos 5433 SoC > arm64: dts: exynos: Add MFC power domain to Exynos 5433 SoC > arm64: dts: exynos: Add AUD power domain to Exynos5433 SoC > arm64: dts: exynos: Add FSYS power domain to Exynos5433 SoC > arm64: dts: exynos: Add remaining power domains to Exynos5433 SoC > > .../devicetree/bindings/power/pd-samsung.txt | 1 + > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 118 +++++++++++++++++++++ > drivers/soc/samsung/pm_domains.c | 7 ++ > 3 files changed, 126 insertions(+) > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Krzysztof, On 2017-01-27 08:46, Krzysztof Kozlowski wrote: > On Wed, Jan 25, 2017 at 12:55:36PM +0100, Marek Szyprowski wrote: >> This patch adds support for GSCL power domain to Exynos 5433 SoCs, which >> contains following devices: a clock controller, three GSCL video scalers and >> their SYSMMUs. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >> --- >> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> index 16072c1c3ed3..74c767d756ac 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> @@ -425,6 +425,7 @@ >> clocks = <&xxti>, >> <&cmu_top CLK_ACLK_GSCL_111>, >> <&cmu_top CLK_ACLK_GSCL_333>; >> + power-domains = <&pd_gscl>; >> }; >> >> cmu_apollo: clock-controller@11900000 { >> @@ -525,6 +526,12 @@ >> <&cmu_top CLK_ACLK_CAM1_552>; >> }; >> >> + pd_gscl: gscl-power-domain@105c4000 { > The name of node: just "power-domain". This should be generic class of > device (following ePAPR). > > The same applies to other patches. Well, this makes the debugging much harder, but I will change it to generic names. Also existing Exynos dtsi should be fixed in this area (Exynos4 still use such more descriptive names). I will check how hard is to add real domain names directly to the Exynos power domain driver then. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jan 27, 2017 at 11:33:36AM +0100, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2017-01-27 08:46, Krzysztof Kozlowski wrote: > > On Wed, Jan 25, 2017 at 12:55:36PM +0100, Marek Szyprowski wrote: > > > This patch adds support for GSCL power domain to Exynos 5433 SoCs, which > > > contains following devices: a clock controller, three GSCL video scalers and > > > their SYSMMUs. > > > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > > > --- > > > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 13 +++++++++++++ > > > 1 file changed, 13 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > > > index 16072c1c3ed3..74c767d756ac 100644 > > > --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi > > > +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > > > @@ -425,6 +425,7 @@ > > > clocks = <&xxti>, > > > <&cmu_top CLK_ACLK_GSCL_111>, > > > <&cmu_top CLK_ACLK_GSCL_333>; > > > + power-domains = <&pd_gscl>; > > > }; > > > cmu_apollo: clock-controller@11900000 { > > > @@ -525,6 +526,12 @@ > > > <&cmu_top CLK_ACLK_CAM1_552>; > > > }; > > > + pd_gscl: gscl-power-domain@105c4000 { > > The name of node: just "power-domain". This should be generic class of > > device (following ePAPR). > > > > The same applies to other patches. > > Well, this makes the debugging much harder, but I will change it to generic > names. Good point. I remember some patch from Javier trying to address this but I cannot find it anymore. Anyway, I don't think power-domains should be treated here differently then rest of devices (which have generic names: clock-controller, pinctrl, i2s, i2c etc). > Also existing Exynos dtsi should be fixed in this area (Exynos4 still > use such more descriptive names). I am trying to bring some shape to new code but of course you are right - old code should be adjusted as well (maybe as part of some bigger cleanup). Exynos5420 uses short/generic names. > I will check how hard is to add real > domain names directly to the Exynos power domain driver then. Thanks! Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html