| Message ID | 20230919-fp5-initial-v2-0-14bb7cedadf5@fairphone.com |
|---|---|
| Headers | show |
| Series | Initial support for the Fairphone 5 smartphone | expand |
On 19/09/2023 14:45, Luca Weiss wrote: > Like other Qualcomm PMICs the PM7250B can be used on different addresses > on the SPMI bus. Use similar defines like the PMK8350 to make this > possible but skip the ifndef based on maintainer feedback. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- Matches our discussion offline today. Looks good, thank you! Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 19/09/2023 14:46, Luca Weiss wrote: > Add device tree for the Fairphone 5 smartphone which is based on > the QCM6490 SoC. > > Supported features are, as of now: > * Bluetooth > * Debug UART > * Display via simplefb > * Flash/torch LED > * Flip cover sensor > * Power & volume buttons > * RTC > * SD card > * USB > * Various plumbing like regulators, i2c, spi, etc Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi, On Tue, Sep 19, 2023 at 5:46 AM Luca Weiss <luca.weiss@fairphone.com> wrote: > > On some platforms like sc7280 on non-ChromeOS devices the core clock > cannot be touched by Linux so we cannot provide it. Mark it as optional > as accessing qfprom for reading works without it but we still prohibit > writing if we cannot provide the clock. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > drivers/nvmem/qfprom.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
On 9/19/23 14:46, Luca Weiss wrote: > Add device tree for the Fairphone 5 smartphone which is based on > the QCM6490 SoC. > > Supported features are, as of now: > * Bluetooth > * Debug UART > * Display via simplefb > * Flash/torch LED > * Flip cover sensor > * Power & volume buttons > * RTC > * SD card > * USB > * Various plumbing like regulators, i2c, spi, etc > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Tested-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Tue, 19 Sep 2023 14:45:54 +0200, Luca Weiss wrote: > Add support to boot up mainline kernel on the QCM6490-based Fairphone 5 > smartphone. > > These patches only cover a part of the functionality brought up on > mainline so far, with the rest needing larger dts and driver changes or > depend on patches that are not yet merged. I will work on sending those > once these base patches here have settled. > > [...] Applied, thanks! [1/7] arm64: dts: qcom: sc7280: Mark some nodes as 'reserved' commit: 6da24ba932082bae110feb917a64bb54637fa7c0 [3/7] arm64: dts: qcom: pm7250b: make SID configurable commit: 8e2d56f64572e0432c355093a7601bde29677490 [4/7] arm64: dts: qcom: pm8350c: Add flash led node commit: bfd4412a023b2a3a2f858f2ffc13705aaeef5737 [6/7] dt-bindings: arm: qcom: Add QCM6490 Fairphone 5 commit: 4b1a16d776b474345b12f834de1fd42bca226d90 [7/7] arm64: dts: qcom: qcm6490: Add device-tree for Fairphone 5 commit: eee9602ad6498eee9ddab1b7eb6aede288f0b934 Best regards,
Add support to boot up mainline kernel on the QCM6490-based Fairphone 5 smartphone. These patches only cover a part of the functionality brought up on mainline so far, with the rest needing larger dts and driver changes or depend on patches that are not yet merged. I will work on sending those once these base patches here have settled. Since QCM6490, like SC7280 are 'yupik' in the vendor-provided kernel, we can base the dts on it and leverage existing support. Though current sc7280 support mostly assumes ChromeOS devices which have a different TrustZone setup, so we need to move some ChromeOS-specific bits to the sc7280-chrome-common.dtsi file to make it boot on a standard TZ board. Depends on (just for the #include in sc7280.dtsi): https://lore.kernel.org/linux-arm-msm/20230818-qcom-vmid-defines-v1-1-45b610c96b13@fairphone.com/ The pm7250b patch has been picked up from this series: https://lore.kernel.org/linux-arm-msm/20230407-pm7250b-sid-v1-2-fc648478cc25@fairphone.com/ Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Changes in v2: - Add comments why nodes in sc7280.dtsi get disabled (Konrad) - Mark more nodes in sc7280.dtsi as reserved - Don't allow writing qfprom when (optional) clock isn't found - Device dts changes: - Stylistic changes in device dts - Remove qcom,msm-id & qcom,board-id properties - Add regulator-initial-mode - Pick up tags - Drop patch 03 "arm64: dts: qcom: sc7280: Move qfprom clock to chrome-common", it's actually not needed with qfprom-clock-optional patch - Drop patch 07 "dt-bindings: arm: qcom,ids: Add SoC ID for QCM6490", patch 08 "soc: qcom: socinfo: Add SoC ID for QCM6490" and patch 09 "cpufreq: Add QCM6490 to cpufreq-dt-platdev blocklist", all applied. - Link to v1: https://lore.kernel.org/r/20230830-fp5-initial-v1-0-5a954519bbad@fairphone.com --- Luca Weiss (7): arm64: dts: qcom: sc7280: Mark some nodes as 'reserved' nvmem: qfprom: Mark core clk as optional arm64: dts: qcom: pm7250b: make SID configurable arm64: dts: qcom: pm8350c: Add flash led node dt-bindings: pinctrl: qcom,sc7280: Allow gpio-reserved-ranges dt-bindings: arm: qcom: Add QCM6490 Fairphone 5 arm64: dts: qcom: qcm6490: Add device-tree for Fairphone 5 Documentation/devicetree/bindings/arm/qcom.yaml | 6 + .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 4 + arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/pm7250b.dtsi | 14 +- arch/arm64/boot/dts/qcom/pm8350c.dtsi | 6 + arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 667 +++++++++++++++++++++ arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi | 24 + arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 +- arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 4 + drivers/nvmem/qfprom.c | 6 +- 10 files changed, 729 insertions(+), 11 deletions(-) --- base-commit: b3b1378016952541463ef2369da780d4f9bf02b3 change-id: 20230818-fp5-initial-b6c8210ba9c8 Best regards,