| Message ID | 20241215032507.4739-1-shimrrashai@gmail.com |
|---|---|
| Headers | show |
| Series | arm64: dts: rockchip: Add Firefly ITX-3588J Board | expand |
On Sat, Dec 14, 2024 at 09:24:53PM -0600, Shimrra Shai wrote: > Main DTS for the boards and Makefile addition. > > Signed-off-by: Shimrra Shai <shimrrashai@gmail.com> > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../rockchip/rk3588-firefly-core-3588j.dtsi | 453 +++++++++++ > .../dts/rockchip/rk3588-firefly-itx-3588j.dts | 712 ++++++++++++++++++ > 3 files changed, 1166 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-firefly-core-3588j.dtsi > create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-firefly-itx-3588j.dts > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index 86cc418a2..3f2eebd1f 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -137,6 +137,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-io.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtbo > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6b-io.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-evb1-v10.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-firefly-itx-3588j.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-friendlyelec-cm3588-nas.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-jaguar.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-nanopc-t6.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-firefly-core-3588j.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-firefly-core-3588j.dtsi > new file mode 100644 > index 000000000..e911a6472 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3588-firefly-core-3588j.dtsi > @@ -0,0 +1,453 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/pinctrl/rockchip.h> > + > +#include "rk3588.dtsi" > + > +/ { > + compatible = "firefly,core-3588j", "rockchip,rk3588"; Please run scripts/checkpatch.pl and fix reported warnings. Then please run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. It does not look like you tested the DTS against bindings. Please run 'make dtbs_check W=1' (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Maybe you need to update your dtschema and yamllint. Don't rely on distro packages for dtschema and be sure you are using the latest released dtschema. Best regards, Krzysztof
This is the 3rd draft of the device tree proposal for the Firefly ITX-3588J board. The same functionality issues as before are still outstanding; however I have cleaned up the style and structure as per the comments by Heiko Stübner on version 2. Of particular note is the splitting of the device tree source into two files because this platform actually consists of two boards: the ITX-3588J baseboard and a single Core-3588J compute module stuck in a slot on it. - Shimrra Shai. Shimrra Shai (3): arm64: dts: rockchip: add DTs for Firefly ITX-3588J and its Core-3588J SoM dt-bindings: pinctrl: add header for PCA9555 GPIO extender bindings on some Rockchip-based devices dt-bindings: arm: rockchip: Add Firefly ITX-3588J board .../devicetree/bindings/arm/rockchip.yaml | 7 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../rockchip/rk3588-firefly-core-3588j.dtsi | 453 +++++++++++ .../dts/rockchip/rk3588-firefly-itx-3588j.dts | 712 ++++++++++++++++++ .../dt-bindings/pinctrl/rockchip-pca9555.h | 31 + 5 files changed, 1204 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-firefly-core-3588j.dtsi create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-firefly-itx-3588j.dts create mode 100644 include/dt-bindings/pinctrl/rockchip-pca9555.h