[v2,00/12] thermal: core: Fixes and cleanups, mostly related to thermal zone init and exit

Message ID	2215082.irdbgypaU6@rjwysocki.net
Headers	show Received: from cloudserver094114.home.pl (cloudserver094114.home.pl [79.96.170.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDE501E04AF; Fri, 4 Oct 2024 19:43:10 +0000 (UTC) From: "Rafael J. Wysocki" <rjw@rjwysocki.net> To: Linux PM <linux-pm@vger.kernel.org> Cc: LKML <linux-kernel@vger.kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Lukasz Luba <lukasz.luba@arm.com>, Zhang Rui <rui.zhang@intel.com>, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Subject: [PATCH v2 00/12] thermal: core: Fixes and cleanups, mostly related to thermal zone init and exit Date: Fri, 04 Oct 2024 21:01:34 +0200 Message-ID: <2215082.irdbgypaU6@rjwysocki.net> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8"
Series	thermal: core: Fixes and cleanups, mostly related to thermal zone init and exit \| expand [v2,00/12] thermal: core: Fixes and cleanups, mostly related to thermal zone init and exit [v2,01/12] thermal: core: Initialize thermal zones before registering them [v2,02/12] thermal: core: Rearrange PM notification code [v2,03/12] thermal: core: Represent suspend-related thermal zone flags as bits [v2,04/12] thermal: core: Mark thermal zones as initializing to start with [v2,05/12] thermal: core: Fix race between zone registration and system suspend [v2,06/12] thermal: core: Consolidate thermal zone locking during initialization [v2,07/12] thermal: core: Mark thermal zones as exiting before unregistration [v2,08/12] thermal: core: Consolidate thermal zone locking in the exit path [v2,09/12] thermal: core: Update thermal zones after cooling device binding [v2,10/12] thermal: core: Drop need_update field from struct thermal_zone_device [v2,11/12] thermal: core: Move lists of thermal instances to trip descriptors [v2,12/12] thermal: core: Pass trip descriptors to trip bind/unbind functions

Message ID

2215082.irdbgypaU6@rjwysocki.net

Headers

From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
 Daniel Lezcano <daniel.lezcano@linaro.org>,
 Lukasz Luba <lukasz.luba@arm.com>, Zhang Rui <rui.zhang@intel.com>,
 Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: [PATCH v2 00/12] thermal: core: Fixes and cleanups,
 mostly related to thermal zone init and exit
Date: Fri, 04 Oct 2024 21:01:34 +0200
Message-ID: <2215082.irdbgypaU6@rjwysocki.net>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"

Series

thermal: core: Fixes and cleanups, mostly related to thermal zone init and exit | expand

Message

Rafael J. Wysocki Oct. 4, 2024, 7:01 p.m. UTC

Hi Everyone,

After posting the two series of thermal core patches for 6.13:

https://lore.kernel.org/linux-pm/4920970.GXAFRqVoOG@rjwysocki.net/

and

https://lore.kernel.org/linux-pm/6100907.lOV4Wx5bFT@rjwysocki.net/

before the 6.12 merge window, I have decided to reorder the changes included in
these series, so that fixes and more significant cleanups (for example, changing
they layout of data structures) go first, followed by the changes related to
using guards for locking, and the optimization involving sorted lists becomes
the last piece.

This series is the first part and the majority of patches in it come from the
second (RFC) series mentioned above.  Of course, they needed to be rebased to
be applied in the new order.  It is on top of 6.12-rc1 with

https://lore.kernel.org/linux-pm/12549318.O9o76ZdvQC@rjwysocki.net/

applied and it will be added to my thermal-core-testing branch.  It is in v2
to start with because all of the patches in it have already been posted in
some form.

The first 10 patches fix some potential issues related to thermal zone
initialization and exit (for example, user space may start to interact with
a thermal zone during its initialization before it's ready and system suspend
taking place at a wrong time may skip a new thermal zone so it is not suspended)
and do some cleanups related to that.  This concludes with the removal of the
need_update field from struct thermal_zone_device.

The last two patches move lists of thermal instances from thermal zones to
trip point descriptors and clean up some code on top of that.

Please refer to the individual patch changelogs for details.

Thanks!

Comments

Rafael J. Wysocki Oct. 11, 2024, 6:50 p.m. UTC | #1

On Fri, Oct 4, 2024 at 10:11 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> Hi Everyone,
>
> After posting the two series of thermal core patches for 6.13:
>
> https://lore.kernel.org/linux-pm/4920970.GXAFRqVoOG@rjwysocki.net/
>
> and
>
> https://lore.kernel.org/linux-pm/6100907.lOV4Wx5bFT@rjwysocki.net/
>
> before the 6.12 merge window, I have decided to reorder the changes included in
> these series, so that fixes and more significant cleanups (for example, changing
> they layout of data structures) go first, followed by the changes related to
> using guards for locking, and the optimization involving sorted lists becomes
> the last piece.
>
> This series is the first part and the majority of patches in it come from the
> second (RFC) series mentioned above.  Of course, they needed to be rebased to
> be applied in the new order.  It is on top of 6.12-rc1 with
>
> https://lore.kernel.org/linux-pm/12549318.O9o76ZdvQC@rjwysocki.net/
>
> applied and it will be added to my thermal-core-testing branch.  It is in v2
> to start with because all of the patches in it have already been posted in
> some form.
>
> The first 10 patches fix some potential issues related to thermal zone
> initialization and exit (for example, user space may start to interact with
> a thermal zone during its initialization before it's ready and system suspend
> taking place at a wrong time may skip a new thermal zone so it is not suspended)
> and do some cleanups related to that.  This concludes with the removal of the
> need_update field from struct thermal_zone_device.
>
> The last two patches move lists of thermal instances from thermal zones to
> trip point descriptors and clean up some code on top of that.
>
> Please refer to the individual patch changelogs for details.

This material is now present in the thermal-core-testing and
thermal-core-experimental branches in linux-pm.git.

Rafael J. Wysocki Oct. 21, 2024, 11:05 a.m. UTC | #2

On Fri, Oct 11, 2024 at 8:50 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Fri, Oct 4, 2024 at 10:11 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >
> > Hi Everyone,
> >
> > After posting the two series of thermal core patches for 6.13:
> >
> > https://lore.kernel.org/linux-pm/4920970.GXAFRqVoOG@rjwysocki.net/
> >
> > and
> >
> > https://lore.kernel.org/linux-pm/6100907.lOV4Wx5bFT@rjwysocki.net/
> >
> > before the 6.12 merge window, I have decided to reorder the changes included in
> > these series, so that fixes and more significant cleanups (for example, changing
> > they layout of data structures) go first, followed by the changes related to
> > using guards for locking, and the optimization involving sorted lists becomes
> > the last piece.
> >
> > This series is the first part and the majority of patches in it come from the
> > second (RFC) series mentioned above.  Of course, they needed to be rebased to
> > be applied in the new order.  It is on top of 6.12-rc1 with
> >
> > https://lore.kernel.org/linux-pm/12549318.O9o76ZdvQC@rjwysocki.net/
> >
> > applied and it will be added to my thermal-core-testing branch.  It is in v2
> > to start with because all of the patches in it have already been posted in
> > some form.
> >
> > The first 10 patches fix some potential issues related to thermal zone
> > initialization and exit (for example, user space may start to interact with
> > a thermal zone during its initialization before it's ready and system suspend
> > taking place at a wrong time may skip a new thermal zone so it is not suspended)
> > and do some cleanups related to that.  This concludes with the removal of the
> > need_update field from struct thermal_zone_device.
> >
> > The last two patches move lists of thermal instances from thermal zones to
> > trip point descriptors and clean up some code on top of that.
> >
> > Please refer to the individual patch changelogs for details.
>
> This material is now present in the thermal-core-testing and
> thermal-core-experimental branches in linux-pm.git.

I gather that it is not controversial and it has been around for quite
a while, and it was discussed during the PM+TC session at the LPC, so
I've just applied it for 6.13.

Lukasz Luba Oct. 21, 2024, 10:45 p.m. UTC | #3

Hi Rafael,

On 10/21/24 12:05, Rafael J. Wysocki wrote:
> On Fri, Oct 11, 2024 at 8:50 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>>
>> On Fri, Oct 4, 2024 at 10:11 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>>>
>>> Hi Everyone,
>>>
>>> After posting the two series of thermal core patches for 6.13:
>>>
>>> https://lore.kernel.org/linux-pm/4920970.GXAFRqVoOG@rjwysocki.net/
>>>
>>> and
>>>
>>> https://lore.kernel.org/linux-pm/6100907.lOV4Wx5bFT@rjwysocki.net/
>>>
>>> before the 6.12 merge window, I have decided to reorder the changes included in
>>> these series, so that fixes and more significant cleanups (for example, changing
>>> they layout of data structures) go first, followed by the changes related to
>>> using guards for locking, and the optimization involving sorted lists becomes
>>> the last piece.
>>>
>>> This series is the first part and the majority of patches in it come from the
>>> second (RFC) series mentioned above.  Of course, they needed to be rebased to
>>> be applied in the new order.  It is on top of 6.12-rc1 with
>>>
>>> https://lore.kernel.org/linux-pm/12549318.O9o76ZdvQC@rjwysocki.net/
>>>
>>> applied and it will be added to my thermal-core-testing branch.  It is in v2
>>> to start with because all of the patches in it have already been posted in
>>> some form.
>>>
>>> The first 10 patches fix some potential issues related to thermal zone
>>> initialization and exit (for example, user space may start to interact with
>>> a thermal zone during its initialization before it's ready and system suspend
>>> taking place at a wrong time may skip a new thermal zone so it is not suspended)
>>> and do some cleanups related to that.  This concludes with the removal of the
>>> need_update field from struct thermal_zone_device.
>>>
>>> The last two patches move lists of thermal instances from thermal zones to
>>> trip point descriptors and clean up some code on top of that.
>>>
>>> Please refer to the individual patch changelogs for details.
>>
>> This material is now present in the thermal-core-testing and
>> thermal-core-experimental branches in linux-pm.git.
> 
> I gather that it is not controversial and it has been around for quite
> a while, and it was discussed during the PM+TC session at the LPC, so
> I've just applied it for 6.13.

I hope it wasn't too late. The patch set looks good and I have
added my reviewed tags.

Regards,
Lukasz

Rafael J. Wysocki Oct. 22, 2024, 9:56 a.m. UTC | #4

Hi Lukasz,

On Tue, Oct 22, 2024 at 12:44 AM Lukasz Luba <lukasz.luba@arm.com> wrote:
>
> Hi Rafael,
>
> On 10/21/24 12:05, Rafael J. Wysocki wrote:
> > On Fri, Oct 11, 2024 at 8:50 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >>
> >> On Fri, Oct 4, 2024 at 10:11 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >>>
> >>> Hi Everyone,
> >>>
> >>> After posting the two series of thermal core patches for 6.13:
> >>>
> >>> https://lore.kernel.org/linux-pm/4920970.GXAFRqVoOG@rjwysocki.net/
> >>>
> >>> and
> >>>
> >>> https://lore.kernel.org/linux-pm/6100907.lOV4Wx5bFT@rjwysocki.net/
> >>>
> >>> before the 6.12 merge window, I have decided to reorder the changes included in
> >>> these series, so that fixes and more significant cleanups (for example, changing
> >>> they layout of data structures) go first, followed by the changes related to
> >>> using guards for locking, and the optimization involving sorted lists becomes
> >>> the last piece.
> >>>
> >>> This series is the first part and the majority of patches in it come from the
> >>> second (RFC) series mentioned above.  Of course, they needed to be rebased to
> >>> be applied in the new order.  It is on top of 6.12-rc1 with
> >>>
> >>> https://lore.kernel.org/linux-pm/12549318.O9o76ZdvQC@rjwysocki.net/
> >>>
> >>> applied and it will be added to my thermal-core-testing branch.  It is in v2
> >>> to start with because all of the patches in it have already been posted in
> >>> some form.
> >>>
> >>> The first 10 patches fix some potential issues related to thermal zone
> >>> initialization and exit (for example, user space may start to interact with
> >>> a thermal zone during its initialization before it's ready and system suspend
> >>> taking place at a wrong time may skip a new thermal zone so it is not suspended)
> >>> and do some cleanups related to that.  This concludes with the removal of the
> >>> need_update field from struct thermal_zone_device.
> >>>
> >>> The last two patches move lists of thermal instances from thermal zones to
> >>> trip point descriptors and clean up some code on top of that.
> >>>
> >>> Please refer to the individual patch changelogs for details.
> >>
> >> This material is now present in the thermal-core-testing and
> >> thermal-core-experimental branches in linux-pm.git.
> >
> > I gather that it is not controversial and it has been around for quite
> > a while, and it was discussed during the PM+TC session at the LPC, so
> > I've just applied it for 6.13.
>
> I hope it wasn't too late. The patch set looks good and I have
> added my reviewed tags.

No, it wasn't, thank you!