| Message ID | 5623410.DvuYhMxLoT@kreacher |
|---|---|
| Headers | show |
| Series | PCI: hotplug: Add checks to avoid doing hotplug on PCIe Upstream Ports | expand |
On Mon, Nov 21, 2022 at 07:13:15PM +0100, Rafael J. Wysocki wrote: > PCIe Upstream Ports are not hotplug-capable by definition, but it turns out > that in some cases, if the system is configured in a particularly interesting > way, the kernel may be made attempt to operate an Upstream Port as a hotplug > one which causes functional issues to appear. > > The following 2 patches amend the code to prevent this behavior from occurring. Both patches LGTM. The spec reference for this change is PCIe r6.0.1 sec 7.5.3.2: The Slot Implemented bit in the PCI Express Capabilities register is only valid for Downstream Ports and undefined on Upstream Ports. The Slot Capabilities / Control / Status registers are only operable if the Slot Implemented bit is valid and set. PCIe hotplug depends on those registers. (pcie_capability_reg_implemented() in drivers/pci/access.c returns false for the Slot Capabilities / Control / Status registers unless the port is a Root or Downstream Port. Reads of those registers thus always return 0.) (Root Ports are Downstream Ports per the definition of "Downstream" on page 94 of the PCIe r6.0.1 Base Spec.) Thanks, Lukas
On Mon, Nov 21, 2022 at 07:13:15PM +0100, Rafael J. Wysocki wrote: > Hi All, > > PCIe Upstream Ports are not hotplug-capable by definition, but it turns out > that in some cases, if the system is configured in a particularly interesting > way, the kernel may be made attempt to operate an Upstream Port as a hotplug > one which causes functional issues to appear. > > The following 2 patches amend the code to prevent this behavior from occurring. Thanks, applied to pci/hotplug for v6.2. Lukas, I didn't presume to convert your LGTM to Reviewed-by, but would be happy add it. Bjorn