mbox series

[V2,0/4] PM / OPP: Minor cleanups

Message ID cover.1495511998.git.viresh.kumar@linaro.org
Headers show
Series PM / OPP: Minor cleanups | expand

Message

Viresh Kumar May 23, 2017, 4:01 a.m. UTC 
Hi,

Here are few cleanup patches for the OPP core. The first two simplify
the code that was written specifically due to the limitations that we
had because of RCUs. We don't RCUs anymore and this can be simplified.

The last two take care of specific corner cases.

Rebased over pm/linux-next and tested on Exynos dual core board.

V1->V2:
- Some RBY from Stephen
- s/while/for/ for one of the loops
- Dropped a comment and fixed an error message
- opp-table marked as const in one of the place.

Viresh Kumar (4):
  PM / OPP: Reorganize _generic_set_opp_regulator()
  PM / OPP: Don't create copy of regulators unnecessarily
  PM / OPP: opp-microvolt is not optional if regulators are set
  PM / OPP: Don't create debugfs "supply-0" directory unnecessarily

 drivers/base/power/opp/core.c    | 87 +++++++++++++++++-----------------------
 drivers/base/power/opp/debugfs.c |  7 ++--
 drivers/base/power/opp/of.c      | 10 ++++-
 3 files changed, 48 insertions(+), 56 deletions(-)

-- 
2.13.0.70.g6367777092d9

Comments

Stephen Boyd May 23, 2017, 9:01 p.m. UTC | #1 
On 05/23, Viresh Kumar wrote:
> We create "supply-0" debugfs directory even if the device doesn't do

> voltage scaling. That looks confusing, as if the regulator is found but

> we never managed to get voltage levels for it.

> 

> Avoid creating such a directory unnecessarily.

> 

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

> ---


Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project