mbox series

[v2,0/2] Modify bitmap_set_value() to suppress compiler warning

Message ID cover.1607765147.git.syednwaris@gmail.com
Headers show
Series Modify bitmap_set_value() to suppress compiler warning | expand

Message

Syed Nayyar Waris Dec. 12, 2020, 9:33 a.m. UTC 
Hi All,

The purpose of this patchset is to suppress the compiler warning (-Wtype-limits).

In function bitmap_set_value(), add explicit check to see if the value being
written into the bitmap does not fall outside the bitmap.
The situation that it is falling outside is never possible in the code
because the boundaries are required to be correct before the function is
called. The responsibility is on the caller for ensuring the boundaries
are correct.
The code change is simply to silence the GCC warning messages
because GCC is not aware that the boundaries have already been checked.
As such, we're better off using __builtin_unreachable() here because we
can avoid the latency of the conditional check entirely.

Michal,
What do you think of [PATCH 2/2]? Is the conditional check needed, and also does
returning -EINVAL look good?

Changes in v2:
 - [Patch 1/2]: Squashed earlier three patches into one.

Syed Nayyar Waris (2):
  bitmap: Modify bitmap_set_value() to check bitmap length
  gpio: xilinx: Add extra check if sum of widths exceed 64

 drivers/gpio/gpio-xilinx.c | 18 ++++++++++++------
 include/linux/bitmap.h     | 35 +++++++++++++++++++++--------------
 lib/test_bitmap.c          |  4 ++--
 3 files changed, 35 insertions(+), 22 deletions(-)


base-commit: b640c4e12bbe1f0b6383c3ef788a89e5427c763f