| Message ID | cover.1706592301.git.perry.yuan@amd.com |
|---|---|
| Headers | show |
| Series | enable x86_energy_perf_policy for AMD CPU | expand |
On 1/29/2024 23:56, Perry Yuan wrote: > rename some perf strings using same definition for AMD CPPC performance > capabilities. I'm not sure I get why these need to deviate. The nomenclature is clearer for everyone this way isn't it? So why not just make the same change for everyone (IE min->lowest, max->highest, des->desired)? > > cpu0: [AMD HWP_REQ]: lowest 12 highest 166 desired 0 epp 128 window > 0x131497d0 (80*10^7us) use_pkg 89 > > cpu1: [AMD HWP_REQ]: lowest 12 highest 166 desired 0 epp 128 window > 0x131497d0 (80*10^7us) use_pkg 89 > > Signed-off-by: Perry Yuan <perry.yuan@amd.com> > --- > .../x86_energy_perf_policy.c | 23 ++++++++++++++----- > 1 file changed, 17 insertions(+), 6 deletions(-) > > diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c > index ada1aaabad8c..845cfedab06e 100644 > --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c > +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c > @@ -864,10 +864,15 @@ void print_hwp_request(int cpu, struct msr_hwp_request *h, char *str) > > if (str) > printf("%s", str); > + if (genuine_intel) > + printf("HWP_REQ: min %d max %d des %d epp %d window 0x%x (%d*10^%dus) use_pkg %d\n", > + h->hwp_min, h->hwp_max, h->hwp_desired, h->hwp_epp, > + h->hwp_window, h->hwp_window & 0x7F, (h->hwp_window >> 7) & 0x7, h->hwp_use_pkg); > + else if (authentic_amd) > + printf("[AMD HWP_REQ]: lowest %d highest %d desired %d epp %d window 0x%x (%d*10^%dus) use_pkg %d\n", > + h->hwp_min, h->hwp_max, h->hwp_desired, h->hwp_epp, > + h->hwp_window, h->hwp_window & 0x7F, (h->hwp_window >> 7) & 0x7, h->hwp_use_pkg); > > - printf("HWP_REQ: min %d max %d des %d epp %d window 0x%x (%d*10^%dus) use_pkg %d\n", > - h->hwp_min, h->hwp_max, h->hwp_desired, h->hwp_epp, > - h->hwp_window, h->hwp_window & 0x7F, (h->hwp_window >> 7) & 0x7, h->hwp_use_pkg); > } > void print_hwp_request_pkg(int pkg, struct msr_hwp_request *h, char *str) > { > @@ -876,9 +881,15 @@ void print_hwp_request_pkg(int pkg, struct msr_hwp_request *h, char *str) > if (str) > printf("%s", str); > > - printf("HWP_REQ_PKG: min %d max %d des %d epp %d window 0x%x (%d*10^%dus)\n", > - h->hwp_min, h->hwp_max, h->hwp_desired, h->hwp_epp, > - h->hwp_window, h->hwp_window & 0x7F, (h->hwp_window >> 7) & 0x7); > + if (genuine_intel) { > + printf("HWP_REQ_PKG: min %d max %d des %d epp %d window 0x%x (%d*10^%dus)\n", > + h->hwp_min, h->hwp_max, h->hwp_desired, h->hwp_epp, > + h->hwp_window, h->hwp_window & 0x7F, (h->hwp_window >> 7) & 0x7); > + } else if (authentic_amd) { > + printf("AMD HWP_REQ_PKG: lowest %d highest %d desired %d epp %d window 0x%x (%d*10^%dus)\n", > + h->hwp_min, h->hwp_max, h->hwp_desired, h->hwp_epp, > + h->hwp_window, h->hwp_window & 0x7F, (h->hwp_window >> 7) & 0x7); > + } > } > void read_hwp_request(int cpu, struct msr_hwp_request *hwp_req, unsigned int msr_offset) > {
Hi all, This patch series introduces support for the x86_energy_perf_policy utility on AMD processors that utilize the CPPC (Collaborative Processor Performance Control) interface for frequency scaling, using the amd_pstate driver module. AMD processors already support various Energy Performance Preference (EPP) profiles. With this utility, users can now seamlessly switch between these EPP profiles using the provided commands. And check the CPPC capabilities with this tool. This enhancement aims to improve power efficiency and performance management for AMD processors, providing users with more control over their system's energy-performance behavior. There are some EPP profile already support by AMD processors, user can switch EPP profile listed below with the utility commands. User can change EPP profile like this: $ sudo x86_energy_perf_policy --hwp-epp performance $ sudo x86_energy_perf_policy --hwp-epp balance-performance $ sudo x86_energy_perf_policy --hwp-epp balance_power $ sudo x86_energy_perf_policy --hwp-epp power 0 performance 128 balance_performance (default) 192 balance_power 255 power It also supports to check CPPC capabilities and change EPP profiles at runtime. $ sudo x86_energy_perf_policy cpu0: [AMD HWP_REQ]: lowest 13 highest 166 desired 0 epp 128 window 0x7829a7d0 (80*10^7us) use_pkg 87 cpu0: [AMD HWP_CAP]: low 13 lowest_non 68 nominal 77 highest 166 cpu1: [AMD HWP_REQ]: lowest 13 highest 166 desired 0 epp 128 window 0x7829a7d0 (80*10^7us) use_pkg 87 cpu1: [AMD HWP_CAP]: low 13 lowest_non 68 nominal 77 highest 166 cpu2: [AMD HWP_REQ]: lowest 13 highest 166 desired 0 epp 128 window 0x7829a7d0 (80*10^7us) use_pkg 87 cpu2: [AMD HWP_CAP]: low 13 lowest_non 68 nominal 77 highest 166 cpu3: [AMD HWP_REQ]: lowest 13 highest 166 desired 0 epp 128 window 0x7829a7d0 (80*10^7us) use_pkg 87 cpu3: [AMD HWP_CAP]: low 13 lowest_non 68 nominal 77 highest 166 cpu4: [AMD HWP_REQ]: lowest 13 highest 166 desired 0 epp 128 window 0x7829a7d0 (80*10^7us) use_pkg 87 cpu4: [AMD HWP_CAP]: low 13 lowest_non 68 nominal 77 highest 166 Your feedback and review effort are greatly appreciated! Perry. Perry Yuan (8): tools/power x86_energy_perf_policy: add info show support for AMD Pstate EPP driver tools/power x86_energy_perf_policy: enable AMD pstate EPP profile switching on MSR based system tools/power x86_energy_perf_policy: rename get_msr() and put_msr() with intel prefix tools/power x86_energy_perf_policy: rename get_cpuid_or_exit() with intel prefix tools/power x86_energy_perf_policy: add nominal and lowest nonlinear perf values showing support tools/power x86_energy_perf_policy: remove the invalid feature options for AMD processors tools/power x86_energy_perf_policy: rename some perf output strings for AMD processors tools/power x86_energy_perf_policy: change intel msr functions to be static .../x86_energy_perf_policy.c | 355 +++++++++++++----- 1 file changed, 271 insertions(+), 84 deletions(-)