From patchwork Mon Sep 21 15:47:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 53981 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by patches.linaro.org (Postfix) with ESMTPS id AD5D322B04 for ; Mon, 21 Sep 2015 15:50:46 +0000 (UTC) Received: by lanb10 with SMTP id b10sf43582700lan.3 for ; Mon, 21 Sep 2015 08:50:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=65RinrzIxAPtRmmkOyRcR00yThgOTLEA+xqVFy9G6Xo=; b=GT/705rC+FgrOJfj+USQFavzrXbi0+FCAXrJZUsewRy/FjrrrDp75O+D1MGqqPOf7f C+sGPFoFQKpZAJeJZ7vwYE0EKUwvor2LV8AWurl2UGITTGyxCLUGVIswifn1TZ6OoLlA Tzjv4AymOYDV8G1ljzi7zoR0La1fmaRqIjjo2PxnXsm6VRraeeKr/LNXXjPYqQHTVKFN dVZbBpLBsXumTSMdZmOMFZOq4ugAS4bV9aChcQQir0LoihfoKnGIoAbl7i2ByRmYpXmJ QKgqg8Nv3lhtE/YuRnXN9hqKcBAAYzqDjl+r/PwhSR3GuHs34lYhoBXvKxTfr+fOohkB hGoA== X-Gm-Message-State: ALoCoQl9iGg9Wmd6x+nlO42nM64RAKt2oBns6BJ/RI4GH1juXh9Tla3lMdqt38ZZD1/Anjt9Ov9g X-Received: by 10.152.21.42 with SMTP id s10mr3398699lae.9.1442850645112; Mon, 21 Sep 2015 08:50:45 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.6.67 with SMTP id y3ls467656lay.55.gmail; Mon, 21 Sep 2015 08:50:44 -0700 (PDT) X-Received: by 10.112.168.194 with SMTP id zy2mr7932291lbb.79.1442850644686; Mon, 21 Sep 2015 08:50:44 -0700 (PDT) Received: from mail-la0-f45.google.com (mail-la0-f45.google.com. [209.85.215.45]) by mx.google.com with ESMTPS id j6si16426957lbs.87.2015.09.21.08.50.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Sep 2015 08:50:44 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) client-ip=209.85.215.45; Received: by lagj9 with SMTP id j9so71280928lag.2 for ; Mon, 21 Sep 2015 08:50:44 -0700 (PDT) X-Received: by 10.152.21.196 with SMTP id x4mr7933875lae.86.1442850644528; Mon, 21 Sep 2015 08:50:44 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp1785228lbq; Mon, 21 Sep 2015 08:50:43 -0700 (PDT) X-Received: by 10.107.169.234 with SMTP id f103mr26129918ioj.130.1442850643313; Mon, 21 Sep 2015 08:50:43 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id rs6si8840401igb.81.2015.09.21.08.50.42; Mon, 21 Sep 2015 08:50:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933023AbbIUPui (ORCPT + 30 others); Mon, 21 Sep 2015 11:50:38 -0400 Received: from foss.arm.com ([217.140.101.70]:54051 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932180AbbIUPsY (ORCPT ); Mon, 21 Sep 2015 11:48:24 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6FF58564; Mon, 21 Sep 2015 08:48:28 -0700 (PDT) Received: from e103737-lin.cambridge.arm.com (e103737-lin.cambridge.arm.com [10.1.207.150]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CE6CF3F2E5; Mon, 21 Sep 2015 08:48:22 -0700 (PDT) From: Sudeep Holla To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sudeep Holla , Thomas Gleixner , "Rafael J. Wysocki" , Steven Miao , adi-buildroot-devel@lists.sourceforge.net Subject: [PATCH 11/17] pm: bf609: remove misuse of IRQF_NO_SUSPEND flag Date: Mon, 21 Sep 2015 16:47:07 +0100 Message-Id: <1442850433-5903-12-git-send-email-sudeep.holla@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: sudeep.holla@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The IRQF_NO_SUSPEND flag is used to identify the interrupts that should be left enabled so as to allow them to work as expected during the suspend-resume cycle, but doesn't guarantee that it will wake the system from a suspended state, enable_irq_wake is recommended to be used for the wakeup. This patch removes the use of IRQF_NO_SUSPEND flags replacing it with enable_irq_wake instead. Cc: Steven Miao Cc: adi-buildroot-devel@lists.sourceforge.net Signed-off-by: Sudeep Holla --- arch/blackfin/mach-bf609/pm.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/blackfin/mach-bf609/pm.c b/arch/blackfin/mach-bf609/pm.c index b1bfcf434d16..dab42d39b085 100644 --- a/arch/blackfin/mach-bf609/pm.c +++ b/arch/blackfin/mach-bf609/pm.c @@ -338,21 +338,22 @@ static int __init bf609_init_pm(void) GPIO_PE12, error); } - error = request_irq(irq, test_isr, IRQF_TRIGGER_RISING | IRQF_NO_SUSPEND - | IRQF_FORCE_RESUME, "gpiope12", NULL); + error = request_irq(irq, test_isr, IRQF_TRIGGER_RISING, + "gpiope12", NULL); if(error < 0) printk(KERN_DEBUG "Unable to get irq\n"); + enable_irq_wake(irq); #endif - error = request_irq(IRQ_CGU_EVT, dpm0_isr, IRQF_NO_SUSPEND | - IRQF_FORCE_RESUME, "cgu0 event", NULL); + error = request_irq(IRQ_CGU_EVT, dpm0_isr, 0, "cgu0 event", NULL); if(error < 0) printk(KERN_DEBUG "Unable to get irq\n"); + enable_irq_wake(IRQ_CGU_EVT); - error = request_irq(IRQ_DPM, dpm0_isr, IRQF_NO_SUSPEND | - IRQF_FORCE_RESUME, "dpm0 event", NULL); + error = request_irq(IRQ_DPM, dpm0_isr, 0, "dpm0 event", NULL); if (error < 0) printk(KERN_DEBUG "Unable to get irq\n"); + enable_irq_wake(IRQ_DPM); bfin_cpu_pm = &bf609_cpu_pm; return 0;