From patchwork Mon Sep 21 15:47:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 53978 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by patches.linaro.org (Postfix) with ESMTPS id E547B22B04 for ; Mon, 21 Sep 2015 15:49:12 +0000 (UTC) Received: by wicmn1 with SMTP id mn1sf32758127wic.1 for ; Mon, 21 Sep 2015 08:49:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=oVXVwrnRgDomjNvL4tQRN1xbLz5IbNlKwDuLaVkqxDM=; b=TS9lOJD879otjPSW9EMY0ZvkZ8PdU60MSoaMD9QE97BEzKt/CFjjMqCaa+UnP1QLOO OprfUEeeO8/Zyke2Hlk3qm2bLOtTeJInWw/y7itS1USrLzm/1c2PPMUUdDqLeDKO0b5L hZfW13Je4XKsi13dTyo7s8OvM44rtc0A3+zoc8FolOQ62dbeZzyp/BRlFY/yA1TKSW1u V36BCW4ZocKzJSlQRHCuArm3pI2fX2pYtZDNxx6bA2CdsIF5KxWC/G+v7eapK+mR9sN2 UvdMJzwVqfmRiDIxrTaTIHgVXO2KlgTMwczjQ3+2RmFqEKyGTaPheQZPjEa6v1WiJ/LL sRbQ== X-Gm-Message-State: ALoCoQnuaUcY6SAnV7Yx2J8ito+ffStPmd/8IXmbXbSvGawNMrKtbsMFXbpQV7mdUaCYf6Z1tTwi X-Received: by 10.112.170.67 with SMTP id ak3mr3362725lbc.6.1442850552245; Mon, 21 Sep 2015 08:49:12 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.18.137 with SMTP id w9ls488640lad.93.gmail; Mon, 21 Sep 2015 08:49:12 -0700 (PDT) X-Received: by 10.152.28.167 with SMTP id c7mr7817780lah.17.1442850552082; Mon, 21 Sep 2015 08:49:12 -0700 (PDT) Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com. [209.85.217.181]) by mx.google.com with ESMTPS id n8si16425742lbm.52.2015.09.21.08.49.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Sep 2015 08:49:12 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) client-ip=209.85.217.181; Received: by lbpo4 with SMTP id o4so53517478lbp.2 for ; Mon, 21 Sep 2015 08:49:12 -0700 (PDT) X-Received: by 10.152.37.135 with SMTP id y7mr7958323laj.106.1442850551936; Mon, 21 Sep 2015 08:49:11 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp1784531lbq; Mon, 21 Sep 2015 08:49:10 -0700 (PDT) X-Received: by 10.202.83.142 with SMTP id h136mr11462970oib.123.1442850550887; Mon, 21 Sep 2015 08:49:10 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dz6si1198848oeb.54.2015.09.21.08.49.10; Mon, 21 Sep 2015 08:49:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932955AbbIUPs5 (ORCPT + 30 others); Mon, 21 Sep 2015 11:48:57 -0400 Received: from foss.arm.com ([217.140.101.70]:54092 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932902AbbIUPse (ORCPT ); Mon, 21 Sep 2015 11:48:34 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2988C58C; Mon, 21 Sep 2015 08:48:38 -0700 (PDT) Received: from e103737-lin.cambridge.arm.com (e103737-lin.cambridge.arm.com [10.1.207.150]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8AF813F2E5; Mon, 21 Sep 2015 08:48:32 -0700 (PDT) From: Sudeep Holla To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sudeep Holla , Thomas Gleixner , "Rafael J. Wysocki" , Linus Walleij , linux-gpio@vger.kernel.org Subject: [PATCH 16/17] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag Date: Mon, 21 Sep 2015 16:47:12 +0100 Message-Id: <1442850433-5903-17-git-send-email-sudeep.holla@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: sudeep.holla@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The IRQF_NO_SUSPEND flag is used to identify the interrupts that should be left enabled so as to allow them to work as expected during the suspend-resume cycle, but doesn't guarantee that it will wake the system from a suspended state, enable_irq_wake is recommended to be used for the wakeup. This patch removes the use of IRQF_NO_SUSPEND flags replacing it with irq_set_irq_wake instead. Cc: Linus Walleij Cc: linux-gpio@vger.kernel.org Signed-off-by: Sudeep Holla --- drivers/pinctrl/pinctrl-single.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index ef04b962c3d5..a5d0f0e52de1 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -1615,12 +1615,14 @@ static void pcs_irq_unmask(struct irq_data *d) */ static int pcs_irq_set_wake(struct irq_data *d, unsigned int state) { + struct pcs_soc_data *pcs_soc = irq_data_get_irq_chip_data(d); + if (state) pcs_irq_unmask(d); else pcs_irq_mask(d); - return 0; + return irq_set_irq_wake(pcs_soc->irq, state); } /** @@ -1755,8 +1757,7 @@ static int pcs_irq_init_chained_handler(struct pcs_device *pcs, int res; res = request_irq(pcs_soc->irq, pcs_irq_handler, - IRQF_SHARED | IRQF_NO_SUSPEND | - IRQF_NO_THREAD, + IRQF_SHARED | IRQF_NO_THREAD, name, pcs_soc); if (res) { pcs_soc->irq = -1;