From patchwork Tue May 17 11:41:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 67937 Delivered-To: patches@linaro.org Received: by 10.140.92.199 with SMTP id b65csp2022080qge; Tue, 17 May 2016 04:41:47 -0700 (PDT) X-Received: by 10.112.202.164 with SMTP id kj4mr335673lbc.141.1463485307098; Tue, 17 May 2016 04:41:47 -0700 (PDT) Return-Path: Received: from mail-lb0-x231.google.com (mail-lb0-x231.google.com. [2a00:1450:4010:c04::231]) by mx.google.com with ESMTPS id m69si2184459lfb.47.2016.05.17.04.41.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 May 2016 04:41:47 -0700 (PDT) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 2a00:1450:4010:c04::231 as permitted sender) client-ip=2a00:1450:4010:c04::231; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 2a00:1450:4010:c04::231 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by mail-lb0-x231.google.com with SMTP id jj5so4866144lbc.0 for ; Tue, 17 May 2016 04:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=B0JYDVY/2dch4ncm3Rb4uhyYXJfcw1BKoDwPe1EMnOI=; b=ERqqPkfRoAq8AJqgAlIS/g9TCZ20J7DegWhvqMS2DRPeebuNfcgmh7kltdvvjmPflu 0JU97SIarEictQTbzV+UaQwL+WNOPKyKC/Jbu3P3qe4mVgfCDSf1zinNQqz6BIRR2uUi /H/gid5KuxcFmAA1QEV1kuIBQkWvT/BeNnbJQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=B0JYDVY/2dch4ncm3Rb4uhyYXJfcw1BKoDwPe1EMnOI=; b=OpGLC4aZ44aiLabYxYv90LgWrIrh71/SE9KyAaw6GFozstDgYZS3pamLq3U75dZ/f0 B5Sk4doOBhkZGPBcgamWCU6vxbLEHPhyMkSZDF0Bj8A5IK5sLS1S7f/L1TWR7mKHicx7 k42ubXLTvV7C4PKGTTyczemeqsGM3qxW7CX0ggJL/849szXEL7uuDwAHWCfwPTDBwYSn ys0+GvkmfQfbVfuxA1UAJ2KNSO4GtuFp6cz2WP/6EdGH2QMFTxBxwTXWSRLQ0MMBPsMQ 77+0rw086Uflx7pLpFEdf0Q5l9PjYRXLPd1I9476VcwK5D15wyO0P9FbOxkF1ju3t8rl dbzQ== X-Gm-Message-State: AOPr4FVlW2mu4D24klcZ4vbIbnwhvlPtHYL57aMN19NYN5WVGpQnlbqnWiU03Y5K2S6NAhnVbF8= X-Received: by 10.112.63.169 with SMTP id h9mr366884lbs.8.1463485306802; Tue, 17 May 2016 04:41:46 -0700 (PDT) Return-Path: Received: from localhost.localdomain (h-155-4-128-67.na.cust.bahnhof.se. [155.4.128.67]) by smtp.gmail.com with ESMTPSA id e187sm448752lfg.10.2016.05.17.04.41.45 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 17 May 2016 04:41:45 -0700 (PDT) From: Ulf Hansson To: "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , linux-pm@vger.kernel.org Cc: Len Brown , Pavel Machek , Geert Uytterhoeven , Lina Iyer , Axel Haslam , Marek Szyprowski , Jon Hunter , Andy Gross , Laurent Pinchart Subject: [PATCH 1/4] PM / Domains: Remove redundant call to pm_request_idle() in genpd Date: Tue, 17 May 2016 13:41:33 +0200 Message-Id: <1463485296-22742-2-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1463485296-22742-1-git-send-email-ulf.hansson@linaro.org> References: <1463485296-22742-1-git-send-email-ulf.hansson@linaro.org> The PM core increases the runtime PM usage count at the system PM prepare phase. Later when the system has resumed and the ->complete() callback has been invoked, it drops the usage count. In this way, it intentionally prevents runtime PM suspend for the device throughout this period. For this reason, let's remove the call to pm_request_idle() from within genpd's ->complete() calllback as it's redundant. Signed-off-by: Ulf Hansson --- drivers/base/power/domain.c | 1 - 1 file changed, 1 deletion(-) -- 1.9.1 diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 658eb1b..60a9971 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -938,7 +938,6 @@ static void pm_genpd_complete(struct device *dev) pm_generic_complete(dev); pm_runtime_set_active(dev); pm_runtime_enable(dev); - pm_request_idle(dev); } /**