From patchwork Mon Oct 21 10:35:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 177045 Delivered-To: patch@linaro.org Received: by 2002:a92:409a:0:0:0:0:0 with SMTP id d26csp3223946ill; Mon, 21 Oct 2019 03:35:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqzdsdC1/zijfmeNcXHsgoIXDxCEr2JLhTVJyvmSH2EQTYGig7b6Q4KMNkiAzzrzrSZHFRpF X-Received: by 2002:a17:907:10d3:: with SMTP id rv19mr20497488ejb.301.1571654159639; Mon, 21 Oct 2019 03:35:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571654159; cv=none; d=google.com; s=arc-20160816; b=PDb7B95gkPKn+ZPp7JzvgiIRO2gMdzKanJGZY8E1qA1UV5X0pZv4G4ekU1NMTrg9dJ SPNiVx31shyFcynTOsS3eqZy2hkgMueLXASRgyW/9dcqNNVhuDmxWUW0IcnNKTcI5MwG qUdZKlBJVGKskrsnsijpWAoIjz0Wf6XYI8NK/fCwnpy+lyJqdy++GfM38XN4DPD9hNzy rdazFeB4BJYinyuUXgX0LGhB7Ov1Jvjaqky6BLD5RAnD1QlqTVnfziogw0+JboAXGGvA A1Mq4uGlFuZCbnQ8Jc/biZYolqOtImvCplJgQlMPbeBnTgx2UAyHCZDzkZ7GMuYzpXlv QeiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=vKvS2rESDoy6PQiz2SnKaFwj6LTgApvN5b42XLtJTXo=; b=qdDj1FDmO5OgrVG/pMIZLIsS7uLsumS9HZCeM2EgYBeN6oYhma1665ZJ7noZvtSOdi Wr09HokTiQj322D72tMTezku5bBTcKPvVQ3qQRgHD/e5rY9WAfQ0tDp58r+9KID5Mp9O FNm/Ga1meqoGk0JKwxZGJzC3JWmOwnaGhmvR2hBcXW0wzjMTA5wWD0c5lt6MY4CnlNCV BzIk5FrW88TELrIaI/W2Erb+uHDC7uVkS+mvYQNa3QJdvQt7nwFzqz6MkqvGYQKfUZM/ Lh9T143/Nb7fQWPGSZ0KzyOLEFyM7kIA+p6HqnpSHGzdHlrbpvjXl8/Ubpx4laWWVWPa ANIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vRxWMzYJ; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d17si8759892edv.76.2019.10.21.03.35.59; Mon, 21 Oct 2019 03:35:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vRxWMzYJ; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728262AbfJUKf6 (ORCPT + 10 others); Mon, 21 Oct 2019 06:35:58 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:47081 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728260AbfJUKf5 (ORCPT ); Mon, 21 Oct 2019 06:35:57 -0400 Received: by mail-pl1-f194.google.com with SMTP id q24so6399287plr.13 for ; Mon, 21 Oct 2019 03:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=vKvS2rESDoy6PQiz2SnKaFwj6LTgApvN5b42XLtJTXo=; b=vRxWMzYJfmSP5fBSVSoLcZ1X39pHCGWkElQMy6zu8HkFuokcu0mfeAJ/UUtKqLyv+V YZS6CRMM59EUmmX2V0BrStC4nWZHeW9Jo6JQlByfl/Oda7KvXo3Z3ROpxef2xOG1RBYo fKkeckIsDBRNSC4aZCFpCxfMh55Le5ijR8n4Yq7Cv/VqgEm3SmLY+CqRpQK1K8QVBIEb UXpqXO4N/bRCQhOetk0X2G3u4G29dKtvvfvnH7Wi4SIHwyqEEoP29fXGknmf/wTaSDZ/ CJwuOAQKDUnnNw/iCvNTftcPgzQZiwDOTNgQuOmduE2smAjWcnF1Jhe9S/EqgGTzXyFK XPmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=vKvS2rESDoy6PQiz2SnKaFwj6LTgApvN5b42XLtJTXo=; b=eObJxCJYloupeQhfSiiMdXjETAh6AQuROvW42+rNU5iXbl684JQuqzZklilcuMcNVQ N+/t+LpWDlL7uuACFVdEL1ZcKyHGDELpDFPp25D1iOb7bzMbOpPvQ/48dyD5L5HFb1xT VzjdJY42ht33QIuoZzht/5QwgUdG37SepBqXREphMMgiM9+wqp7cjgwH7gjlnG8dhvzs rUz6w65S41ZBREcpTzX9kUkGcth2azMq65FdlSpUNEQ2JfZLFtRUMSQcjcCwtfFNWQmm YRx1yYdg4Ofq5a7jqusE9Xp/+3C7ZELoYM8TfDF9+UNGVAHaqSIJQjucywwc55OPR2x8 7hEQ== X-Gm-Message-State: APjAAAUPYLqP9+gcUpKo4QcSTACuX0LFPdFkiUv0WoPxtqCqiLleo1JZ gxBbZ8MKIt21TJKQvgrA1cSIlg== X-Received: by 2002:a17:902:aa91:: with SMTP id d17mr23259072plr.69.1571654156571; Mon, 21 Oct 2019 03:35:56 -0700 (PDT) Received: from localhost ([49.248.62.222]) by smtp.gmail.com with ESMTPSA id w25sm14423643pfi.60.2019.10.21.03.35.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Oct 2019 03:35:56 -0700 (PDT) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, edubezval@gmail.com, agross@kernel.org, masneyb@onstation.org, swboyd@chromium.org, julia.lawall@lip6.fr, Amit Kucheria , Daniel Lezcano , Mark Rutland , Rob Herring , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH v6 04/15] drivers: thermal: tsens: Add debugfs support Date: Mon, 21 Oct 2019 16:05:23 +0530 Message-Id: <16e39c1bbfc18b5cf6274620cd72cc63205f53a5.1571652874.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Dump some basic version info and sensor details into debugfs. Example from qcs404 below: --(/sys/kernel/debug) $ ls tsens/ 4a9000.thermal-sensor version --(/sys/kernel/debug) $ cat tsens/version 1.4.0 --(/sys/kernel/debug) $ cat tsens/4a9000.thermal-sensor/sensors max: 11 num: 10 id slope offset ------------------------ 0 3200 404000 1 3200 404000 2 3200 404000 3 3200 404000 4 3200 404000 5 3200 404000 6 3200 404000 7 3200 404000 8 3200 404000 9 3200 404000 Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd --- drivers/thermal/qcom/tsens-common.c | 83 +++++++++++++++++++++++++++++ drivers/thermal/qcom/tsens.c | 2 + drivers/thermal/qcom/tsens.h | 6 +++ 3 files changed, 91 insertions(+) -- 2.17.1 diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c index 7437bfe196e50..ea2c46cc6a66a 100644 --- a/drivers/thermal/qcom/tsens-common.c +++ b/drivers/thermal/qcom/tsens-common.c @@ -3,6 +3,7 @@ * Copyright (c) 2015, The Linux Foundation. All rights reserved. */ +#include #include #include #include @@ -139,6 +140,77 @@ int get_temp_common(struct tsens_sensor *s, int *temp) return 0; } +#ifdef CONFIG_DEBUG_FS +static int dbg_sensors_show(struct seq_file *s, void *data) +{ + struct platform_device *pdev = s->private; + struct tsens_priv *priv = platform_get_drvdata(pdev); + int i; + + seq_printf(s, "max: %2d\nnum: %2d\n\n", + priv->feat->max_sensors, priv->num_sensors); + + seq_puts(s, " id slope offset\n--------------------------\n"); + for (i = 0; i < priv->num_sensors; i++) { + seq_printf(s, "%8d %8d %8d\n", priv->sensor[i].hw_id, + priv->sensor[i].slope, priv->sensor[i].offset); + } + + return 0; +} + +static int dbg_version_show(struct seq_file *s, void *data) +{ + struct platform_device *pdev = s->private; + struct tsens_priv *priv = platform_get_drvdata(pdev); + u32 maj_ver, min_ver, step_ver; + int ret; + + if (tsens_ver(priv) > VER_0_1) { + ret = regmap_field_read(priv->rf[VER_MAJOR], &maj_ver); + if (ret) + return ret; + ret = regmap_field_read(priv->rf[VER_MINOR], &min_ver); + if (ret) + return ret; + ret = regmap_field_read(priv->rf[VER_STEP], &step_ver); + if (ret) + return ret; + seq_printf(s, "%d.%d.%d\n", maj_ver, min_ver, step_ver); + } else { + seq_puts(s, "0.1.0\n"); + } + + return 0; +} + +DEFINE_SHOW_ATTRIBUTE(dbg_version); +DEFINE_SHOW_ATTRIBUTE(dbg_sensors); + +static void tsens_debug_init(struct platform_device *pdev) +{ + struct tsens_priv *priv = platform_get_drvdata(pdev); + struct dentry *root, *file; + + root = debugfs_lookup("tsens", NULL); + if (!root) + priv->debug_root = debugfs_create_dir("tsens", NULL); + else + priv->debug_root = root; + + file = debugfs_lookup("version", priv->debug_root); + if (!file) + debugfs_create_file("version", 0444, priv->debug_root, + pdev, &dbg_version_fops); + + /* A directory for each instance of the TSENS IP */ + priv->debug = debugfs_create_dir(dev_name(&pdev->dev), priv->debug_root); + debugfs_create_file("sensors", 0444, priv->debug, pdev, &dbg_sensors_fops); +} +#else +static inline void tsens_debug_init(struct platform_device *pdev) {} +#endif + static const struct regmap_config tsens_config = { .name = "tm", .reg_bits = 32, @@ -199,6 +271,15 @@ int __init init_common(struct tsens_priv *priv) goto err_put_device; } + if (tsens_ver(priv) > VER_0_1) { + for (i = VER_MAJOR; i <= VER_STEP; i++) { + priv->rf[i] = devm_regmap_field_alloc(dev, priv->srot_map, + priv->fields[i]); + if (IS_ERR(priv->rf[i])) + return PTR_ERR(priv->rf[i]); + } + } + priv->rf[TSENS_EN] = devm_regmap_field_alloc(dev, priv->srot_map, priv->fields[TSENS_EN]); if (IS_ERR(priv->rf[TSENS_EN])) { @@ -238,6 +319,8 @@ int __init init_common(struct tsens_priv *priv) } } + tsens_debug_init(op); + return 0; err_put_device: diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index 06c6bbd69a1a7..772aa76b50e12 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -3,6 +3,7 @@ * Copyright (c) 2015, The Linux Foundation. All rights reserved. */ +#include #include #include #include @@ -176,6 +177,7 @@ static int tsens_remove(struct platform_device *pdev) { struct tsens_priv *priv = platform_get_drvdata(pdev); + debugfs_remove_recursive(priv->debug_root); if (priv->ops->disable) priv->ops->disable(priv); diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h index 84e5447c56860..00899c17e848c 100644 --- a/drivers/thermal/qcom/tsens.h +++ b/drivers/thermal/qcom/tsens.h @@ -293,6 +293,8 @@ struct tsens_context { * @feat: features of the IP * @fields: bitfield locations * @ops: pointer to list of callbacks supported by this device + * @debug_root: pointer to debugfs dentry for all tsens + * @debug: pointer to debugfs dentry for tsens controller * @sensor: list of sensors attached to this device */ struct tsens_priv { @@ -306,6 +308,10 @@ struct tsens_priv { const struct tsens_features *feat; const struct reg_field *fields; const struct tsens_ops *ops; + + struct dentry *debug_root; + struct dentry *debug; + struct tsens_sensor sensor[0]; };