From patchwork Wed Aug 12 06:57:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 52324 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f197.google.com (mail-wi0-f197.google.com [209.85.212.197]) by patches.linaro.org (Postfix) with ESMTPS id 4D79C22ED0 for ; Wed, 12 Aug 2015 06:57:30 +0000 (UTC) Received: by wicul11 with SMTP id ul11sf3444348wic.1 for ; Tue, 11 Aug 2015 23:57:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=+CMzHZm2iZEryU4aN2CIXnj2gBUDoj71jHub1fw6nFo=; b=fXWddI4GRqzYIAuwq3W+wtfQDCOPTMlU9NQjw+jrxCRxV1nD2d5b+xvkpuSETS/Wp/ 2W9rhSxxjtiQMX1SnifPsZ2PyliSUm2MPJSvqx0cQsSaYV9KjmZStUbIRYfwVKc8z65t Le6h7v8B0f52TfsHu0LAslDNZx1DNZnZP4hbH15xfijRAnMTVB4Y9DEdiXQc0mRJttjS IPUCAdeh1K/hfytITf//WsngmEAtLxFmXy5jGyeU7V0Nh+L8glbn+v/90LMVWGWhRnRP p3bK00fVy11uUfHSnN8dSsjEl9AVy5URugmd3fsqQzj5gyvvtUb0L2ANZyTziy+ecSNI OK7w== X-Gm-Message-State: ALoCoQn56F4SiyAv7TifY+RVJuNEerjssVyPne5L3IQEqfSa1byEJe+eSOZLWwH2HU6RxR6QVm+S X-Received: by 10.112.98.42 with SMTP id ef10mr9109487lbb.18.1439362649582; Tue, 11 Aug 2015 23:57:29 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.19.39 with SMTP id b7ls3099lae.85.gmail; Tue, 11 Aug 2015 23:57:29 -0700 (PDT) X-Received: by 10.112.40.51 with SMTP id u19mr30529370lbk.44.1439362649431; Tue, 11 Aug 2015 23:57:29 -0700 (PDT) Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com. [209.85.217.181]) by mx.google.com with ESMTPS id xn6si597993lbb.48.2015.08.11.23.57.29 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Aug 2015 23:57:29 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) client-ip=209.85.217.181; Received: by lbbtg9 with SMTP id tg9so4317972lbb.1 for ; Tue, 11 Aug 2015 23:57:29 -0700 (PDT) X-Received: by 10.152.5.228 with SMTP id v4mr30431283lav.36.1439362649166; Tue, 11 Aug 2015 23:57:29 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.7.198 with SMTP id l6csp127001lba; Tue, 11 Aug 2015 23:57:27 -0700 (PDT) X-Received: by 10.70.93.36 with SMTP id cr4mr717489pdb.101.1439362647059; Tue, 11 Aug 2015 23:57:27 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ni8si7927066pbc.47.2015.08.11.23.57.26; Tue, 11 Aug 2015 23:57:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752458AbbHLG5Z (ORCPT + 12 others); Wed, 12 Aug 2015 02:57:25 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:34306 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbbHLG5Z (ORCPT ); Wed, 12 Aug 2015 02:57:25 -0400 Received: by pdbfa8 with SMTP id fa8so4155564pdb.1 for ; Tue, 11 Aug 2015 23:57:24 -0700 (PDT) X-Received: by 10.70.42.110 with SMTP id n14mr30381357pdl.133.1439362644619; Tue, 11 Aug 2015 23:57:24 -0700 (PDT) Received: from localhost ([223.227.238.34]) by smtp.gmail.com with ESMTPSA id ya3sm5081980pbb.71.2015.08.11.23.57.16 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 11 Aug 2015 23:57:23 -0700 (PDT) Date: Wed, 12 Aug 2015 12:27:09 +0530 From: Viresh Kumar To: Stephen Boyd Cc: Dan Carpenter , linux-pm@vger.kernel.org Subject: Re: PM / OPP: Add clock-latency-ns support Message-ID: <20150812065709.GM32049@linux> References: <20150810163804.GA10496@mwanda> <20150811081228.GC5509@linux> <20150811135122.GL5096@mwanda> <20150811185421.GM2839@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150811185421.GM2839@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 11-08-15, 11:54, Stephen Boyd wrote: > Making it portable should be simple enough by having a temporary > variable of type u32 though. Right. @Dan: Does this look fine to you? Message-Id: <40b3ad3c99c5fe1c50d997ba5418dd602c673f13.1439362565.git.viresh.kumar@linaro.org> From: Viresh Kumar Date: Wed, 12 Aug 2015 12:20:49 +0530 Subject: [PATCH] PM / OPP: Fix static checker warning (broken 64bit big endian systems) Dan Carpenter reported (generated with static checker): drivers/base/power/opp.c:949 _opp_add_static_v2() warn: passing casted pointer '&new_opp->clock_latency_ns' to 'of_property_read_u32()' 64 vs 32. This code will break on 64 bit, big endian machines. Fix this by reading the value in a u32 type variable first and then assigning it to the unsigned long variable. Reported-by: Dan Carpenter Suggested-by: Stephen Boyd Signed-off-by: Viresh Kumar --- drivers/base/power/opp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c index 204c6c945168..a9e0af0dd9e5 100644 --- a/drivers/base/power/opp.c +++ b/drivers/base/power/opp.c @@ -918,6 +918,7 @@ static int _opp_add_static_v2(struct device *dev, struct device_node *np) struct device_opp *dev_opp; struct dev_pm_opp *new_opp; u64 rate; + u32 val; int ret; /* Hold our list modification lock here */ @@ -946,14 +947,15 @@ static int _opp_add_static_v2(struct device *dev, struct device_node *np) new_opp->np = np; new_opp->dynamic = false; new_opp->available = true; - of_property_read_u32(np, "clock-latency-ns", - (u32 *)&new_opp->clock_latency_ns); + of_property_read_u32(np, "clock-latency-ns", &val); + new_opp->clock_latency_ns = val; ret = opp_get_microvolt(new_opp, dev); if (ret) goto free_opp; - of_property_read_u32(np, "opp-microamp", (u32 *)&new_opp->u_amp); + of_property_read_u32(np, "opp-microamp", &val); + new_opp->u_amp = val; ret = _opp_add(dev, new_opp, dev_opp); if (ret)