diff mbox series

[2/3,v3] mfd: db8500-prcmu: Get rid of cpufreq dependency

Message ID 20170822131741.23473-2-linus.walleij@linaro.org
State Accepted
Commit 836a1e25dff8b23d5d54022cf84f841dae2387c7
Headers show
Series [1/3,v3] cpufreq: enable the DT cpufreq driver on the Ux500 | expand

Commit Message

Linus Walleij Aug. 22, 2017, 1:17 p.m. UTC 
The ARMSS clock, also known as the operating point of the
CPU, should not cross-depend on cpufreq like this. Move
the code to use just frequencies and remove the false
frequency (1GHz) and put in the actual frequency provided
by the ARMSS clock (998400000 Hz) as part of the process.

After this and the related cpufreq patch, the DB8500 will
simply use the standard DT cpufreq driver to change the
operating points through the common clock framework using
the ARMSS clock.

Acked-by: Lee Jones <lee.jones@linaro.org>

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
ChangeLog v2->v3:
- Fixed freq table indentation so both checkpatch and Lee
  are happy.
---
 drivers/mfd/db8500-prcmu.c | 62 ++++++++++++++++------------------------------
 1 file changed, 21 insertions(+), 41 deletions(-)

-- 
2.13.5

Comments

Rafael J. Wysocki Aug. 22, 2017, 1:25 p.m. UTC | #1 
On Tuesday, August 22, 2017 3:17:40 PM CEST Linus Walleij wrote:
> The ARMSS clock, also known as the operating point of the

> CPU, should not cross-depend on cpufreq like this. Move

> the code to use just frequencies and remove the false

> frequency (1GHz) and put in the actual frequency provided

> by the ARMSS clock (998400000 Hz) as part of the process.

> 

> After this and the related cpufreq patch, the DB8500 will

> simply use the standard DT cpufreq driver to change the

> operating points through the common clock framework using

> the ARMSS clock.

> 

> Acked-by: Lee Jones <lee.jones@linaro.org>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>


Well, I've already applied the v2, so do you want me to replace the
commit with this patch?

Thanks,
Rafael
Rafael J. Wysocki Aug. 22, 2017, 1:43 p.m. UTC | #2 
On Tuesday, August 22, 2017 3:44:18 PM CEST Linus Walleij wrote:
> On Tue, Aug 22, 2017 at 3:25 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:

> > On Tuesday, August 22, 2017 3:17:40 PM CEST Linus Walleij wrote:

> >> The ARMSS clock, also known as the operating point of the

> >> CPU, should not cross-depend on cpufreq like this. Move

> >> the code to use just frequencies and remove the false

> >> frequency (1GHz) and put in the actual frequency provided

> >> by the ARMSS clock (998400000 Hz) as part of the process.

> >>

> >> After this and the related cpufreq patch, the DB8500 will

> >> simply use the standard DT cpufreq driver to change the

> >> operating points through the common clock framework using

> >> the ARMSS clock.

> >>

> >> Acked-by: Lee Jones <lee.jones@linaro.org>

> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> >

> > Well, I've already applied the v2, so do you want me to replace the

> > commit with this patch?

> 

> If you can, else tell me and I can send a fixup patch.


I can. :-)

Done already, but the replacement will show up in linux-next when I re-merge
the branches, which may be in a few days.

> I want to keep Lee happy!


Fair enough.
Linus Walleij Aug. 22, 2017, 1:44 p.m. UTC | #3 
On Tue, Aug 22, 2017 at 3:25 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Tuesday, August 22, 2017 3:17:40 PM CEST Linus Walleij wrote:

>> The ARMSS clock, also known as the operating point of the

>> CPU, should not cross-depend on cpufreq like this. Move

>> the code to use just frequencies and remove the false

>> frequency (1GHz) and put in the actual frequency provided

>> by the ARMSS clock (998400000 Hz) as part of the process.

>>

>> After this and the related cpufreq patch, the DB8500 will

>> simply use the standard DT cpufreq driver to change the

>> operating points through the common clock framework using

>> the ARMSS clock.

>>

>> Acked-by: Lee Jones <lee.jones@linaro.org>

>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

>

> Well, I've already applied the v2, so do you want me to replace the

> commit with this patch?


If you can, else tell me and I can send a fixup patch.

I want to keep Lee happy!

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index 5c739ac752e8..5970b8def548 100644
--- a/drivers/mfd/db8500-prcmu.c
+++ b/drivers/mfd/db8500-prcmu.c
@@ -33,7 +33,6 @@ 
 #include <linux/mfd/abx500/ab8500.h>
 #include <linux/regulator/db8500-prcmu.h>
 #include <linux/regulator/machine.h>
-#include <linux/cpufreq.h>
 #include <linux/platform_data/ux500_wdt.h>
 #include <linux/platform_data/db8500_thermal.h>
 #include "dbx500-prcmu-regs.h"
@@ -1692,32 +1691,27 @@  static long round_clock_rate(u8 clock, unsigned long rate)
 	return rounded_rate;
 }
 
-/* CPU FREQ table, may be changed due to if MAX_OPP is supported. */
-static struct cpufreq_frequency_table db8500_cpufreq_table[] = {
-	{ .frequency = 200000, .driver_data = ARM_EXTCLK,},
-	{ .frequency = 400000, .driver_data = ARM_50_OPP,},
-	{ .frequency = 800000, .driver_data = ARM_100_OPP,},
-	{ .frequency = CPUFREQ_TABLE_END,}, /* To be used for MAX_OPP. */
-	{ .frequency = CPUFREQ_TABLE_END,},
+static const unsigned long armss_freqs[] = {
+	200000000,
+	400000000,
+	800000000,
+	998400000
 };
 
 static long round_armss_rate(unsigned long rate)
 {
-	struct cpufreq_frequency_table *pos;
-	long freq = 0;
-
-	/* cpufreq table frequencies is in KHz. */
-	rate = rate / 1000;
+	unsigned long freq = 0;
+	int i;
 
 	/* Find the corresponding arm opp from the cpufreq table. */
-	cpufreq_for_each_entry(pos, db8500_cpufreq_table) {
-		freq = pos->frequency;
-		if (freq == rate)
+	for (i = 0; i < ARRAY_SIZE(armss_freqs); i++) {
+		freq = armss_freqs[i];
+		if (rate <= freq)
 			break;
 	}
 
 	/* Return the last valid value, even if a match was not found. */
-	return freq * 1000;
+	return freq;
 }
 
 #define MIN_PLL_VCO_RATE 600000000ULL
@@ -1854,21 +1848,23 @@  static void set_clock_rate(u8 clock, unsigned long rate)
 
 static int set_armss_rate(unsigned long rate)
 {
-	struct cpufreq_frequency_table *pos;
-
-	/* cpufreq table frequencies is in KHz. */
-	rate = rate / 1000;
+	unsigned long freq;
+	u8 opps[] = { ARM_EXTCLK, ARM_50_OPP, ARM_100_OPP, ARM_MAX_OPP };
+	int i;
 
 	/* Find the corresponding arm opp from the cpufreq table. */
-	cpufreq_for_each_entry(pos, db8500_cpufreq_table)
-		if (pos->frequency == rate)
+	for (i = 0; i < ARRAY_SIZE(armss_freqs); i++) {
+		freq = armss_freqs[i];
+		if (rate == freq)
 			break;
+	}
 
-	if (pos->frequency != rate)
+	if (rate != freq)
 		return -EINVAL;
 
 	/* Set the new arm opp. */
-	return db8500_prcmu_set_arm_opp(pos->driver_data);
+	pr_debug("SET ARM OPP 0x%02x\n", opps[i]);
+	return db8500_prcmu_set_arm_opp(opps[i]);
 }
 
 static int set_plldsi_rate(unsigned long rate)
@@ -3049,12 +3045,6 @@  static const struct mfd_cell db8500_prcmu_devs[] = {
 		.pdata_size = sizeof(db8500_regulators),
 	},
 	{
-		.name = "cpufreq-ux500",
-		.of_compatible = "stericsson,cpufreq-ux500",
-		.platform_data = &db8500_cpufreq_table,
-		.pdata_size = sizeof(db8500_cpufreq_table),
-	},
-	{
 		.name = "cpuidle-dbx500",
 		.of_compatible = "stericsson,cpuidle-dbx500",
 	},
@@ -3067,14 +3057,6 @@  static const struct mfd_cell db8500_prcmu_devs[] = {
 	},
 };
 
-static void db8500_prcmu_update_cpufreq(void)
-{
-	if (prcmu_has_arm_maxopp()) {
-		db8500_cpufreq_table[3].frequency = 1000000;
-		db8500_cpufreq_table[3].driver_data = ARM_MAX_OPP;
-	}
-}
-
 static int db8500_prcmu_register_ab8500(struct device *parent)
 {
 	struct device_node *np;
@@ -3160,8 +3142,6 @@  static int db8500_prcmu_probe(struct platform_device *pdev)
 
 	prcmu_config_esram0_deep_sleep(ESRAM0_DEEP_SLEEP_STATE_RET);
 
-	db8500_prcmu_update_cpufreq();
-
 	err = mfd_add_devices(&pdev->dev, 0, common_prcmu_devs,
 			      ARRAY_SIZE(common_prcmu_devs), NULL, 0, db8500_irq_domain);
 	if (err) {