From patchwork Wed Jun 20 17:22:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 139379 Delivered-To: patches@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp1050656lji; Wed, 20 Jun 2018 10:22:55 -0700 (PDT) X-Received: by 2002:a2e:9e57:: with SMTP id g23-v6mr14201318ljk.14.1529515375112; Wed, 20 Jun 2018 10:22:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529515375; cv=none; d=google.com; s=arc-20160816; b=vHIz9Ymxg6LVROigpH/hrIf5hAcFXRAWrPyCUTERHfCnZWv8gnRy0RYVFep/uxY+lf 0KS1Z8yOcIkJE5NsfbwZkp7ROh8uX3+0SWUeaJTI8dyNWNZgwvde0UEBmfE12G988Bz+ jYJSoSIIcxkQYkeKSh7Ew695HFgAVKeJziMLgSAJdB/SBtcNhBcyrme09xWhRIr0zeqD EU5OvpPhIh6ZJU4vnw5RU2f84jQfGfz4uywHYbd/HyNuO/4qal+LxUdNS16fLJtSffBY i8/TIZCJyGFUlVM5UbMghRhslA2OqK4PXm4a++1E8kWpBoGTOMkp3/pC0C9gDpeKHin+ f9vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=AMylSCkbzgDhVGAqXW5br7EGPsh0M0aMkU36t/fhU+E=; b=FgcV7OaLW4XVpnj2SwyNSpqEYYSM9MyscDfwJqh79oFxdWAoYa0ovXBsbPnKOKUBnh chu6gvclgjjo39EJbfWIVuPWzQ+fnBZJfh3RS2X8xz5a5n683E98equICRqrVj9rdhdS RoWwq46nG82EbrbnHecY85GWTIYjQ5X+3SKpT4Uw9iAc1KAaR7RNBFKF9WgBJP1DJF8D QsgV+9xtACydyONtjfABdH1uDu293nsCBm5ik83aTsiGYxs0JEbe864j3H+zKUer8sFz zebhyXZMV+8DEUermYn7FcgdmFJ6lKvm8WaAS7NxvYFV+PHFHD0jbfgCgBM4Fd6idDRX FYrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SKGWxFzG; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id p21-v6sor698179ljh.91.2018.06.20.10.22.55 for (Google Transport Security); Wed, 20 Jun 2018 10:22:55 -0700 (PDT) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SKGWxFzG; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AMylSCkbzgDhVGAqXW5br7EGPsh0M0aMkU36t/fhU+E=; b=SKGWxFzGSktnyD6kaX9ouo+P/jXcqpXVh7WmiipKR4mu8eL4DLn1dlzEuJ1UVq8Isf nHglT92pBOG4HoKUm0EsljQ8CMQHU/y/4uqGOUybUW/3pWPBLcIG8lCYhELSWFIusRTq VjDEfxFljyJQu7hsl5Egey8JJ52Ttelgdra2Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AMylSCkbzgDhVGAqXW5br7EGPsh0M0aMkU36t/fhU+E=; b=gN/9hKf6HVeQsSOwJ5piJYZittCU5ezQ4dagoocMyvSkmFp5NRcreJ/nX8M249n83N Po1hBCKkNWldVVGUmxNwFLlm7hCxyVTMm86BGUvOc2y8Gj60NuRJVC2pzR3K5Mu8ocWi ikppv8er0gHthsv9aLzEhznaUqHZEL5Y2JlMj6cqLb1uKUriGAIZVnTXl71kH48Qy9vw EJ2e+Jm+SoC0apk37uPcc4b0I/XyPp5G9xgZZZd6pOahAe83dqJx+2obZNRcd/3LEFB1 jeOkOvVB/WhLqLmbxgm3wkuP6koBDbZwmCpG8BtfgAJJeGlp9tHzWbhommLTaQje/uKe vt/g== X-Gm-Message-State: APt69E3kg2XxxQj2aXODetEoSY1f/KoUISUmyDaWc0P3b98+27GGKkOB oF+BpjT/tBZmfou6fl4tcbAglmyX X-Google-Smtp-Source: ADUXVKKw7oTkqAeuPRf8L9aMhza1orF6pS8GahQhO/Ol4QGWHx/duUSlOEM0HX43isb6GIHcjbqMPQ== X-Received: by 2002:a2e:870d:: with SMTP id m13-v6mr14276282lji.139.1529515374905; Wed, 20 Jun 2018 10:22:54 -0700 (PDT) Return-Path: Received: from localhost.localdomain (h-158-174-22-210.NA.cust.bahnhof.se. [158.174.22.210]) by smtp.gmail.com with ESMTPSA id b2-v6sm514441lji.85.2018.06.20.10.22.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jun 2018 10:22:54 -0700 (PDT) From: Ulf Hansson To: "Rafael J . Wysocki" , Sudeep Holla , Lorenzo Pieralisi , Mark Rutland , linux-pm@vger.kernel.org Cc: Kevin Hilman , Lina Iyer , Lina Iyer , Ulf Hansson , Rob Herring , Daniel Lezcano , Thomas Gleixner , Vincent Guittot , Stephen Boyd , Juri Lelli , Geert Uytterhoeven , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v8 11/26] of: base: Add of_get_cpu_state_node() to get idle states for a CPU node Date: Wed, 20 Jun 2018 19:22:11 +0200 Message-Id: <20180620172226.15012-12-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180620172226.15012-1-ulf.hansson@linaro.org> References: <20180620172226.15012-1-ulf.hansson@linaro.org> The CPU's idle state nodes are currently parsed at the common cpuidle DT library, but also when initializing back-end data for the arch specific CPU operations, as in the PSCI driver case. To avoid open-coding, let's introduce of_get_cpu_state_node(), which takes the device node for the CPU and the index to the requested idle state node, as in-parameters. In case a corresponding idle state node is found, it returns the node with the refcount incremented for it, else it returns NULL. Moreover, for ARM, there are two generic methods, to describe the CPU's idle states, either via the flattened description through the "cpu-idle-states" binding [1] or via the hierarchical layout, using the "power-domains" and the "domain-idle-states" bindings [2]. Hence, let's take both options into account. [1] Documentation/devicetree/bindings/arm/idle-states.txt [2] Documentation/devicetree/bindings/arm/psci.txt Cc: Rob Herring Cc: devicetree@vger.kernel.org Cc: Lina Iyer Suggested-by: Sudeep Holla Co-developed-by: Lina Iyer Signed-off-by: Ulf Hansson Reviewed-by: Rob Herring --- drivers/of/base.c | 35 +++++++++++++++++++++++++++++++++++ include/linux/of.h | 8 ++++++++ 2 files changed, 43 insertions(+) -- 2.17.1 diff --git a/drivers/of/base.c b/drivers/of/base.c index 848f549164cd..97350cce1b8e 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -399,6 +399,41 @@ int of_cpu_node_to_id(struct device_node *cpu_node) } EXPORT_SYMBOL(of_cpu_node_to_id); +/** + * of_get_cpu_state_node - Get CPU's idle state node at the given index + * + * @cpu_node: The device node for the CPU + * @index: The index in the list of the idle states + * + * Two generic methods can be used to describe a CPU's idle states, either via + * a flattened description through the "cpu-idle-states" binding or via the + * hierarchical layout, using the "power-domains" and the "domain-idle-states" + * bindings. This function check for both and returns the idle state node for + * the requested index. + * + * In case and idle state node is found at index, the refcount incremented for + * it, so call of_node_put() on it when done. Returns NULL if not found. + */ +struct device_node *of_get_cpu_state_node(struct device_node *cpu_node, + int index) +{ + struct of_phandle_args args; + int err; + + err = of_parse_phandle_with_args(cpu_node, "power-domains", + "#power-domain-cells", 0, &args); + if (!err) { + struct device_node *state_node = + of_parse_phandle(args.np, "domain-idle-states", index); + + of_node_put(args.np); + return state_node; + } + + return of_parse_phandle(cpu_node, "cpu-idle-states", index); +} +EXPORT_SYMBOL(of_get_cpu_state_node); + /** * __of_device_is_compatible() - Check if the node matches given constraints * @device: pointer to node diff --git a/include/linux/of.h b/include/linux/of.h index 4d25e4f952d9..15072b10ef4d 100644 --- a/include/linux/of.h +++ b/include/linux/of.h @@ -348,6 +348,8 @@ extern const void *of_get_property(const struct device_node *node, const char *name, int *lenp); extern struct device_node *of_get_cpu_node(int cpu, unsigned int *thread); +extern struct device_node *of_get_cpu_state_node(struct device_node *cpu_node, + int index); #define for_each_property_of_node(dn, pp) \ for (pp = dn->properties; pp != NULL; pp = pp->next) @@ -733,6 +735,12 @@ static inline struct device_node *of_get_cpu_node(int cpu, return NULL; } +static inline struct device_node *of_get_cpu_state_node(struct device_node *cpu_node, + int index) +{ + return NULL; +} + static inline int of_n_addr_cells(struct device_node *np) { return 0;