diff mbox series

[V2,1/6] dt-bindings: serial: fsl-imx-uart: add missing properties

Message ID 20230410205803.45853-2-stefan.wahren@i2se.com
State New
Headers show
Series ARM: dts: imx6ull: Fix dtbs_check warnings | expand

Commit Message

Stefan Wahren April 10, 2023, 8:57 p.m. UTC 
Currently the dtbs_check for imx generates warnings like this:

serial@7000c000: Unevaluated properties are not allowed
('clock-names', 'clocks', 'dma-names', 'dmas' were unexpected)

So add the missing properties to the devicetree binding.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 .../bindings/serial/fsl-imx-uart.yaml         | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)

Comments

Krzysztof Kozlowski April 11, 2023, 5:46 a.m. UTC | #1 
On 10/04/2023 22:57, Stefan Wahren wrote:
> Currently the dtbs_check for imx generates warnings like this:
> 
> serial@7000c000: Unevaluated properties are not allowed
> ('clock-names', 'clocks', 'dma-names', 'dmas' were unexpected)
> 
> So add the missing properties to the devicetree binding.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
index 4cbe76e1715b..06f4b02b0550 100644
--- a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
@@ -52,6 +52,24 @@  properties:
   interrupts:
     maxItems: 1
 
+  clocks:
+    items:
+      - description: ipg clock
+      - description: per clock
+
+  clock-names:
+    items:
+      - const: ipg
+      - const: per
+
+  dmas:
+    maxItems: 2
+
+  dma-names:
+    items:
+      - const: rx
+      - const: tx
+
   fsl,dte-mode:
     $ref: /schemas/types.yaml#/definitions/flag
     description: |
@@ -87,11 +105,15 @@  required:
   - compatible
   - reg
   - interrupts
+  - clocks
+  - clock-names
 
 unevaluatedProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/imx5-clock.h>
+
     aliases {
         serial0 = &uart1;
     };
@@ -100,6 +122,9 @@  examples:
         compatible = "fsl,imx51-uart", "fsl,imx21-uart";
         reg = <0x73fbc000 0x4000>;
         interrupts = <31>;
+        clocks = <&clks IMX5_CLK_UART1_IPG_GATE>,
+                 <&clks IMX5_CLK_UART1_PER_GATE>;
+        clock-names = "ipg", "per";
         uart-has-rtscts;
         fsl,dte-mode;
     };