| Message ID | 20240820055705.3922754-4-quic_varada@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Enable CPR for IPQ9574 | expand |
On Tue, Aug 20, 2024 at 11:27:01AM GMT, Varadarajan Narayanan wrote: > Add the bindings for the IPQ9574 CPR3 driver to the documentation. Bindings are for the hardware, not for the driver. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > v5: Add Reviewed-by > > v4: Change compatible string to cpr4 instead of cprh > Not adding Reviewed-By as compatible string changed I still see that it is being declared as compatible with qcom,cprh, while your hardware isn't CPRh, it's CPR4. > > v2: Constrained nvmem-cells and the other variant. > Removed unnecessary blank line. > --- > .../bindings/soc/qcom/qcom,cpr3.yaml | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml > index 2e6712aa1c58..c00373948901 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml > @@ -24,6 +24,7 @@ properties: > - const: qcom,cpr4 > - items: > - enum: > + - qcom,ipq9574-cpr4 > - qcom,msm8998-cprh > - qcom,sdm630-cprh > - const: qcom,cprh
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml index 2e6712aa1c58..c00373948901 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml @@ -24,6 +24,7 @@ properties: - const: qcom,cpr4 - items: - enum: + - qcom,ipq9574-cpr4 - qcom,msm8998-cprh - qcom,sdm630-cprh - const: qcom,cprh @@ -52,9 +53,11 @@ properties: nvmem-cells: description: Cells containing the fuse corners and revision data + minItems: 17 maxItems: 32 nvmem-cell-names: + minItems: 17 maxItems: 32 operating-points-v2: true @@ -74,6 +77,36 @@ required: additionalProperties: false allOf: + - if: + properties: + compatible: + contains: + enum: + - qcom,ipq9574-cpr4 + then: + properties: + nvmem-cells: + maxItems: 17 + nvmem-cell-names: + items: + - const: cpr_speed_bin + - const: cpr_fuse_revision + - const: cpr0_quotient1 + - const: cpr0_quotient2 + - const: cpr0_quotient3 + - const: cpr0_quotient4 + - const: cpr0_quotient_offset2 + - const: cpr0_quotient_offset3 + - const: cpr0_quotient_offset4 + - const: cpr0_init_voltage1 + - const: cpr0_init_voltage2 + - const: cpr0_init_voltage3 + - const: cpr0_init_voltage4 + - const: cpr0_ring_osc1 + - const: cpr0_ring_osc2 + - const: cpr0_ring_osc3 + - const: cpr0_ring_osc4 + - if: properties: compatible: @@ -82,6 +115,8 @@ allOf: - qcom,msm8998-cprh then: properties: + nvmem-cells: + minItems: 32 nvmem-cell-names: items: - const: cpr_speed_bin