From patchwork Mon Apr 14 20:41:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rafael J. Wysocki" X-Patchwork-Id: 881604 Received: from cloudserver094114.home.pl (cloudserver094114.home.pl [79.96.170.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4238A1F3B8A; Mon, 14 Apr 2025 20:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.96.170.134 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744663964; cv=none; b=ssVwYIimYSTb9Ijd9fWSpiBELcJJFCX225mQPq4+vpqyl5aeWUJYZFR/yKK0oUknQ0eH0mk+NV1S9UKgCIxOeR3aNFrScqcOFdelEGsS3cEWBI0YLmQtNIvAXGDUjsFRWDdWmu8F2BHDGDlmlECWDkthP+VtP2FmoDaXl++Djvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744663964; c=relaxed/simple; bh=XlkGXxzoA+hEjJubrQTH3D1wqONB8G+bZQDNafTAF90=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Zs2fwNFemp+QVrqPrW2w8Qjtc5ZPo7Ovx07/eoqcF1PIgdtYHznjxUpU+inpgNO9q6DeoAROaqXYSnQUWuTES0D+RkosslVafOfTtyQJXM3uGfPmR0T6LXPTqdDjiTBy6O8+vQ1aJTKCrnmSo0dQT3XE1vUChFDtQWBceRX9uzY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net; spf=pass smtp.mailfrom=rjwysocki.net; dkim=pass (2048-bit key) header.d=rjwysocki.net header.i=@rjwysocki.net header.b=VF0ZJye9; arc=none smtp.client-ip=79.96.170.134 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rjwysocki.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rjwysocki.net header.i=@rjwysocki.net header.b="VF0ZJye9" Received: from kreacher.localnet (unknown [195.136.19.94]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by cloudserver094114.home.pl (Postfix) with ESMTPSA id 1FC696625E0; Mon, 14 Apr 2025 22:52:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rjwysocki.net; s=dkim; t=1744663955; bh=XlkGXxzoA+hEjJubrQTH3D1wqONB8G+bZQDNafTAF90=; h=From:Subject:Date; b=VF0ZJye9yKwpNPlPvYAf8iPaeV01050/exUmhCSFSiSySwCUr/KW0MlMDd4CtwTFA ffy4nfbQ5qexAHXTzg/PpOOCi9+qd+us6RwD1AWYS9mavbgVigmLefBU4ZDKJ6ZjZv npxp2mtAzdmBZxw1bmUaH11nlKBRdc1bh3t1lSFzUWrmi7V/e4K9klq15ziyqeZ7Sl +C51CCj1hBDeP9R+8/GYj8b79nu0FNGUuf1wp/BOzsnbBN2OM+bI7BcOBtmiYgnAh7 NQZQ5ZPE7GSvE1ehj0SwsH35rL1vy7b+wkn4tyZ6hI58StVUJg28SMVMcSpWC0jS5p 1NWv59hsaO7Hg== From: "Rafael J. Wysocki" To: Linux PM Cc: LKML , Viresh Kumar , Srinivas Pandruvada , Mario Limonciello , Vincent Guittot , Christian Loehle , Sultan Alsawaf , Peter Zijlstra , Valentin Schneider , Ingo Molnar Subject: [PATCH v1 1/5] cpufreq/sched: Check fast_switch_enabled when setting need_freq_update Date: Mon, 14 Apr 2025 22:41:32 +0200 Message-ID: <8533207.T7Z3S40VBb@rjwysocki.net> In-Reply-To: <3364921.aeNJFYEL58@rjwysocki.net> References: <3364921.aeNJFYEL58@rjwysocki.net> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CLIENT-IP: 195.136.19.94 X-CLIENT-HOSTNAME: 195.136.19.94 X-VADE-SPAMSTATE: clean X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvvdduheeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecujffqoffgrffnpdggtffipffknecuuegrihhlohhuthemucduhedtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpedftfgrfhgrvghlucflrdcuhgihshhotghkihdfuceorhhjfiesrhhjfiihshhotghkihdrnhgvtheqnecuggftrfgrthhtvghrnhepfeduudeutdeugfelffduieegiedtueefledvjeegffdttefhhffhtefhleejgfetnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepudelhedrudefiedrudelrdelgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduleehrddufeeirdduledrleegpdhhvghlohepkhhrvggrtghhvghrrdhlohgtrghlnhgvthdpmhgrihhlfhhrohhmpehrjhifsehrjhifhihsohgtkhhirdhnvghtpdhnsggprhgtphhtthhopeduuddprhgtphhtthhopehlihhnuhigqdhpmhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehvihhrvghshhdrkhhumhgrrheslhhinhgrrhhordhorhhgpdhrtghpthhtohepshhrihhnihhvrghsrdhprghnughruhhvrggurgeslhhinhhugidrihhnthgvlhd X-DCC--Metrics: v370.home.net.pl 1024; Body=11 Fuz1=11 Fuz2=11 From: Rafael J. Wysocki Commit 8e461a1cb43d ("cpufreq: schedutil: Fix superfluous updates caused by need_freq_update") overlooked the fact that when fast swtching is enabled, it is the only way to pick up new policy limits and so need_freq_update needs to be set in that case when limits_changed is set. This causes policy limits updates to be missed in some cases, so make sugov_should_update_freq() also set need_freq_update when the fast_switch_enabled policy flag is set. Fixes: 8e461a1cb43d ("cpufreq: schedutil: Fix superfluous updates caused by need_freq_update") Closes: https://lore.kernel.org/lkml/Z_Tlc6Qs-tYpxWYb@linaro.org/ Reported-by: Stephan Gerhold Signed-off-by: Rafael J. Wysocki --- kernel/sched/cpufreq_schedutil.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -83,7 +83,9 @@ if (unlikely(sg_policy->limits_changed)) { sg_policy->limits_changed = false; - sg_policy->need_freq_update = cpufreq_driver_test_flags(CPUFREQ_NEED_UPDATE_LIMITS); + sg_policy->need_freq_update = + sg_policy->policy->fast_switch_enabled || + cpufreq_driver_test_flags(CPUFREQ_NEED_UPDATE_LIMITS); return true; }