| Message ID | 1485345031-2948-1-git-send-email-m.szyprowski@samsung.com |
|---|---|
| Headers | show |
| Series | Pad retentions support for Exynos5433 | expand |
On Wed, Jan 25, 2017 at 12:50:28PM +0100, Marek Szyprowski wrote: > Exynos5433 LPASS module requires some clocks for proper operation with > power domain. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > index 57c7bbeb65a7..16072c1c3ed3 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > @@ -1494,6 +1494,8 @@ > audio-subsystem@11400000 { > compatible = "samsung,exynos5433-lpass"; > reg = <0x11400000 0x100>, <0x11500000 0x08>; > + clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>; > + clock-names = "sfr0_ctrl"; You wrote that 6/7 depends on this. I prefer not to take DTS changes if the corresponding user (driver) is still under discussion because the bindings might change. I'll take it when bindings got acked or accepted. BTW, the 6/7 is a quite reasonable ABI break, but for the sake of documentation - why you did not continue with the patch for marking bidings as experimental/under-development? Best regards, Krzysztof > samsung,pmu-syscon = <&pmu_system_controller>; > #address-cells = <1>; > #size-cells = <1>; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Krzysztof, On 2017-01-25 20:50, Krzysztof Kozlowski wrote: > On Wed, Jan 25, 2017 at 12:50:28PM +0100, Marek Szyprowski wrote: >> Exynos5433 LPASS module requires some clocks for proper operation with >> power domain. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >> --- >> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> index 57c7bbeb65a7..16072c1c3ed3 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> @@ -1494,6 +1494,8 @@ >> audio-subsystem@11400000 { >> compatible = "samsung,exynos5433-lpass"; >> reg = <0x11400000 0x100>, <0x11500000 0x08>; >> + clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>; >> + clock-names = "sfr0_ctrl"; > You wrote that 6/7 depends on this. I prefer not to take DTS changes if > the corresponding user (driver) is still under discussion because the > bindings might change. I'll take it when bindings got acked or accepted. Well, audio support in 4.9 is still not functional due to missing other patches to ALSA SoC, so nothing will break as for now if we manage to get this into v4.10. > BTW, the 6/7 is a quite reasonable ABI break, but for the sake of > documentation - why you did not continue with the patch for marking > bidings as experimental/under-development? Because I had no time to list all breaks, what was requested by Rob. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello, This patchset is a first step to add support for all power domains on Exynos5433 SoCs. This patchset contains patches for Exynos pin control driver and Exynos LPASS MFD driver, which are needed to make the platform ready for adding power domains support. Patches in this patchset depends on each other. They are order in such a way to make the changes bisectable. Patch #3 has runtime dependency on #1. Patch #5 has runtime dependency on #3. Patch #6 has runtime dependency on #4. This patchset also directly depends on the "Move pad retention control to Exynos pin controller driver" patchset: https://www.spinics.net/lists/arm-kernel/msg556074.html Patches have been generated on top of linux-next from 25th January 2017. This is a part of a larger task, which goal is to add support for power domains on Exynos5433 SoCs / TM2 boards. All patches needed to get it working have been pushed to the following git repo: https://git.linaro.org/people/marek.szyprowski/linux-srpol.git v4.10-next-tm2-pd Best regards Marek Szyprowski Samsung R&D Institute Poland Patch summary: Marek Szyprowski (7): soc: samsung: pmu: Add dummy support for Exynos5433 SoC pinctrl: samsung: Ensure that pad retention is disabled on driver init pinctrl: samsung: Add support for pad retention control for Exynos5433 SoCs arm64: dts: exynos: Add clocks to Exynos5433 LPASS module mfd: exynos-lpass: Remove pad retention control mfd: exynos-lpass: Add support for clocks mfd: exynos-lpass: Add runtime PM support .../bindings/mfd/samsung,exynos5433-lpass.txt | 8 ++- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 + drivers/mfd/exynos-lpass.c | 35 ++++++------ drivers/pinctrl/samsung/pinctrl-exynos.c | 63 ++++++++++++++++++++++ drivers/soc/samsung/exynos-pmu.c | 4 +- include/linux/mfd/syscon/exynos5-pmu.h | 3 -- include/linux/soc/samsung/exynos-regs-pmu.h | 19 +++++++ 7 files changed, 110 insertions(+), 24 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html