mbox series

[v2,0/2] Exynos5250: Fix suspend/resume support

Message ID 20180807104757eucas1p201bd787714f50a798ee7457bdaf2c2f9~IlG8LJVcj1319313193eucas1p2R@eucas1p2.samsung.com
Headers show
Series Exynos5250: Fix suspend/resume support | expand

Message

Marek Szyprowski Aug. 7, 2018, 10:47 a.m. UTC 
Hi All,

Exynos5250 uses generic cpufreq-dt driver since v4.3 kernel release. This
change however broke suspend/resume support if cpufreq support is enabled,
because CPU boots at 1GHz after suspend/resume cycle, what needs proper
configuration of CPU voltage regulators.

Previously used exynos-cpufreq driver stored initial boot CPU operation
point and switched to it for the suspend/resume cycle. To achieve similar
result with generic cpufreq-dt driver, the 1GHz operation point has to be
specially marked as 'suspend opp'. This is possible only in v2 of the OPP
bindings, so convert exynos5250.dtsi first to the newer version of the
binding.

Best regards
Marek Szyprowski


Changelog:
v2:
- added cc-stable, reviewed-by and acked-by tags

Patch summary:

Marek Szyprowski (2):
  ARM: dts: exynos: Convert exynos5250.dtsi to opp-v2 bindings
  ARM: dts: exynos: Mark 1GHz CPU OPP as suspend OPP

 arch/arm/boot/dts/exynos5250.dtsi | 131 ++++++++++++++++++++----------
 1 file changed, 89 insertions(+), 42 deletions(-)

-- 
2.17.1

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Krzysztof Kozlowski Aug. 29, 2018, 7:32 p.m. UTC | #1 
On Tue, Aug 07, 2018 at 12:48:49PM +0200, Marek Szyprowski wrote:
> 1GHz CPU OPP is the default boot value for the Exynos5250 SOC, so mark it

> as suspend OPP. This fixes suspend/resume on Samsung Exynos5250 Snow

> Chomebook, which was broken since switching to generic cpufreq-dt driver

> in v4.3.

> 

> CC: <stable@vger.kernel.org> # 4.3.x: cd6f55457eb4  ARM: dts: exynos: Remove "cooling-{min|max}-level" for CPU nodes

> CC: <stable@vger.kernel.org> # 4.3.x: 672f33198bee  arm: dts: exynos: Add missing cooling device properties for CPUs

> CC: <stable@vger.kernel.org> # 4.3.x

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

> ---

>  arch/arm/boot/dts/exynos5250.dtsi | 1 +

>  1 file changed, 1 insertion(+)


Thanks, applied.

Best regards,
Krzysztof