| Message ID | 20241024-exynos9810-v1-0-ed14d0d60d08@gmail.com |
|---|---|
| Headers | show |
| Series | Add support for Exynos9810 SoC and Samsung Galaxy S9 (SM-G960F) | expand |
On 10/24/24 01:36, Markuss Broks wrote: > Exynos 9810 is an ARMv8 mobile SoC found in various Samsung devices, > such as Samsung Galaxy S9 (starlte), S9 Plus (star2lte), > Note 9 (crownlte) and perhaps others. > > Add minimal support for this SoC, including basic stuff like: > - PSCI for bringing up secondary cores > - ARMv8 generic timer > - GPIO and pinctrl. > > The firmware coming with the devices based on this SoC is buggy > and doesn't configure CNTFRQ_EL0, as required by spec, so it's > needed to hardcode the frequency in the timer node. > > Co-authored-by: Maksym Holovach <nergzd@nergzd723.xyz> > Signed-off-by: Markuss Broks <markuss.broks@gmail.com> > --- > arch/arm64/boot/dts/exynos/exynos9810-pinctrl.dtsi | 525 +++++++++++++++++++++ > arch/arm64/boot/dts/exynos/exynos9810.dtsi | 256 ++++++++++ > 2 files changed, 781 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos9810-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos9810-pinctrl.dtsi > new file mode 100644 > index 0000000000000000000000000000000000000000..4b2ee59dc7241b0ec31c99fd909d1c5e25aa77e0 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos9810-pinctrl.dtsi > @@ -0,0 +1,525 @@ > +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause > +/* > + * Samsung's Exynos 9810 SoC pin-mux and pin-config device tree source > + * > + * Copyright (c) 2024 Markuss Broks <markuss.broks@gmail.com> > + * Copyright (c) 2024 Maksym Holovach <nergzd@nergzd723.xyz> > + */ > + > +#include "exynos-pinctrl.h" > + > +&pinctrl_alive { > + wakeup-interrupt-controller { > + compatible = "samsung,exynos9810-wakeup-eint", > + "samsung,exynos850-wakeup-eint", > + "samsung,exynos7-wakeup-eint"; > + }; > + > + etc1: etc1-gpio-bank { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; [snip] > + > + gpp3: gpp3-gpio-bank { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg0: gpg0-gpio-bank { gpgX comes before gppX, sort all the nodes :D > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + [snip] > + }; > +}; > + > +#include "exynos9810-pinctrl.dtsi" > +#include "arm/samsung/exynos-syscon-restart.dtsi" >
On 24/10/2024 00:36, Markuss Broks wrote: > Add the compatible for Samsung Mongoose M3 CPU core to the schema. > > Co-authored-by: Maksym Holovach <nergzd@nergzd723.xyz> There is no such tag. Maybe you wanted Co-developed-by? But then missing SoB - see submitting patches. > Signed-off-by: Markuss Broks <markuss.broks@gmail.com> > --- Best regards, Krzysztof
On 24/10/2024 00:36, Markuss Broks wrote: > Exynos 9810 is an ARMv8 mobile SoC found in various Samsung devices, > such as Samsung Galaxy S9 (starlte), S9 Plus (star2lte), > Note 9 (crownlte) and perhaps others. > > Add minimal support for this SoC, including basic stuff like: > - PSCI for bringing up secondary cores > - ARMv8 generic timer > - GPIO and pinctrl. > > The firmware coming with the devices based on this SoC is buggy > and doesn't configure CNTFRQ_EL0, as required by spec, so it's > needed to hardcode the frequency in the timer node. > > Co-authored-by: Maksym Holovach <nergzd@nergzd723.xyz> > Signed-off-by: Markuss Broks <markuss.broks@gmail.com> > --- > arch/arm64/boot/dts/exynos/exynos9810-pinctrl.dtsi | 525 +++++++++++++++++++++ > arch/arm64/boot/dts/exynos/exynos9810.dtsi | 256 ++++++++++ > 2 files changed, 781 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos9810-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos9810-pinctrl.dtsi > new file mode 100644 > index 0000000000000000000000000000000000000000..4b2ee59dc7241b0ec31c99fd909d1c5e25aa77e0 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos9810-pinctrl.dtsi > @@ -0,0 +1,525 @@ > +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause > +/* > + * Samsung's Exynos 9810 SoC pin-mux and pin-config device tree source > + * > + * Copyright (c) 2024 Markuss Broks <markuss.broks@gmail.com> > + * Copyright (c) 2024 Maksym Holovach <nergzd@nergzd723.xyz> > + */ > + > +#include "exynos-pinctrl.h" > + > +&pinctrl_alive { > + wakeup-interrupt-controller { This is part of SoC DTSI. > + compatible = "samsung,exynos9810-wakeup-eint", > + "samsung,exynos850-wakeup-eint", > + "samsung,exynos7-wakeup-eint"; > + }; > + > + etc1: etc1-gpio-bank { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpa0: gpa0-gpio-bank { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>; > + #interrupt-cells = <2>; > + }; > + > + gpa1: gpa1-gpio-bank { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>; > + #interrupt-cells = <2>; > + }; > + > + gpa2: gpa2-gpio-bank { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>; > + #interrupt-cells = <2>; > + }; > + > + gpa3: gpa3-gpio-bank { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>; > + #interrupt-cells = <2>; > + }; > + > + gpa4: gpa4-gpio-bank { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpq0: gpq0-gpio-bank { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > +}; > + > +&pinctrl_aud { > + gpb0: gpb0-gpio-bank { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpb1: gpb1-gpio-bank { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpb2: gpb2-gpio-bank { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > +}; > + > +&pinctrl_chub { > + interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>; Please do not introduce different style than all other files. Best regards, Krzysztof
Hello, This series adds initial SoC support for the Samsung Exynos 9810 SoC and initial board support for Samsung Galaxy S9 phone (SM-G960F), codenamed starlte. The Exynos 9810 SoC is also used in S9 Plus (star2lte), Note 9 (crownlte), and perhaps more devices. Currently only Galaxy S9 DTS file is added but it should be fairly simple to add support for other devices based on this SoC, considering they're quite similar. The support added in this series includes: - cpus - pinctrl and gpio - simple-framebuffer This is enough to boot to a minimal initramfs shell. The preferred way to boot this device is by using a small shim bl called uniLoader [1], which packages the mainline kernel and DT and jumps to the kernel. This is done in order to work around some issues caused by the stock, and non-replacable Samsung S-Boot bootloader. For example, S-Boot leaves the decon trigger control unset, which causes the framebuffer to not refresh, so simple-framebuffer wouldn't work without a secondary loader. Ideally, there'll be a kernel driver for the display subsystem some day to resolve this issue. [1] https://github.com/ivoszbg/uniLoader Signed-off-by: Markuss Broks <markuss.broks@gmail.com> --- Markuss Broks (12): dt-bindings: arm: cpus: Add Samsung Mongoose M3 dt-bindings: hwinfo: samsung,exynos-chipid: Add Samsung exynos9810 compatible dt-bindings: pinctrl: samsung: Add compatible for Exynos9810 SoC dt-bindings: pinctrl: samsung: Add compatible for exynos9810-wakeup-eint dt-bindings: soc: samsung: exynos-pmu: Add exynos9810 compatible dt-bindings: arm: samsung: Document Exynos9810 and starlte board binding dt-bindings: arm: pmu: Add Samsung Mongoose core compatible perf: arm_pmuv3: Add support for Samsung Mongoose PMU soc: samsung: exynos-chipid: Add support for Exynos9810 SoC pinctrl: samsung: Add Exynos9810 SoC specific data arm64: dts: exynos: Add Exynos9810 SoC support arm64: dts: exynos: Add initial support for Samsung Galaxy S9 (SM-G960F) Documentation/devicetree/bindings/arm/cpus.yaml | 1 + Documentation/devicetree/bindings/arm/pmu.yaml | 1 + .../bindings/arm/samsung/samsung-boards.yaml | 6 + .../bindings/hwinfo/samsung,exynos-chipid.yaml | 1 + .../pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 1 + .../bindings/pinctrl/samsung,pinctrl.yaml | 1 + .../bindings/soc/samsung/exynos-pmu.yaml | 1 + arch/arm64/boot/dts/exynos/Makefile | 1 + arch/arm64/boot/dts/exynos/exynos9810-pinctrl.dtsi | 525 +++++++++++++++++++++ arch/arm64/boot/dts/exynos/exynos9810-starlte.dts | 119 +++++ arch/arm64/boot/dts/exynos/exynos9810.dtsi | 256 ++++++++++ drivers/perf/arm_pmuv3.c | 3 + drivers/pinctrl/samsung/pinctrl-exynos-arm64.c | 154 ++++++ drivers/pinctrl/samsung/pinctrl-samsung.c | 2 + drivers/pinctrl/samsung/pinctrl-samsung.h | 1 + drivers/soc/samsung/exynos-chipid.c | 1 + 16 files changed, 1074 insertions(+) --- base-commit: f2493655d2d3d5c6958ed996b043c821c23ae8d3 change-id: 20241024-exynos9810-b3eed995b0b9 Best regards,