| Message ID | 20241216-gs101-simplefb-v1-0-8ccad1830281@linaro.org |
|---|---|
| Headers | show |
| Series | Google Pixel 6 (simple) framebuffer support | expand |
On Tue, 2024-12-17 at 08:38 +0100, Krzysztof Kozlowski wrote: > On Mon, Dec 16, 2024 at 01:06:28PM +0000, André Draszik wrote: > > In order to support Pixel 6 (Oriole) and Pixel 6 Pro (Raven) properly, > > we have to be able to distinguish them properly as we add support for > > more features. > > > > For example, Raven has a larger display. There are other differences, > > like battery design capacity, etc. > > > > Move all the parts that are common for now into a gs101-raviole.dtsi, > > and just leave the display related things in gs101-oriole.dts. > > > > Raviole was chosen as the name because Google uses that when referring > > to the combination of Oriole & Raven, keeping the familiar terminology. > > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > > > --- > > Note: MAINTAINERS doesn't need updating, it covers this whole directory > > --- > > arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 290 +------------------- > > .../boot/dts/exynos/google/gs101-raviole.dtsi | 297 +++++++++++++++++++++ > > 2 files changed, 305 insertions(+), 282 deletions(-) > > > > This looks like move of the code, so -M/-B/-C format patch arguments > would create better diff. Ah, yes, forgot about those when I switched to using b4 instead of custom scripts... Cheers, Andre
Hi, This series enables simple framebuffer support on Google Pixel 6 and Pixel 6 Pro. Even if simple-framebuffer is deprecated and DRM should be used instead, having it available in DT is beneficial for several reasons at this point in time (the phone uses an OLED display): * energy consumption goes down significantly, as it changes from white (as left by bootloader) to black (linux console), and we generally don't run out of battery anymore when plugged into a USB port * less of a burn-in effect I assume * phone stays cooler due to reduced energy consumption by display Since Pixel 6 and Pixel 6 Pro use a different resolution display, this is the time to separate them into their respective DTs, and provide one for each of them. There are other differences between the two, like battery design capacity, but they don't matter at this stage due to incomplete upstream support. * dependency note * Due to the renaming of the gs101-oriole.dts, this series will conflict with any pending patches touching the same file. I have therefore based this series on top of my USB series from https://lore.kernel.org/r/20241203-gs101-phy-lanes-orientation-dts-v2-0-1412783a6b01@linaro.org Please let me know if I should do something different. * dependency note end * For those who want to try this out: The stock bootloader disables the decon hardware trigger before jumping to Linux, preventing framebuffer updates from reaching the display. We have added a work-around in our Yocto BSP layer for the time being (until a proper display exists upstream). An alternative might be to port and use uniLoader from https://github.com/ivoszbg/uniLoader, as seems to be done for some other Exynos platforms. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- André Draszik (4): dt-bindings: arm: google: add gs101-raven arm64: dts: exynos: gs101-oriole: configure simple-framebuffer arm64: dts: exynos: gs101-oriole: move common Pixel6 & 6Pro parts into a .dtsi arm64: dts: exynos: gs101-raven: add new board file Documentation/devicetree/bindings/arm/google.yaml | 3 +- arch/arm64/boot/dts/exynos/google/Makefile | 1 + arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 269 +------------------ arch/arm64/boot/dts/exynos/google/gs101-raven.dts | 27 ++ .../boot/dts/exynos/google/gs101-raviole.dtsi | 297 +++++++++++++++++++++ 5 files changed, 335 insertions(+), 262 deletions(-) --- base-commit: d454191ca68125bee218d1d67d6716d7e753dc7b change-id: 20241216-gs101-simplefb-8aae80278ed7 Best regards,