From patchwork Sun Dec 11 06:51:40 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: thomas.abraham@linaro.org X-Patchwork-Id: 5576 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 9D92623E19 for ; Sun, 11 Dec 2011 06:50:21 +0000 (UTC) Received: from mail-bw0-f52.google.com (mail-bw0-f52.google.com [209.85.214.52]) by fiordland.canonical.com (Postfix) with ESMTP id 86B0DA18310 for ; Sun, 11 Dec 2011 06:50:21 +0000 (UTC) Received: by mail-bw0-f52.google.com with SMTP id 17so5858557bke.11 for ; Sat, 10 Dec 2011 22:50:21 -0800 (PST) Received: by 10.204.156.208 with SMTP id y16mr7281483bkw.72.1323586221370; Sat, 10 Dec 2011 22:50:21 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.205.129.2 with SMTP id hg2cs17225bkc; Sat, 10 Dec 2011 22:50:21 -0800 (PST) Received: by 10.68.73.228 with SMTP id o4mr21812065pbv.2.1323586219003; Sat, 10 Dec 2011 22:50:19 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by mx.google.com with ESMTP id g10si18573038pbe.43.2011.12.10.22.50.18; Sat, 10 Dec 2011 22:50:19 -0800 (PST) Received-SPF: neutral (google.com: 203.254.224.34 is neither permitted nor denied by best guess record for domain of thomas.abraham@linaro.org) client-ip=203.254.224.34; Authentication-Results: mx.google.com; spf=neutral (google.com: 203.254.224.34 is neither permitted nor denied by best guess record for domain of thomas.abraham@linaro.org) smtp.mail=thomas.abraham@linaro.org Received: from epcpsbgm2.samsung.com (mailout4.samsung.com [203.254.224.34]) by mailout4.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0LW1003YX1NO9830@mailout4.samsung.com> for patches@linaro.org; Sun, 11 Dec 2011 15:50:18 +0900 (KST) X-AuditID: cbfee61b-b7b95ae00000198b-9a-4ee452a9bd9f Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (MMPCPMTA) with SMTP id CC.4F.06539.9A254EE4; Sun, 11 Dec 2011 15:50:18 +0900 (KST) Received: from localhost.localdomain ([107.108.73.37]) by mmp1.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTPA id <0LW100EBB1NIOE80@mmp1.samsung.com> for patches@linaro.org; Sun, 11 Dec 2011 15:50:17 +0900 (KST) From: Thomas Abraham To: linux-samsung-soc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, grant.likely@secretlab.ca, rob.herring@calxeda.com, kgene.kim@samsung.com, patches@linaro.org Subject: [PATCH v2 3/4] ARM: Exynos4: Remove arch_initcall for wakeup interrupt initialization Date: Sun, 11 Dec 2011 12:21:40 +0530 Message-id: <1323586301-24537-4-git-send-email-thomas.abraham@linaro.org> X-Mailer: git-send-email 1.6.6.rc2 In-reply-to: <1323586301-24537-3-git-send-email-thomas.abraham@linaro.org> References: <1323586301-24537-1-git-send-email-thomas.abraham@linaro.org> <1323586301-24537-2-git-send-email-thomas.abraham@linaro.org> <1323586301-24537-3-git-send-email-thomas.abraham@linaro.org> X-Brightmail-Tracker: AAAAAA== The of_irq_init function would be setup to invoke the exynos4_init_irq_eint function when booting using device tree. The arch_initcall for exynos4_init_irq_eint would duplicate its invocation in that case. Hence, arch_initcall for exynos4_init_irq_eint is removed and this function is invoked from the exynos4_init_irq for non-dt case. Moreover, with single kernel image build, the exynos4_init_irq_eint has no checks to ensure that it is running on a exynos4 platform. So it would be appropriate to invoke it from exynos4_init_irq. Signed-off-by: Thomas Abraham --- arch/arm/mach-exynos/cpu.c | 1 + arch/arm/mach-exynos/irq-eint.c | 2 -- arch/arm/plat-samsung/include/plat/exynos4.h | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-exynos/cpu.c b/arch/arm/mach-exynos/cpu.c index 14f86ba..2e6ae21 100644 --- a/arch/arm/mach-exynos/cpu.c +++ b/arch/arm/mach-exynos/cpu.c @@ -289,6 +289,7 @@ void __init exynos4_init_irq(void) * uses GIC instead of VIC. */ s5p_init_irq(NULL, 0); + exynos4_init_irq_eint(); } struct sysdev_class exynos4_sysclass = { diff --git a/arch/arm/mach-exynos/irq-eint.c b/arch/arm/mach-exynos/irq-eint.c index 41aaca8..c8bad66 100644 --- a/arch/arm/mach-exynos/irq-eint.c +++ b/arch/arm/mach-exynos/irq-eint.c @@ -233,5 +233,3 @@ int __init exynos4_init_irq_eint(void) return 0; } - -arch_initcall(exynos4_init_irq_eint); diff --git a/arch/arm/plat-samsung/include/plat/exynos4.h b/arch/arm/plat-samsung/include/plat/exynos4.h index f546e88..a501461 100644 --- a/arch/arm/plat-samsung/include/plat/exynos4.h +++ b/arch/arm/plat-samsung/include/plat/exynos4.h @@ -24,6 +24,7 @@ extern void exynos4_init_irq(void); extern void exynos4_map_io(void); extern void exynos4_init_clocks(int xtal); extern struct sys_timer exynos4_timer; +extern int exynos4_init_irq_eint(void); #define exynos4_init_uarts exynos4_common_init_uarts