From patchwork Thu Nov 24 11:20:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 83860 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp79149qgi; Thu, 24 Nov 2016 03:20:41 -0800 (PST) X-Received: by 10.84.134.3 with SMTP id 3mr4257655plg.90.1479986441688; Thu, 24 Nov 2016 03:20:41 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c68si38954933pfj.98.2016.11.24.03.20.41; Thu, 24 Nov 2016 03:20:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965113AbcKXLUi (ORCPT + 4 others); Thu, 24 Nov 2016 06:20:38 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:44901 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964851AbcKXLUg (ORCPT ); Thu, 24 Nov 2016 06:20:36 -0500 Received: from epcpsbgm2new.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OH502FMU8TW1J20@mailout1.samsung.com> for linux-samsung-soc@vger.kernel.org; Thu, 24 Nov 2016 20:20:35 +0900 (KST) X-AuditID: cbfee61b-f796f6d000004092-fc-5836cd039eba Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id 50.0E.16530.30DC6385; Thu, 24 Nov 2016 20:20:35 +0900 (KST) Received: from AMDC2765.digital.local ([106.116.147.25]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OH500D6Y8U00G70@mmp1.samsung.com>; Thu, 24 Nov 2016 20:20:35 +0900 (KST) From: Marek Szyprowski To: iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Joerg Roedel , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz Subject: [PATCH 1/5] iommu/exynos: Improve page fault debug message Date: Thu, 24 Nov 2016 12:20:16 +0100 Message-id: <1479986420-30859-2-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1479986420-30859-1-git-send-email-m.szyprowski@samsung.com> References: <1479986420-30859-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsVy+t9jAV3ms2YRBo/WC1hsnLGe1WLBfmuL ztkb2C3OnwcSM87vY7JYe+QuuwObx5OD85g8Nq3qZPOYfGM5o0ffllWMHp83yQWwRrnZZKQm pqQWKaTmJeenZOal2yqFhrjpWigp5CXmptoqRej6hgQpKZQl5pQCeUYGaMDBOcA9WEnfLsEt o/HEcdaCx9wVXYvPMzUw/uLsYuTkkBAwkXi3ex87hC0mceHeerYuRi4OIYGljBKPnl5jAkkI CfxilPh3JAnEZhMwlOh628UGYosIuEtc//OcBaSBWWADo8S6GROYuxg5OIQFnCWWtmiC1LAI qEq8ap0NVs8r4CGx/8MeRohlchInj01mBbE5BTwlpm/sZ4HY5SFxYdVbxgmMvAsYGVYxSqQW JBcUJ6XnGuWllusVJ+YWl+al6yXn525iBIfxM+kdjId3uR9iFOBgVOLh7TAxixBiTSwrrsw9 xCjBwawkwmtwCijEm5JYWZValB9fVJqTWnyI0RTosInMUqLJ+cAYyyuJNzQxNzE3NrAwt7Q0 MVIS522c/SxcSCA9sSQ1OzW1ILUIpo+Jg1OqgXHmtmP2j6bfFnp+tPjjl3MHFVbukcvkfqJQ 2Xja1Et9UcyVCu4NHJFXMp1VmGdf5PhSVr3w+9N38kfX/wjXW3Dp+s0VD3df2MKSaSaQvfRJ WdKEH8KL8yd/1NhzfqpoZpiwusnPEy1eAorfNqjc+n7tZpvnrOBpzP53Dba+K01fbcl17kr5 R6EaJZbijERDLeai4kQAJMdcn3kCAAA= X-MTR: 20000000000000000@CPGS Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Add master device name to default IOMMU fault message to make easier to find which device triggered the fault. While at it, move printing some information (like page table base and first level entry addresses) to dev_dbg(), because those are typically not very useful for typical device driver user/developer not equipped with hardware debugging tools. Signed-off-by: Marek Szyprowski --- drivers/iommu/exynos-iommu.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 57ba0d3091ea..ac726e1760de 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -381,13 +381,14 @@ static void show_fault_information(struct sysmmu_drvdata *data, { sysmmu_pte_t *ent; - dev_err(data->sysmmu, "%s FAULT occurred at %#x (page table base: %pa)\n", - finfo->name, fault_addr, &data->pgtable); + dev_err(data->sysmmu, "%s: %s FAULT occurred at %#x\n", + dev_name(data->master), finfo->name, fault_addr); + dev_dbg(data->sysmmu, "Page table base: %pa\n", &data->pgtable); ent = section_entry(phys_to_virt(data->pgtable), fault_addr); - dev_err(data->sysmmu, "\tLv1 entry: %#x\n", *ent); + dev_dbg(data->sysmmu, "\tLv1 entry: %#x\n", *ent); if (lv1ent_page(ent)) { ent = page_entry(ent, fault_addr); - dev_err(data->sysmmu, "\t Lv2 entry: %#x\n", *ent); + dev_dbg(data->sysmmu, "\t Lv2 entry: %#x\n", *ent); } }