mbox series

[v2,0/5] Fix mpt3sas driver sparse warnings

Message ID 20220224233056.398054-1-damien.lemoal@opensource.wdc.com
Headers show
Series Fix mpt3sas driver sparse warnings | expand

Message

Damien Le Moal Feb. 24, 2022, 11:30 p.m. UTC 
This series fix (remove) all sparse warnings generated when compiling
the mpt3sas driver. All warnings are related to __iomem access and
endianness.

The series was tested on top of Martin's 5.18/scsi-staging branch with a
9400-8i HBA with direct attached iSAS and SATA drives. The fixes need
careful review by the maintainers as there is no documentation clearly
explaning the proper endianness of the values touched.

Changes from v1:
* Reworked patch 1 to remove the TaskMID field type change and simplify
  _ctl_set_task_mid() code.

Damien Le Moal (5):
  scsi: mpt3sas: fix _ctl_set_task_mid() TaskMID check
  scsi: mpt3sas: Fix writel() use
  scsi: mpt3sas: fix ioc->base_readl() use
  scsi: mpt3sas: fix event callback log_code value handling
  scsi: mpt3sas: fix adapter replyPostRegisterIndex handling

 drivers/scsi/mpt3sas/mpt3sas_base.c  | 60 ++++++++++++++++------------
 drivers/scsi/mpt3sas/mpt3sas_ctl.c   | 11 ++---
 drivers/scsi/mpt3sas/mpt3sas_scsih.c |  6 +--
 3 files changed, 43 insertions(+), 34 deletions(-)

Comments

Martin K. Petersen March 2, 2022, 4:24 a.m. UTC | #1 
> This series fix (remove) all sparse warnings generated when compiling
> the mpt3sas driver. All warnings are related to __iomem access and
> endianness.
>
> The series was tested on top of Martin's 5.18/scsi-staging branch with
> a 9400-8i HBA with direct attached iSAS and SATA drives. The fixes
> need careful review by the maintainers as there is no documentation
> clearly explaning the proper endianness of the values touched.

Broadcom: Please review!
Sreekanth Reddy March 3, 2022, 1:54 p.m. UTC | #2 
On Wed, Mar 2, 2022 at 9:54 AM Martin K. Petersen
<martin.petersen@oracle.com> wrote:
>
>
> > This series fix (remove) all sparse warnings generated when compiling
> > the mpt3sas driver. All warnings are related to __iomem access and
> > endianness.
> >
> > The series was tested on top of Martin's 5.18/scsi-staging branch with
> > a 9400-8i HBA with direct attached iSAS and SATA drives. The fixes
> > need careful review by the maintainers as there is no documentation
> > clearly explaning the proper endianness of the values touched.
>
> Broadcom: Please review!

Sure Martin. I will complete the review by the end of this week.

>
> --
> Martin K. Petersen      Oracle Linux Engineering