mbox series

[v10,0/2] fix abort defect

Message ID 20241001091917.6917-1-peter.wang@mediatek.com
Headers show
Series fix abort defect | expand

Message

Peter Wang (王信友) Oct. 1, 2024, 9:19 a.m. UTC
From: Peter Wang <peter.wang@mediatek.com>

V10:
 - Requeue OCS: ABORTED request in MCQ mode.

V9:
 - Revise the OCS content printed.
 
V8:
 - Remove the abort variable to simplify the abort process.
 - Correct error handler successfully aborts release flow.
 - Ingore MCQ OCS: ABORTED.

V7:
 - Use a variable instead of a flag.
 - Add a check for MCQ mode when setting this variable to UFS_ERR_HANDLER.
 - Print OCS information for OCS_ABORTED and OCS_INVALID_COMMAND_STATUS.
 - Add a MediaTek quirk for handling OCS_ABORTED in SDB mode.
 - Skip notifying SCSI from ISR during SCSI abort (ufshcd_abort()).

V6:
 - Add err handler check before set flag true.

V5:
 - Change flag name.
 - Amend comment and patch description.

V4:
 - Remove nullify SQ entry abort requeue.
 - Add more comment for flag usage and set description.
 - Fix build warning.

V3:
 - Change comment and use variable(rtc) for error print
 - Change flag name and move flag set before ufshcd_clear_cmd
 - Add SDB mode clear UTRLCLR tag receive OCS_ABORTED requeue

V2:
 - Fix mcq_enabled build error.

Peter Wang (2):
  ufs: core: fix the issue of ICU failure
  ufs: core: requeue aborted request

 drivers/ufs/core/ufs-mcq.c | 15 ++++++++-------
 drivers/ufs/core/ufshcd.c  | 20 ++++----------------
 2 files changed, 12 insertions(+), 23 deletions(-)

Comments

Martin K. Petersen Oct. 16, 2024, 2:38 a.m. UTC | #1
On Tue, 01 Oct 2024 17:19:15 +0800, peter.wang@mediatek.com wrote:

> V10:
>  - Requeue OCS: ABORTED request in MCQ mode.
> 
> V9:
>  - Revise the OCS content printed.
> 
> V8:
>  - Remove the abort variable to simplify the abort process.
>  - Correct error handler successfully aborts release flow.
>  - Ingore MCQ OCS: ABORTED.
> 
> [...]

Applied to 6.12/scsi-fixes, thanks!

[1/2] ufs: core: fix the issue of ICU failure
      https://git.kernel.org/mkp/scsi/c/bf0c6cc73f7f
[2/2] ufs: core: requeue aborted request
      https://git.kernel.org/mkp/scsi/c/8fa075804cb3