| Message ID | 1655463320-241202-5-git-send-email-john.garry@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | blk-mq: Add a flag for reserved requests series | expand |
On 6/17/22 03:55, John Garry wrote: > The SCSI core code does not support reserved requests, so drop the > handling in fnic_pending_aborts_iter(). Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
On 6/17/22 12:55, John Garry wrote: > The SCSI core code does not support reserved requests, so drop the > handling in fnic_pending_aborts_iter(). > > Signed-off-by: John Garry <john.garry@huawei.com> > --- > drivers/scsi/fnic/fnic_scsi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c > index 3d64877bda8d..e7b7f6d73429 100644 > --- a/drivers/scsi/fnic/fnic_scsi.c > +++ b/drivers/scsi/fnic/fnic_scsi.c > @@ -2019,8 +2019,6 @@ static bool fnic_pending_aborts_iter(struct scsi_cmnd *sc, > > if (sc == iter_data->lr_sc || sc->device != lun_dev) > return true; > - if (reserved) > - return true; > > io_lock = fnic_io_lock_tag(fnic, abt_tag); > spin_lock_irqsave(io_lock, flags); Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index 3d64877bda8d..e7b7f6d73429 100644 --- a/drivers/scsi/fnic/fnic_scsi.c +++ b/drivers/scsi/fnic/fnic_scsi.c @@ -2019,8 +2019,6 @@ static bool fnic_pending_aborts_iter(struct scsi_cmnd *sc, if (sc == iter_data->lr_sc || sc->device != lun_dev) return true; - if (reserved) - return true; io_lock = fnic_io_lock_tag(fnic, abt_tag); spin_lock_irqsave(io_lock, flags);
The SCSI core code does not support reserved requests, so drop the handling in fnic_pending_aborts_iter(). Signed-off-by: John Garry <john.garry@huawei.com> --- drivers/scsi/fnic/fnic_scsi.c | 2 -- 1 file changed, 2 deletions(-)