From patchwork Mon Nov 2 14:23:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315405 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 106D4C00A89 for ; Mon, 2 Nov 2020 14:25:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADE2B206F8 for ; Mon, 2 Nov 2020 14:25:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="amjzFEdy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726258AbgKBOZP (ORCPT ); Mon, 2 Nov 2020 09:25:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbgKBOYR (ORCPT ); Mon, 2 Nov 2020 09:24:17 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6BE4C061A04 for ; Mon, 2 Nov 2020 06:24:16 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id b8so14857912wrn.0 for ; Mon, 02 Nov 2020 06:24:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b1a6YHQXGZMUnJNF8MJYubaqVfXzvcvl6CdQ46sxWjM=; b=amjzFEdycct+fBy4wvobDLEhGWm69eQKt6whChJ8JlXRazlsySQ0Ut+SSj5dhR9Uy+ MzzORxICFwAWp1+zpN2DGGck1/P/+TmIoazBVBx5KkCuGKePv0vd3xYeaut6QYmA0afn cU7NCJJgm0IPXrmL9eDpUFozyCxvByyRcEHW+W/OoQe0epzsOfDPEqB2yo0jeZp83L5M W7AnoTt4HqU+FJUwMcAVy/X6n+iCx1t+B1XvEWY9MFX7tQKNFj1Myq3Jc+W+6CI25iBo MDtLD/bdtSnwIs9vz0T42TdP9Z4pJgo9q12VdIHCKKQY9dABhdJuCxC3sq9aIHo5XlYh LrXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b1a6YHQXGZMUnJNF8MJYubaqVfXzvcvl6CdQ46sxWjM=; b=T7Ajb4xsnT/1p7Wjl9f45Ny8DJXdmGhyOAB42QQ67X0X0gPKQ+FFV68tjX5eP0xcSX RPMyZquhRHo6nNuK6cXIdizJArYsOT9QvTyVW3QP3nZ3J6RN696+tWQP2Awsv8tjQT4y MxTe+lxzwkKedyhuMJbQvlh3NJ4i9Uyy6MlWfnoeNX+tzCi49GxSqYGETdRl7PqRGYbG 1sK71lUNmX1lP8GDkuoBuJPtkoJdPlBlh+Ey9jru/qucXJcwH4VAgOcZZqiRat1z6mlK /qNAAnVFEygmeBAu+oc/ffk+NjCZybopHRiSzsDuVvcXjdQd3kNh0TOhaj0h3eJ1nfFS dODA== X-Gm-Message-State: AOAM530vaWjZ5xeCLlXZdAfeLkwACezyj6bWpLBRYUO3XS7cCWTF0+GX at9xZztW0WcwzDvjk3boMcCIRw== X-Google-Smtp-Source: ABdhPJzLFghEEj7dMpcUjxYt0Fs0erXBoWfEk0PbyWEwcX7Qvon6YJDXZHuMfGOlMmGONgXYLU03Cw== X-Received: by 2002:adf:92e7:: with SMTP id 94mr21969909wrn.271.1604327055374; Mon, 02 Nov 2020 06:24:15 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f7sm23542501wrx.64.2020.11.02.06.24.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 06:24:14 -0800 (PST) From: Lee Jones To: martin.petersen@oracle.com, jejb@linux.ibm.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Bradley Grove Subject: [RESEND 09/19] scsi: esas2r: esas2r_init: Place brackets around a potentially empty if() Date: Mon, 2 Nov 2020 14:23:49 +0000 Message-Id: <20201102142359.561122-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102142359.561122-1-lee.jones@linaro.org> References: <20201102142359.561122-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/esas2r/esas2r_init.c: In function ‘esas2r_init_adapter’: drivers/scsi/esas2r/esas2r_init.c:418:41: warning: suggest braces around empty body in an ‘else’ statement [-Wempty-body] Cc: Bradley Grove Signed-off-by: Lee Jones --- drivers/scsi/esas2r/esas2r_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/esas2r/esas2r_init.c b/drivers/scsi/esas2r/esas2r_init.c index 09c5c24bf391f..4b91db7ba919c 100644 --- a/drivers/scsi/esas2r/esas2r_init.c +++ b/drivers/scsi/esas2r/esas2r_init.c @@ -412,10 +412,11 @@ int esas2r_init_adapter(struct Scsi_Host *host, struct pci_dev *pcid, esas2r_disable_chip_interrupts(a); esas2r_check_adapter(a); - if (!esas2r_init_adapter_hw(a, true)) + if (!esas2r_init_adapter_hw(a, true)) { esas2r_log(ESAS2R_LOG_CRIT, "failed to initialize hardware!"); - else + } else { esas2r_debug("esas2r_init_adapter ok"); + } esas2r_claim_interrupts(a);