| Message ID | 20201201082730.24158-11-njavali@marvell.com |
|---|---|
| State | New |
| Headers | show |
| Series | qla2xxx bug fixes | expand |
> On Dec 1, 2020, at 2:27 AM, Nilesh Javali <njavali@marvell.com> wrote: > > From: Saurav Kashyap <skashyap@marvell.com> > > Call trace observed while shutting down the adapter ports (LINK DOWN). > Handle aborts correctly. > Could you post call trace in commit message. > Signed-off-by: Saurav Kashyap <skashyap@marvell.com> > Signed-off-by: Nilesh Javali <njavali@marvell.com> > --- > drivers/scsi/qla2xxx/qla_nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c > index d4159d5a4ffd..eab559b3b257 100644 > --- a/drivers/scsi/qla2xxx/qla_nvme.c > +++ b/drivers/scsi/qla2xxx/qla_nvme.c > @@ -227,7 +227,7 @@ static void qla_nvme_abort_work(struct work_struct *work) > "%s called for sp=%p, hndl=%x on fcport=%p deleted=%d\n", > __func__, sp, sp->handle, fcport, fcport->deleted); > > - if (!ha->flags.fw_started && fcport->deleted) > + if (!ha->flags.fw_started || fcport->deleted) > goto out; > > if (ha->flags.host_shutting_down) { > -- > 2.19.0.rc0 > Change itself is fine. Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> -- Himanshu Madhani Oracle Linux Engineering
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index d4159d5a4ffd..eab559b3b257 100644 --- a/drivers/scsi/qla2xxx/qla_nvme.c +++ b/drivers/scsi/qla2xxx/qla_nvme.c @@ -227,7 +227,7 @@ static void qla_nvme_abort_work(struct work_struct *work) "%s called for sp=%p, hndl=%x on fcport=%p deleted=%d\n", __func__, sp, sp->handle, fcport, fcport->deleted); - if (!ha->flags.fw_started && fcport->deleted) + if (!ha->flags.fw_started || fcport->deleted) goto out; if (ha->flags.host_shutting_down) {