From patchwork Wed Mar 17 09:12:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 403082 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp294570jai; Wed, 17 Mar 2021 02:14:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxr9SySbw+xVId+WLxygyX0aWC9eFctc2z7AFaXEqE/GdVgFiKp/uUxfAWOorL6OQ50b4Hw X-Received: by 2002:a17:907:2bf6:: with SMTP id gv54mr34784590ejc.514.1615972441947; Wed, 17 Mar 2021 02:14:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615972441; cv=none; d=google.com; s=arc-20160816; b=aj/52V2oXgO1Ea42tvR/B8RW0+QfM7ywFNMi4JftAh2ypFjgLBBGLswQ06bhbSel+8 dR1JJtuM7bide5+n/RC+1FpwqGawtzpZjqVB/3HujOml4HSjmUfjsSvU5ukuqrba2EHE tHki66w70FaZQzoL7n2fb1Tq9JGpIHtVtW+asqjeS7dNugBy7lcnSe8jt0qMwGtff191 3qcFGR43M9Ury4fCyQzWnVfSZjwULWi67876tQnnm9OuT5zXvBEiN3tQgoXD/TYkj7fy VhNdmxQLPq958X3paCwLEex1bbROWllGro/CnscD6HHC0P0tBMy4efk8j7EShLZ6BBG0 dAVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bKVcoII/VExWgJlUv7/sN5c60FiIBMpvmlinKRnJimA=; b=AtM4hI+xwXqjUYdOvQqy6QDPLdsIvjNjaurRN2enp01okvDKzxZiqknOrucXszD64F FaHqoFmCmIxQ+YDcDZ3nvTn7KhXF5IMEFcKhqKQaFxuSacuuBtJw86Kz4XyT/tMEc91u eG0R7gKsCk3VLaE60ddqZ3F9iTCsjBxyaOt91Ezqp5Rya+SnjTj78HN1BrLqAWLLy1Z/ 85bQj5JvxKv7UXm0DwaiuvsbKbAKWkmuljws/p37B0A/MxaxdBswyh5tVT5GavakK820 AWlQ+cxw4pbmssutYfRvSR1DzeFmE4rUL+9NQW96UPNPm0uD0FqWBFYWHZSevcjLenDs KSvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MxXKhto9; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t15si15461864edq.164.2021.03.17.02.14.01 for ; Wed, 17 Mar 2021 02:14:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MxXKhto9; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229889AbhCQJN2 (ORCPT ); Wed, 17 Mar 2021 05:13:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229970AbhCQJM4 (ORCPT ); Wed, 17 Mar 2021 05:12:56 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9771CC061765 for ; Wed, 17 Mar 2021 02:12:55 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id k8so1005279wrc.3 for ; Wed, 17 Mar 2021 02:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bKVcoII/VExWgJlUv7/sN5c60FiIBMpvmlinKRnJimA=; b=MxXKhto9q9aaLM4LCO+LShWyhOUYRtAJedAKRvWFVJ4lyEZrFWIQDR7Cuhk1eUJrTz suzen/yOMRsiTSkMEzH3O79wsm9zWNVKldu0eGmN6WUhQOtfIJ1eHxggcJbluxeOP314 Sq8r97Qego7DsLELU/HaMEr3KCt10tqRS3Mgu8s74sIl4htXqCk0hAUvnMpmOTIsh9wv u2xXkQBnHRnnuxhAYjKF8gOBdyKJEIjvLK0K8wV0EKaYTJRgfcToSL0YtwLGkwZY/ia7 B358sXL6rbbgVIBaPmoScZTJonU4vYEblWpjJo2XjGaL1RdMnR7ATEaUdtk0dyfNRWSz OOkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bKVcoII/VExWgJlUv7/sN5c60FiIBMpvmlinKRnJimA=; b=ZcSu/jlZLfyogllh2YqtvcpRKAm09ZxzEZZekeAk+6O2eM7d6svazd2kraFVQjMZbd DB/ti37qNCKfQT1+IT0RIOKZCf9fJSaf/cJNWRGUx6D3+s2W8ysxYp+01UkANBfOiLgx rnN5n7sh4TZf0V0Vy5n/dbCQm6i8+2ShsWLBSPwoBUgAvHFZatQBztGq7Ad4ZCyOep9q 6Cj4oCJL58u0ci49JmrXH/JRJvhbDo7EFfRHRZR62me+ikxipn7/W8N3qznwrES5IKDt LBPifp1nbBPm6v6whE4YVaxPWRMjnmwhTzfwLxrAONnpXMc3A9LPiKAOi/hdMgSwYWH7 gPeA== X-Gm-Message-State: AOAM533I8cuySAhC9zuu+6HRSw9FF5egTC7hPADgEakAuJZL5tgaisTp HVjHIf2mDbJ9H1Qr4XFDWTRJbQ== X-Received: by 2002:a5d:5088:: with SMTP id a8mr3403129wrt.294.1615972374378; Wed, 17 Mar 2021 02:12:54 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id e18sm12695886wru.73.2021.03.17.02.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 02:12:53 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" , MPT-FusionLinux.pdl@avagotech.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org Subject: [PATCH 14/36] scsi: mpt3sas: mpt3sas_scs: Fix a few kernel-doc issues Date: Wed, 17 Mar 2021 09:12:08 +0000 Message-Id: <20210317091230.2912389-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317091230.2912389-1-lee.jones@linaro.org> References: <20210317091230.2912389-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/mpt3sas/mpt3sas_scsih.c:763: warning: Function parameter or member 'sas_address' not described in '__mpt3sas_get_sdev_by_addr' drivers/scsi/mpt3sas/mpt3sas_scsih.c:763: warning: expecting prototype for mpt3sas_get_sdev_by_addr(). Prototype was for __mpt3sas_get_sdev_by_addr() instead drivers/scsi/mpt3sas/mpt3sas_scsih.c:4535: warning: expecting prototype for _scsih_check_for_pending_internal_cmds(). Prototype was for mpt3sas_check_for_pending_internal_cmds() instead drivers/scsi/mpt3sas/mpt3sas_scsih.c:6188: warning: Function parameter or member 'port_entry' not described in '_scsih_look_and_get_matched_port_entry' drivers/scsi/mpt3sas/mpt3sas_scsih.c:6188: warning: Function parameter or member 'matched_port_entry' not described in '_scsih_look_and_get_matched_port_entry' drivers/scsi/mpt3sas/mpt3sas_scsih.c:6188: warning: Function parameter or member 'count' not described in '_scsih_look_and_get_matched_port_entry' drivers/scsi/mpt3sas/mpt3sas_scsih.c:6959: warning: Function parameter or member 'port' not described in 'mpt3sas_expander_remove' drivers/scsi/mpt3sas/mpt3sas_scsih.c:10494: warning: expecting prototype for mpt3sas_scsih_reset_handler(). Prototype was for mpt3sas_scsih_pre_reset_handler() instead drivers/scsi/mpt3sas/mpt3sas_scsih.c:10536: warning: expecting prototype for mpt3sas_scsih_reset_handler(). Prototype was for mpt3sas_scsih_reset_done_handler() instead drivers/scsi/mpt3sas/mpt3sas_scsih.c:12303: warning: expecting prototype for scsih__ncq_prio_supp(). Prototype was for scsih_ncq_prio_supp() instead Cc: Sathya Prakash Cc: Sreekanth Reddy Cc: Suganath Prabu Subramani Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: MPT-FusionLinux.pdl@avagotech.com Cc: MPT-FusionLinux.pdl@broadcom.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) -- 2.27.0 diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 945531e94d7e4..23ecf2750ec79 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -749,9 +749,10 @@ __mpt3sas_get_sdev_by_rphy(struct MPT3SAS_ADAPTER *ioc, } /** - * mpt3sas_get_sdev_by_addr - get _sas_device object corresponding to provided + * __mpt3sas_get_sdev_by_addr - get _sas_device object corresponding to provided * sas address from sas_device_list list * @ioc: per adapter object + * @sas_address: device sas address * @port: port number * * Search for _sas_device object corresponding to provided sas address, @@ -4518,7 +4519,7 @@ _scsih_issue_delayed_sas_io_unit_ctrl(struct MPT3SAS_ADAPTER *ioc, } /** - * _scsih_check_for_pending_internal_cmds - check for pending internal messages + * mpt3sas_check_for_pending_internal_cmds - check for pending internal messages * @ioc: per adapter object * @smid: system request message index * @@ -6174,10 +6175,10 @@ enum hba_port_matched_codes { * _scsih_look_and_get_matched_port_entry - Get matched hba port entry * from HBA port table * @ioc: per adapter object - * @port_entry - hba port entry from temporary port table which needs to be + * @port_entry: hba port entry from temporary port table which needs to be * searched for matched entry in the HBA port table - * @matched_port_entry - save matched hba port entry here - * @count - count of matched entries + * @matched_port_entry: save matched hba port entry here + * @count: count of matched entries * * return type of matched entry found. */ @@ -6952,6 +6953,7 @@ _scsih_expander_add(struct MPT3SAS_ADAPTER *ioc, u16 handle) * mpt3sas_expander_remove - removing expander object * @ioc: per adapter object * @sas_address: expander sas_address + * @port: hba port entry */ void mpt3sas_expander_remove(struct MPT3SAS_ADAPTER *ioc, u64 sas_address, @@ -10487,7 +10489,7 @@ _scsih_scan_for_devices_after_reset(struct MPT3SAS_ADAPTER *ioc) } /** - * mpt3sas_scsih_reset_handler - reset callback handler (for scsih) + * mpt3sas_scsih_pre_reset_handler - reset callback handler (for scsih) * @ioc: per adapter object * * The handler for doing any required cleanup or initialization. @@ -10528,7 +10530,7 @@ mpt3sas_scsih_clear_outstanding_scsi_tm_commands(struct MPT3SAS_ADAPTER *ioc) } /** - * mpt3sas_scsih_reset_handler - reset callback handler (for scsih) + * mpt3sas_scsih_reset_done_handler - reset callback handler (for scsih) * @ioc: per adapter object * * The handler for doing any required cleanup or initialization. @@ -12295,7 +12297,7 @@ scsih_pci_mmio_enabled(struct pci_dev *pdev) } /** - * scsih__ncq_prio_supp - Check for NCQ command priority support + * scsih_ncq_prio_supp - Check for NCQ command priority support * @sdev: scsi device struct * * This is called when a user indicates they would like to enable