| Message ID | 20250515162722.6933-2-quic_nitirawa@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Refactor ufs phy powerup sequence | expand |
On Thu, May 15, 2025 at 09:57:12PM +0530, Nitin Rawat wrote: > Introduce a new phy calibrate API call in the UFS Qualcomm driver to > separate phy calibration from phy power-on. This change is a precursor > to the next patchset in this series, which requires these two operations > to be distinct. > > Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com> > --- > drivers/ufs/host/ufs-qcom.c | 6 ++++++ > 1 file changed, 6 insertions(+) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
On Thu, May 15, 2025 at 09:57:12PM +0530, Nitin Rawat wrote: > Introduce a new phy calibrate API call in the UFS Qualcomm driver to > separate phy calibration from phy power-on. This change is a precursor > to the next patchset in this series, which requires these two operations 'next patchset in the series' wouldn't make sense once this patch gets merged. They all become commits. So you should mention 'successive commits'. > to be distinct. > > Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > drivers/ufs/host/ufs-qcom.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index 37887ec68412..23b4fc84dc8c 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -531,6 +531,12 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba) > goto out_disable_phy; > } > > + ret = phy_calibrate(phy); > + if (ret) { > + dev_err(hba->dev, "Failed to calibrate PHY: %d\n", ret); > + goto out_disable_phy; > + } > + > ufs_qcom_select_unipro_mode(host); > > return 0; > -- > 2.48.1 >
On 5/21/2025 6:38 PM, Manivannan Sadhasivam wrote: > On Thu, May 15, 2025 at 09:57:12PM +0530, Nitin Rawat wrote: >> Introduce a new phy calibrate API call in the UFS Qualcomm driver to >> separate phy calibration from phy power-on. This change is a precursor >> to the next patchset in this series, which requires these two operations > > 'next patchset in the series' wouldn't make sense once this patch gets merged. > They all become commits. So you should mention 'successive commits'. Sure, will address in next patchset. > >> to be distinct. >> >> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > - Mani > >> --- >> drivers/ufs/host/ufs-qcom.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c >> index 37887ec68412..23b4fc84dc8c 100644 >> --- a/drivers/ufs/host/ufs-qcom.c >> +++ b/drivers/ufs/host/ufs-qcom.c >> @@ -531,6 +531,12 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba) >> goto out_disable_phy; >> } >> >> + ret = phy_calibrate(phy); >> + if (ret) { >> + dev_err(hba->dev, "Failed to calibrate PHY: %d\n", ret); >> + goto out_disable_phy; >> + } >> + >> ufs_qcom_select_unipro_mode(host); >> >> return 0; >> -- >> 2.48.1 >> >
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 37887ec68412..23b4fc84dc8c 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -531,6 +531,12 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba) goto out_disable_phy; } + ret = phy_calibrate(phy); + if (ret) { + dev_err(hba->dev, "Failed to calibrate PHY: %d\n", ret); + goto out_disable_phy; + } + ufs_qcom_select_unipro_mode(host); return 0;
Introduce a new phy calibrate API call in the UFS Qualcomm driver to separate phy calibration from phy power-on. This change is a precursor to the next patchset in this series, which requires these two operations to be distinct. Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com> --- drivers/ufs/host/ufs-qcom.c | 6 ++++++ 1 file changed, 6 insertions(+)