mbox series

[v9,0/3] leds: trigger: implement a tty trigger

Message ID 20201018204022.910815-1-u.kleine-koenig@pengutronix.de
Headers show
Series leds: trigger: implement a tty trigger | expand

Message

Uwe Kleine-König Oct. 18, 2020, 8:40 p.m. UTC 
Hello,

this is v9 of this series. Changes compared to v8 sent with Message-Id
20201012123358.1475928-1-u.kleine-koenig@pengutronix.de on Oct 12:

 - make struct led_trigger ledtrig_tty static
 - drop write-only variable firstrun (which is a remains of the changes
   done in v8)

Both issues were found by the kernel test robot <lkp@intel.com>.

Best regards
Uwe

Uwe Kleine-König (3):
  tty: rename tty_kopen() and add new function tty_kopen_shared()
  tty: new helper function tty_get_icount()
  leds: trigger: implement a tty trigger

 .../ABI/testing/sysfs-class-led-trigger-tty   |   6 +
 drivers/accessibility/speakup/spk_ttyio.c     |   2 +-
 drivers/leds/trigger/Kconfig                  |   9 +
 drivers/leds/trigger/Makefile                 |   1 +
 drivers/leds/trigger/ledtrig-tty.c            | 184 ++++++++++++++++++
 drivers/tty/tty_io.c                          |  85 +++++---
 include/linux/tty.h                           |   7 +-
 7 files changed, 269 insertions(+), 25 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-class-led-trigger-tty
 create mode 100644 drivers/leds/trigger/ledtrig-tty.c


base-commit: bbf5c979011a099af5dc76498918ed7df445635b

Comments

Pavel Machek Oct. 20, 2020, 12:25 p.m. UTC | #1 
On Sun 2020-10-18 22:40:21, Uwe Kleine-König wrote:
> For a given struct tty_struct this yields the corresponding statistics
> about sent and received characters (and some more) which is needed to
> implement an LED trigger for tty devices.
> 
> The new function is then used to simplify tty_tiocgicount().
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Pavel Machek <pavel@ucw.cz>