mbox series

[v3,0/6] tty: serial: 8250: Changes of MOXA PCIe boards in 8250_pci.c

Message ID 20231018091739.10125-1-crescentcy.hsieh@moxa.com
Headers show
Series tty: serial: 8250: Changes of MOXA PCIe boards in 8250_pci.c | expand

Message

Crescent CY Hsieh Oct. 18, 2023, 9:17 a.m. UTC 
These patch series do some changes to MOXA PCIe boards in 8250_pci.c,
including:

- Modify MOXA enum name within 8250_pci.c
- Cleanup MOXA configurations within 8250_pci.c
- Relocate macros within 8250_pci.c
- Add support for MOXA Mini PCIe boards
- Fix MOXA RS422/RS485 boards not function by default
- Add support for MOXA PCIe boards to switch between different serial
  interfaces

Each patch depends on previous one.

---
Changes in v3:
- Add reviewer tag in first 4 patches.
- [PATCH v3 2/6]:
	- Make commit message clearer.
- [PATCH v3 5/6]:
	- Delete pci_moxa_match_x3xx() function.
	- Introduce pci_moxa_match_second_digit() function.
- [PATCH v3 6/6]:
	- Delete pci_moxa_match_x1xx() function.
	- Replace pci_moxa_match_x1xx() and pci_moxa_match_x3xx() with
	  pci_moxa_match_second_digit().
	- Add comment at pci_moxa_rs485_config().
	- Revise comment and return value where device not support RS232
	  interface.

Changes in v2:
- Split cleanup patch into first 2 patches of this patch series.
- Reposition macro list to the top of the code.
- Use PCI_VDEVICE() instead of PCI_DEVICE() in serial_pci_tbl[].
- Replace some C99 types with kernel types.
- Introduce functions for checking device ID pattern.
- Replace magic constant with BIT().
- Sort macros into pre-existing macro list.
- Rewrite set_interface condition architecture.
- Utilize unused flag to represent RS422 interface instead of adding a
  new one.

v2: https://lore.kernel.org/all/20231016033705.20669-1-crescentcy.hsieh@moxa.com/
v1: https://lore.kernel.org/all/20231002015702.30509-1-crescentcy.hsieh@moxa.com/

Crescent CY Hsieh (6):
  tty: serial: 8250: Modify MOXA enum name within 8250_pci.c
  tty: serial: 8250: Cleanup MOXA configurations within 8250_pci.c
  tty: serial: 8250: Relocate macros within 8250_pci.c
  tty: serial: 8250: Add support for MOXA Mini PCIe boards
  tty: serial: 8250: Fix MOXA RS422/RS485 PCIe boards not work by
    default
  tty: serial: 8250: Add support for MOXA PCIe boards to switch
    interface between RS422/RS485

 drivers/tty/serial/8250/8250_pci.c | 370 ++++++++++++++++++++---------
 1 file changed, 256 insertions(+), 114 deletions(-)

Comments

gregkh@linuxfoundation.org Oct. 21, 2023, 4:31 p.m. UTC | #1 
On Wed, Oct 18, 2023 at 05:17:33PM +0800, Crescent CY Hsieh wrote:
> These patch series do some changes to MOXA PCIe boards in 8250_pci.c,
> including:
> 
> - Modify MOXA enum name within 8250_pci.c
> - Cleanup MOXA configurations within 8250_pci.c
> - Relocate macros within 8250_pci.c
> - Add support for MOXA Mini PCIe boards
> - Fix MOXA RS422/RS485 boards not function by default
> - Add support for MOXA PCIe boards to switch between different serial
>   interfaces
> 
> Each patch depends on previous one.

I've applied the first 4 to my tree now, plaese fix up the last two and
send them as a new patch series for review.

thanks,

greg k-h