| Message ID | 20240306231007.13622-1-prabhakar.mahadev-lad.rj@bp.renesas.com |
|---|---|
| Headers | show |
| Series | dt-bindings: serial: renesas,scif: Validate 'interrupts' and 'interrupt-names' | expand |
On Thu, Mar 7, 2024 at 12:11 AM Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > In preparation for adding more validation checks move the ref for > 'serial.yaml' to the end and also move reset check in 'allOf' block. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On 07/03/2024 00:10, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > In preparation for adding more validation checks move the ref for > 'serial.yaml' to the end and also move reset check in 'allOf' block. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > .../bindings/serial/renesas,scif.yaml | 30 +++++++++---------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > index 4610a5bd580c..af72c3420453 100644 > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > @@ -9,9 +9,6 @@ title: Renesas Serial Communication Interface with FIFO (SCIF) > maintainers: > - Geert Uytterhoeven <geert+renesas@glider.be> > > -allOf: > - - $ref: serial.yaml# > - > properties: > compatible: > oneOf: > @@ -160,18 +157,21 @@ required: > - clock-names > - power-domains > > -if: > - properties: > - compatible: > - contains: > - enum: > - - renesas,rcar-gen2-scif > - - renesas,rcar-gen3-scif > - - renesas,rcar-gen4-scif > - - renesas,scif-r9a07g044 > -then: > - required: > - - resets > +allOf: > + - $ref: serial.yaml# > + Yeah, that's why usually we ask to put '$ref' and 'if' in allOf: block - saves you one syntax reindent which will confuse git blame. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Hi All, This patch series updates renesas,scif.yaml to validate the 'interrupts' and 'interrupt-names' properties for every supported SoC. Cheers, Prabhakar Lad Prabhakar (2): dt-bindings: serial: renesas,scif: Move ref for serial.yaml at the end dt-bindings: serial: renesas,scif: Validate 'interrupts' and 'interrupt-names' .../bindings/serial/renesas,scif.yaml | 147 ++++++++++++------ 1 file changed, 100 insertions(+), 47 deletions(-)