diff mbox series

[15/26] serial: mpc52xx_uart: drop low-latency workaround

Message ID	20210421095509.3024-16-johan@kernel.org
State	New
Headers	show Return-Path: <linux-serial-owner@kernel.org> From: Johan Hovold <johan@kernel.org> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Slaby <jirislaby@kernel.org>, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org> Subject: [PATCH 15/26] serial: mpc52xx_uart: drop low-latency workaround Date: Wed, 21 Apr 2021 11:54:58 +0200 Message-Id: <20210421095509.3024-16-johan@kernel.org> In-Reply-To: <20210421095509.3024-1-johan@kernel.org> References: <20210421095509.3024-1-johan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	tty: drop low-latency workarounds \| expand [00/26] tty: drop low-latency workarounds [01/26] tty: mxser: drop low-latency workaround [02/26] serial: altera_jtaguart: drop low-latency workaround [03/26] serial: altera_uart: drop low-latency workaround [04/26] serial: amba-pl010: drop low-latency workaround [05/26] serial: amba-pl011: drop low-latency workaround [06/26] serial: apbuart: drop low-latency workaround [07/26] serial: ar933x: drop low-latency workaround [08/26] serial: arc_uart: drop low-latency workaround [09/26] serial: atmel_serial: drop low-latency workaround [10/26] serial: bcm63xx: drop low-latency workaround [11/26] serial: icom: drop low-latency workaround [12/26] serial: lpc32xx_hs: drop low-latency workaround [13/26] serial: mcf: drop low-latency workaround [14/26] serial: meson: drop low-latency workaround [15/26] serial: mpc52xx_uart: drop low-latency workaround [16/26] serial: msm_serial: drop low-latency workaround [17/26] serial: owl: drop low-latency workaround [18/26] serial: rda: drop low-latency workaround [19/26] serial: rp2: drop low-latency workaround [20/26] serial: sa1100: drop low-latency workaround [21/26] serial: txx9: drop low-latency workaround [22/26] serial: sifive: drop low-latency workaround [23/26] serial: sunsu: drop low-latency workaround [24/26] serial: timbuart: drop low-latency workaround [25/26] serial: vt8500: drop low-latency workaround [26/26] serial: xilinx_uartps: drop low-latency workaround

Commit Message

Johan Hovold April 21, 2021, 9:54 a.m. UTC

Commit fbe543b412ce ("Fix a potential issue in mpc52xx uart driver")
worked around the infamous low_latency behaviour of
tty_flip_buffer_push() by simply dropping and reacquiring the port lock
in the interrupt handler.

Since commit a9c3f68f3cd8 ("tty: Fix low_latency BUG"),
tty_flip_buffer_push() always schedules a work item to push data to the
line discipline and there's no need to keep any low_latency hacks around.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/tty/serial/mpc52xx_uart.c | 2 --
 1 file changed, 2 deletions(-)

diff mbox series

Patch

diff --git a/drivers/tty/serial/mpc52xx_uart.c b/drivers/tty/serial/mpc52xx_uart.c
index af1700445251..2704dc988e4a 100644
--- a/drivers/tty/serial/mpc52xx_uart.c
+++ b/drivers/tty/serial/mpc52xx_uart.c
@@ -1421,9 +1421,7 @@  mpc52xx_uart_int_rx_chars(struct uart_port *port)
 		}
 	}
 
-	spin_unlock(&port->lock);
 	tty_flip_buffer_push(tport);
-	spin_lock(&port->lock);
 
 	return psc_ops->raw_rx_rdy(port);
 }